Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: archived reports are unable to mark as read" #46526

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Revert "fix: archived reports are unable to mark as read" #46526

merged 1 commit into from
Jul 30, 2024

Conversation

ishpaul777
Copy link
Contributor

@ishpaul777 ishpaul777 commented Jul 30, 2024 •
edited
Loading

Reverts #45240

$ #46501

Screen.Recording.2024-07-31.at.12.48.39.AM.mov

@ishpaul777 ishpaul777 mentioned this pull request Jul 30, 2024
Closed
6 tasks
@ishpaul777 ishpaul777 marked this pull request as ready for review July 30, 2024 19:09
@ishpaul777 ishpaul777 requested a review from a team as a code owner July 30, 2024 19:09
@melvin-bot melvin-bot bot requested review from danieldoglas and removed request for a team July 30, 2024 19:09
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jul 30, 2024

@danieldoglas Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@ishpaul777
Copy link
Contributor Author

straight revert so not added checklist, i can add a demo video though give me a min

@puneetlath puneetlath merged commit d6dda64 into Expensify:main Jul 30, 2024
12 of 17 checks passed
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jul 30, 2024

@puneetlath looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Jul 30, 2024
@puneetlath
Copy link
Contributor

Merged without checklists since it's a straight revert. Requesting CP now.

@ishpaul777 ishpaul777 mentioned this pull request Jul 30, 2024
Merged
50 tasks
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Jul 30, 2024
@puneetlath @OSBotify
Merge pull request #46526 from ishpaul777/revert-45240-hur/fix-45228
7575e94 
Revert "fix: archived reports are unable to mark as read"

(cherry picked from commit d6dda64)
@github-actions github-actions bot mentioned this pull request Jul 30, 2024
Closed
84 tasks
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.0.14-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@puneetlath
Copy link
Contributor

Confirmed it's fixed.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.14-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puneetlath puneetlath puneetlath approved these changes

@danieldoglas danieldoglas Awaiting requested review from danieldoglas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ishpaul777 @puneetlath @OSBotify