Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clicking pay button for invoices raise an null error #46317

Merged
merged 13 commits into from
Aug 2, 2024
Merged

fix clicking pay button for invoices raise an null error #46317

Changes from 9 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5a7e6a3
fix: null check instead of setting an empty value
jacobkim9881 Jul 26, 2024
267c7be
Merge branch 'main' of https://github.com/Expensify/App into 44919
jacobkim9881 Jul 26, 2024
64c1339
fix: type check failed
jacobkim9881 Jul 26, 2024
ceb7b41
canceled null check
jacobkim9881 Jul 26, 2024
71b5e5d
Merge branch '44919' of github.com:jacobkim9881/Expensify-App into 44919
jacobkim9881 Jul 26, 2024
a52a997
canceled null check
jacobkim9881 Jul 26, 2024
0177edf
Merge branch '44919' of github.com:jacobkim9881/Expensify-App into 44919
jacobkim9881 Jul 26, 2024
89d1ae1
fix typecheck, lint not passed
jacobkim9881 Jul 28, 2024
e1404d0
fix added null check in the script
jacobkim9881 Jul 28, 2024
d5638d5
build: pulled updates
jacobkim9881 Jul 31, 2024
f73e6a9
fix: parameter name edited
jacobkim9881 Jul 31, 2024
87c6ec9
Merge branch 'main' of https://github.com/Expensify/App into 44919
jacobkim9881 Aug 1, 2024
411cf41
Merge branch 'main' of https://github.com/Expensify/App into 44919
jacobkim9881 Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/ButtonWithDropdownMenu/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import type {MutableRefObject} from 'react';
import React, {useEffect, useRef, useState} from 'react';
import {View} from 'react-native';
import Button from '@components/Button';
Expand Down Expand Up @@ -45,6 +46,7 @@ function ButtonWithDropdownMenu<IValueType>({
const selectedItem = options[selectedItemIndex] || options[0];
const innerStyleDropButton = StyleUtils.getDropDownButtonHeight(buttonSize);
const isButtonSizeLarge = buttonSize === CONST.DROPDOWN_BUTTON_SIZE.LARGE;
const nullCheckRef = (ref: MutableRefObject<View | null>) => ref ?? null;

useEffect(() => {
if (!caretButton.current) {
Expand Down Expand Up @@ -139,7 +141,7 @@ function ButtonWithDropdownMenu<IValueType>({
onClose={() => setIsMenuVisible(false)}
onItemSelected={() => setIsMenuVisible(false)}
anchorPosition={popoverAnchorPosition}
anchorRef={caretButton}
anchorRef={nullCheckRef(caretButton)}
withoutOverlay
anchorAlignment={anchorAlignment}
headerText={menuHeaderText}
Expand Down
Loading