Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log unhandled promise rejections to the server #46173

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Log unhandled promise rejections to the server #46173

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c8e2c2
Log unhandled promise rejections to the server
Kureev Jul 25, 2024
a932817
Improve error handling experience and add handlers to the native plat…
Kureev Jul 29, 2024
dafadb9
Revert ErrorBoundary .native counterpart
Kureev Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/components/ErrorBoundary/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import React, {useEffect} from 'react';
import Log from '@libs//Log';
import BaseErrorBoundary from './BaseErrorBoundary';
import type {BaseErrorBoundaryProps, LogError} from './types';
Expand All @@ -8,7 +8,17 @@ const logError: LogError = (errorMessage, error, errorInfo) => {
Log.alert(`${errorMessage} - ${error.message}`, {errorInfo}, false);
};

const onUnhandledRejection = (event: PromiseRejectionEvent) => {
Log.alert(`Unhandled Promise Rejection: ${event.reason}`, {}, false);
};

function ErrorBoundary({errorMessage, children}: Omit<BaseErrorBoundaryProps, 'logError'>) {
// Log unhandled promise rejections to the server
useEffect(() => {
window.addEventListener('unhandledrejection', onUnhandledRejection);
return () => window.removeEventListener('unhandledrejection', onUnhandledRejection);
}, []);

return (
<BaseErrorBoundary
errorMessage={errorMessage}
Expand Down
Loading