[No QA] Asking for company name and URL during invoice creation #46009

VickyStash · 2024-07-23T13:01:43Z

Details

Updates the invoice creation flow to support adding company name and URL if it wasn't added before.

Fixed Issues

$ #45174
$ #45173
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

!Pre-step: Update hasInvoicingDetails check to always return false so you can always see the expected screen. Please, remember that API doesn't support adding company name and the website for now.

Press FAB -> Send Invoice
Go through the steps to reach the confirmation screen. Make sure you see the Next button instead of Send Invoice.
Tap on the Next. You should appear on the Company info page. Make sure it looks as expected.
Make sure the validation on the page works as expected.
Tap Send invoice -> the invoice should be successfully created.

Offline tests

Same as in the Tests section

QA Steps

Verify that no errors appear in the JS console

N/A

PR Author Checklist

Screenshots/Videos

Android: Native

android1.mp4

Android: mWeb Chrome

android_web1.mp4

iOS: Native

ios1.mp4

iOS: mWeb Safari

ios_web1.mp4

MacOS: Chrome / Safari

web1.mp4

MacOS: Desktop

desktop1.mp4

VickyStash · 2024-07-24T12:44:38Z

src/languages/es.ts

+        companyInfo: 'Información de la empresa',
+        companyInfoDescription: 'Necesitamos algunos detalles más antes de que pueda enviar su primera factura.',
+        yourCompanyName: 'Nombre de su empresa',
+        yourCompanyWebsite: 'Sitio web de su empresa',
+        yourCompanyWebsiteNote: 'Si no tiene un sitio web, puede proporcionar el perfil de LinkedIn o de las redes sociales de su empresa.',
+        invalidDomainError: 'Ha introducido un dominio no válido. Para continuar, introduzca un dominio válido.',
+        publicDomainError: 'Ha introducido un dominio público. Para continuar, introduzca un dominio privado.',


I've asked for translations approve in the slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1721825016527359

melvin-bot · 2024-07-25T06:34:41Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/ValidationUtils.ts

src/pages/iou/request/step/IOURequestStepCompanyInfo.tsx

getusha · 2024-07-25T18:45:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-06.at.2.35.09.in.the.afternoon.mov

Android: mWeb Chrome

Screen.Recording.2024-07-30.at.11.10.14.at.night.mov

iOS: Native

Screen.Recording.2024-08-06.at.2.49.34.in.the.afternoon.mov

iOS: mWeb Safari

Screen.Recording.2024-07-30.at.11.27.36.at.night.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-30.at.10.21.56.at.night.mov

MacOS: Desktop

Screen.Recording.2024-08-06.at.2.19.33.in.the.afternoon.mov

VickyStash · 2024-07-26T07:37:26Z

@getusha I've applied the requested updates, please take another look

VickyStash · 2024-07-29T06:30:20Z

@getusha kind bump 🙂

madmax330 · 2024-07-30T16:06:57Z

@getusha can you prioritize getting this done please?

getusha · 2024-07-30T16:40:52Z

@getusha can you prioritize getting this done please?

👍 will be on it in 2 hours.

getusha · 2024-07-30T19:16:08Z

@VickyStash seems like we don't allow urls without protocols, and the error message doesn't looks like misleading. should we have a new copy for this? wdyt @VickyStash?

VickyStash · 2024-07-31T07:16:32Z

@VickyStash seems like we don't allow urls without protocols, and the error message doesn't looks like misleading. should we have a new copy for this? wdyt @VickyStash?

I've reused the existing isValidWebsite check for the website validity and the existing error message.
@madmax330 Should I use another message/method to check it?

madmax330 · 2024-08-05T08:42:05Z

I think this message is fine since we already validate this type of field

…45174-invoice-company-info

VickyStash · 2024-08-06T08:53:30Z

@getusha Could you please continue your review?

getusha · 2024-08-06T11:33:45Z

BUG: Crash when sending invoice from chat 2nd time

Send invoice using the steps in the PR description
Press the + from the composer
Send Invoice > Enter Amount > Next > Next

Note: you may have to try again a couple of times

Screen.Recording.2024-08-06.at.2.25.10.in.the.afternoon.mov

getusha · 2024-08-06T11:40:29Z

We need the company name and URL to create a Stripe Connect account, and so we will ask this one time, on the very first invoice being sent from a workspace

@VickyStash It always navigates me to enter both fields as new, despite filling it for previous invoices.

Screen.Recording.2024-08-06.at.2.35.09.in.the.afternoon.mov

VickyStash · 2024-08-06T11:44:55Z

@VickyStash It always navigates me to enter both fields as new, despite filling it for previous invoices.

It's cause you followed the pre-step described in the PR:

!Pre-step: Update hasInvoicingDetails check to always return false so you can always see the expected screen. Please, remember that API doesn't support adding company name and the website for now.

@getusha So it always shows you the screen for testing purposes cause you updated it so. When the API updated the check will works as expected.

VickyStash · 2024-08-06T11:47:19Z

BUG: Crash when sending invoice from chat 2nd time

Send invoice using the steps in the PR description

Press the + from the composer

Send Invoice > Enter Amount > Next > Next

Note: you may have to try again a couple of times

Screen.Recording.2024-08-06.at.2.25.10.in.the.afternoon.mov

@getusha It looks like this bug isn't related to this PR, see relevant issue #46821

getusha · 2024-08-06T11:55:20Z

It's cause you followed the pre-step described in the PR:

We will be handling that as a follow up? is it awaiting backend changes?

VickyStash · 2024-08-06T13:46:03Z

We will be handling that as a follow up? is it awaiting backend changes?

Yes, I'll prepare a follow-up when API is ready

OSBotify · 2024-08-06T14:17:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-07T22:11:54Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.0.18-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-12T10:03:08Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.18-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

VickyStash added 3 commits July 23, 2024 14:09

Create IOURequestStepCompanyInfo page

b8ae247

Add a check for invoicing details

3005b89

Implemented validation on company info page

5d4bc34

VickyStash mentioned this pull request Jul 23, 2024

[HOLD for payment 2024-08-19] Asking for company name and URL on the first invoice being sent #45174

Closed

VickyStash added 3 commits July 24, 2024 12:28

Update sendInvoice function

b532062

Lint fix

358bdf2

Small lint fix

9ac2138

VickyStash commented Jul 24, 2024

View reviewed changes

VickyStash changed the title ~~[WIP] [No QA] Asking for company name and URL during invoice creation~~ [No QA] Asking for company name and URL during invoice creation Jul 25, 2024

VickyStash marked this pull request as ready for review July 25, 2024 06:34

VickyStash requested a review from a team as a code owner July 25, 2024 06:34

melvin-bot bot requested review from getusha and removed request for a team July 25, 2024 06:34

VickyStash mentioned this pull request Jul 25, 2024

[HOLD for payment 2024-08-19] Updating Invoice creation flow #45173

Closed

getusha reviewed Jul 25, 2024

View reviewed changes

src/libs/ValidationUtils.ts Outdated Show resolved Hide resolved

src/pages/iou/request/step/IOURequestStepCompanyInfo.tsx Show resolved Hide resolved

src/pages/iou/request/step/IOURequestStepCompanyInfo.tsx Outdated Show resolved Hide resolved

Minor improvements

1a8c403

VickyStash mentioned this pull request Jul 26, 2024

[HOLD for payment 2024-11-11] Invoicing details section #45176

Closed

Merge remote-tracking branch 'refs/remotes/origin/main' into feature/…

089f64e

…45174-invoice-company-info

getusha approved these changes Aug 6, 2024

View reviewed changes

melvin-bot bot requested a review from madmax330 August 6, 2024 11:55

madmax330 approved these changes Aug 6, 2024

View reviewed changes

madmax330 merged commit 33a7a29 into Expensify:main Aug 6, 2024
15 checks passed

github-actions bot mentioned this pull request Aug 7, 2024

Deploy Checklist: New Expensify 2024-08-07 #47006

Closed

88 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] Asking for company name and URL during invoice creation #46009

[No QA] Asking for company name and URL during invoice creation #46009

VickyStash commented Jul 23, 2024 •

edited

Loading

VickyStash Jul 24, 2024

melvin-bot bot commented Jul 25, 2024

getusha commented Jul 25, 2024 •

edited

Loading

VickyStash commented Jul 26, 2024

VickyStash commented Jul 29, 2024

madmax330 commented Jul 30, 2024

getusha commented Jul 30, 2024

getusha commented Jul 30, 2024

VickyStash commented Jul 31, 2024

madmax330 commented Aug 5, 2024

VickyStash commented Aug 6, 2024

getusha commented Aug 6, 2024

getusha commented Aug 6, 2024

VickyStash commented Aug 6, 2024

VickyStash commented Aug 6, 2024

getusha commented Aug 6, 2024

VickyStash commented Aug 6, 2024

OSBotify commented Aug 6, 2024

OSBotify commented Aug 7, 2024

OSBotify commented Aug 12, 2024

[No QA] Asking for company name and URL during invoice creation #46009

[No QA] Asking for company name and URL during invoice creation #46009

Conversation

VickyStash commented Jul 23, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

VickyStash Jul 24, 2024

Choose a reason for hiding this comment

melvin-bot bot commented Jul 25, 2024

getusha commented Jul 25, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

VickyStash commented Jul 26, 2024

VickyStash commented Jul 29, 2024

madmax330 commented Jul 30, 2024

getusha commented Jul 30, 2024

getusha commented Jul 30, 2024

VickyStash commented Jul 31, 2024

madmax330 commented Aug 5, 2024

VickyStash commented Aug 6, 2024

getusha commented Aug 6, 2024

getusha commented Aug 6, 2024

VickyStash commented Aug 6, 2024

VickyStash commented Aug 6, 2024

getusha commented Aug 6, 2024

VickyStash commented Aug 6, 2024

OSBotify commented Aug 6, 2024

OSBotify commented Aug 7, 2024

OSBotify commented Aug 12, 2024

VickyStash commented Jul 23, 2024 •

edited

Loading

getusha commented Jul 25, 2024 •

edited

Loading