Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Scan - No error pop-up and scan expense with corrupted PDF can be submitted via QAB #44778

Merged
merged 21 commits into from
Jul 22, 2024
Merged

fix: Scan - No error pop-up and scan expense with corrupted PDF can be submitted via QAB #44778

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
0caf904
feat: corrupt pdf detection on scan page.
Krishna2323 Jun 13, 2024
2a76f6d
Merge branch 'Expensify:main' into krishna2323/test/43645
Krishna2323 Jun 19, 2024
4cbf8e2
add pdf validation for native.
Krishna2323 Jun 19, 2024
a26c5b6
Merge branch 'Expensify:main' into krishna2323/test/43645
Krishna2323 Jun 23, 2024
80fa7bb
corrupt pdf alert fix for android.
Krishna2323 Jun 23, 2024
65c1537
Merge branch 'Expensify:main' into krishna2323/test/43645
Krishna2323 Jul 3, 2024
3f1fafa
Merge branch 'Expensify:main' into krishna2323/issue/43645
Krishna2323 Jul 6, 2024
2a7cbe9
minor updated.
Krishna2323 Jul 6, 2024
458c75d
cleanup.
Krishna2323 Jul 6, 2024
85e166e
minor fix.
Krishna2323 Jul 6, 2024
e4eb9a2
minor update/
Krishna2323 Jul 6, 2024
29ad495
refactor.
Krishna2323 Jul 6, 2024
881dba7
fix rendering issue.
Krishna2323 Jul 6, 2024
33b3912
minor update.
Krishna2323 Jul 6, 2024
1a5c19b
Merge branch 'Expensify:main' into krishna2323/issue/43645
Krishna2323 Jul 10, 2024
f36966d
minor updates.
Krishna2323 Jul 10, 2024
1a71c50
Merge branch 'Expensify:main' into krishna2323/issue/43645
Krishna2323 Jul 15, 2024
24b07d5
add invisible pdf styling.
Krishna2323 Jul 15, 2024
ace0862
add comment.
Krishna2323 Jul 15, 2024
105356b
add comment.
Krishna2323 Jul 15, 2024
8d553b0
minor fix.
Krishna2323 Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/pages/iou/request/step/IOURequestStepScan/index.native.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,7 @@ function IOURequestStepScan({
return;
}

// If we have a pdf file and if it is not validated then set the pdf file for validation and return
if (Str.isPDF(file.name ?? '') && !isPdfValidated) {
setPdfFile(file);
return;
Expand Down Expand Up @@ -466,7 +467,7 @@ function IOURequestStepScan({
>
{pdfFile && (
<PDFThumbnail
style={{height: 1, width: 1, opacity: 0, position: 'absolute'}}
style={styles.invisiblePdf}
previewSourceURL={pdfFile?.uri ?? ''}
onLoadSuccess={() => {
setPdfFile(null);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we call this with null here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason PDF isn't re-rendering on android native when file is changed to another file so we need to set it to null first.

Expand Down
4 changes: 3 additions & 1 deletion src/pages/iou/request/step/IOURequestStepScan/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,8 @@ function IOURequestStepScan({
if (!isFileValid) {
return;
}

// If we have a pdf file and if it is not validated then set the pdf file for validation and return
if (Str.isPDF(file.name ?? '') && !isPdfValidated) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you explain the check for a not validated pdf here?

setPdfFile(file);
return;
Expand Down Expand Up @@ -517,7 +519,7 @@ function IOURequestStepScan({

const PDFThumbnailView = pdfFile ? (
<PDFThumbnail
style={{position: 'absolute', opacity: 0, width: 1, height: 1}}
style={styles.invisiblePdf}
previewSourceURL={pdfFile.uri ?? ''}
onLoadSuccess={() => {
setPdfFile(null);
Expand Down
7 changes: 7 additions & 0 deletions src/styles/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,6 +1038,13 @@ const styles = (theme: ThemeColors) =>
justifyContent: 'center',
},

invisiblePdf: {
position: 'absolute',
opacity: 0,
width: 1,
height: 1,
},

headerAnonymousFooter: {
color: theme.heading,
fontFamily: FontUtils.fontFamily.platform.EXP_NEW_KANSAS_MEDIUM,
Expand Down
Loading