Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add more space to bottom docked button #44761
Fix: Add more space to bottom docked button #44761
Changes from 10 commits
45ce16e
731fce3
0385749
6f1fe83
b1d80d2
01f07a2
1a12356
abeea96
1a62cc3
d38e7cb
7154df6
b4d5e09
4561a85
66d446f
bd01400
0f06221
b2844e0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you typecast the boolean type of the variable and also rename the variable to something more readable like:
isKeyboardVisible
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the type for it. But I don't think we should rename the state, because as I mentioned above,
willKeyboardShow
is used to fix the issuedidKeyboardShow
encountered: There is a delay when the keyboard is visible by the user and the whendidKeyboardShow
is set totrue
. So it is not justisKeyboardVisible
.