Fix: Implement skeleton view in workspace member page #43893

truph01 · 2024-06-18T10:33:06Z

Details

Fixed Issues

$ #43605
PROPOSAL: #43605 (comment)

Tests

Open app.
Go to workspace member page
When the data is loading, verify there is a skeleton displayed:

In large screen:

Screen.Recording.2024-06-25.at.15.43.34.mov

In small screen:

Screen.Recording.2024-06-25.at.15.57.38.mov

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-06-25.at.15.58.27.mov

Android: mWeb Chrome

Screen.Recording.2024-06-25.at.15.51.39.mov

iOS: Native

Screen.Recording.2024-06-25.at.15.57.38.mov

iOS: mWeb Safari

Screen.Recording.2024-06-25.at.15.50.24.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-18.at.17.34.33.mov

MacOS: Desktop

Screen.Recording.2024-06-18.at.17.34.33.mov

melvin-bot · 2024-06-18T10:33:12Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

truph01 · 2024-06-18T10:38:23Z

@shawnborton Do we have a ticket to handle a small screen? Currently with the change in PR, small screen looks like:

Screen.Recording.2024-06-18.at.17.36.51.mov

shawnborton · 2024-06-19T06:51:33Z

Do we have a ticket to handle a small screen? Currently with the change in PR, small screen looks like:

I don't think we need to show anything different for small screens - what you have looks good to me.

shawnborton · 2024-06-19T08:08:48Z

Tested and this feels pretty good to me!

jjcoffee · 2024-06-19T10:43:37Z

@truph01 Please can you fix the lint errors? Thanks 🙏

truph01 · 2024-06-20T08:52:29Z

@jjcoffee I fixed lint errors.

jjcoffee · 2024-06-20T14:27:38Z

@truph01 Thanks! I will test soon, once BE issues are resolved.

jjcoffee · 2024-06-24T11:41:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-app-2024-06-24_14.30.34.mp4

Android: mWeb Chrome

android-chrome-2024-06-24_14.35.32.mp4

iOS: Native

ios-app-2024-06-24_14.16.40.mp4

iOS: mWeb Safari

ios-safari-2024-06-24_14.18.20.mp4

MacOS: Chrome / Safari

desktop-chrome-2024-06-24_14.20.11.mp4

MacOS: Desktop

desktop-app-2024-06-24_14.26.45.mp4

jjcoffee · 2024-06-24T12:15:44Z

@truph01 You've ticked off all items on the checklist but you haven't actually completed every item. You're missing test steps and there are no screenshots for iOS & Android. Please can you make sure you complete all checklist items before marking your PR ready for review in future.

jjcoffee · 2024-06-24T13:10:11Z

src/components/UserListSkeletonView.tsx

@@ -0,0 +1,41 @@
+import React from 'react';


Since this is extremely similar to OptionsListSkeletonView, I'm wondering if it would be better to just pass a prop like isTableList to OptionsListSkeletonView, which would keep things more DRY. Any thoughts?

@jjcoffee Sorry, you mean that we should remove the UserListSkeletonView component, then handle it in OptionListSkeletonView by passing prop isUserList, right?

Yeah I think that's tidier, unless you have any other thoughts! I think isTableList as a prop name fits better here as we're only styling the list as a table, rather than changing the layout from the base layout to fit something specific for a user list.

@jjcoffee In the main branch, we already have TableListItemSkeleton, ItemListSkeletonView, and OptionListSkeletonView (which is based on ItemListSkeletonView). In this PR, we just added a new skeleton component, UserListSkeletonView. To maintain consistency with other skeleton components, we should keep UserListSkeletonView as is. If we plan to let OptionListSkeletonView handle UserListSkeletonView by passing isUserList, we should apply the same approach to the other skeleton components like TableListItemSkeleton and ItemListSkeletonView.

My point is that UserListSkeletonView is almost identical to OptionListSkeletonView, so I'm not sure how useful it is to split it out into a new component since it doesn't apply any layout changes, just a few style tweaks (as far as I can tell). OptionListSkeletonView and TableListItemSkeleton both use ItemListSkeletonView, so I'm not sure your point applies here. Unless I'm missing something!

OptionListSkeletonView uses TableListItemSkeleton which uses ItemListSkeletonView

Sorry, why did you say that OptionListSkeletonView uses TableListItemSkeleton? Is there any mistake here?

Haha oops sorry, I meant that they both use ItemListSkeletonView. We are displaying an OptionList here, so I don't know if it makes sense to add a new component as not all user lists should be displayed as tables. I think we are fundamentally saying "here's an option list, but we want it to look like a table". TableListItemSkeleton uses a completely different layout (not just styling), that's why it needs to be split into a separate component.

truph01 · 2024-06-25T09:05:19Z

You've ticked off all items on the checklist but you haven't actually completed every item. You're missing test steps and there are no screenshots for iOS & Android. Please can you make sure you complete all checklist items before marking your PR ready for review in future.

@jjcoffee Oh, I noted that. I've updated all the test steps and videos. Initially, I didn't include the videos on mobile devices because I needed confirmation about this question. After receiving internal confirmation, I forgot to add them. It is my bad.

truph01 · 2024-06-25T12:23:05Z

@jjcoffee I updated PR to fix your comment.

jjcoffee

LGTM! Thanks 🙏

shawnborton · 2024-06-25T14:59:24Z

Before we merge, let's get a quick @Expensify/design review (I'll look now)

shawnborton · 2024-06-25T15:00:28Z

@truph01 can you confirm that the table rows have horizontal padding of 16px and vertical padding of 12px? Like so:

shawnborton · 2024-06-25T15:01:39Z

It looks like the left edge might be using 20px padding so just wanna check that quickly.

github-actions · 2024-06-25T15:33:14Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/43893/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/43893/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/43893/NewExpensify.dmg	https://43893.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

blimpich

Code LGTM, @shawnborton let me know if the style seems good to you.

shawnborton · 2024-06-25T17:52:18Z

@truph01 can you check my comment above? I can't seem to test this very well, the loading state goes away immediately.

truph01 · 2024-06-25T20:12:46Z

It looks like the left edge might be using 20px padding so just wanna check that quickly.

I fixed via commit. Here is result:

shawnborton · 2024-06-25T20:54:04Z

That feels better. Can you confirm that the two stacked lines are 12px away from the circle shape to their left? That's the last confirmation I think we need before we can merge this. Thanks!

truph01 · 2024-06-25T21:02:43Z

@shawnborton

That feels better. Can you confirm that the two stacked lines are 12px away from the circle shape to their left? That's the last confirmation I think we need before we can merge this. Thanks!

I updated PR. Here is result:

shawnborton · 2024-06-25T21:04:51Z

Wonderful, thanks! All good on my end, cc @Expensify/design in case you see anything, otherwise this is looking good to go @blimpich

blimpich · 2024-06-25T21:06:49Z

will give it till EOD for others to comment on the updated style, then I'll merge if nothing comes up

OSBotify · 2024-06-25T23:42:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-03T19:38:33Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T10:56:53Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix: Implement skeleton view in workspace member page

e80539f

truph01 requested a review from a team as a code owner June 18, 2024 10:33

melvin-bot bot requested review from jjcoffee and removed request for a team June 18, 2024 10:33

truph01 mentioned this pull request Jun 18, 2024

[HOLD for payment 2024-07-10] [$250] Skeleton loader doesn't show as table rows for table views #43605

Closed

6 tasks

truph01 added 2 commits June 18, 2024 17:38

Fix: Remove two last lines

135663a

Fix: Type

c97a944

shawnborton added the Ready To Build label Jun 19, 2024

This comment has been minimized.

Sign in to view

truph01 added 4 commits June 19, 2024 17:49

Fix: Merge main

c0f0d07

Fix: Lint

aea1528

Fix: Lint

d38cf0b

Fix: Lint

a1b38f8

jjcoffee reviewed Jun 24, 2024

View reviewed changes

truph01 added 2 commits June 25, 2024 15:08

Fix: Conflict

02d824f

Fix: Remove inline styles

ee1ec27

truph01 added 2 commits June 25, 2024 18:11

Fix: Remove UserListSkeletonView

2b60ac5

Fix: Comment

08db8dc

jjcoffee approved these changes Jun 25, 2024

View reviewed changes

melvin-bot bot requested a review from blimpich June 25, 2024 13:08

jjcoffee approved these changes Jun 25, 2024

View reviewed changes

blimpich previously approved these changes Jun 25, 2024

View reviewed changes

Fix: Using padding left 16px

8913b18

truph01 dismissed blimpich’s stale review via 8913b18 June 25, 2024 20:11

Fix: Apply x position 68 to two stacked lines

1802c67

blimpich approved these changes Jun 25, 2024

View reviewed changes

blimpich merged commit e7e9304 into Expensify:main Jun 25, 2024
14 checks passed

situchan mentioned this pull request Jun 26, 2024

Fix: three not found view v2 #41665

Merged

48 tasks

github-actions bot mentioned this pull request Jun 27, 2024

Deploy Checklist: New Expensify 2024-06-27 #44575

Closed

85 tasks

izarutskaya mentioned this pull request Jun 28, 2024

Workspace - Skeleton loader not displayed in workspace member page #44604

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Implement skeleton view in workspace member page #43893

Fix: Implement skeleton view in workspace member page #43893

truph01 commented Jun 18, 2024 •

edited

Loading

melvin-bot bot commented Jun 18, 2024

truph01 commented Jun 18, 2024

shawnborton commented Jun 19, 2024

This comment has been minimized.

shawnborton commented Jun 19, 2024

jjcoffee commented Jun 19, 2024

truph01 commented Jun 20, 2024

jjcoffee commented Jun 20, 2024

jjcoffee commented Jun 24, 2024 •

edited

Loading

jjcoffee commented Jun 24, 2024

jjcoffee Jun 24, 2024

truph01 Jun 25, 2024

jjcoffee Jun 25, 2024

truph01 Jun 25, 2024

jjcoffee Jun 25, 2024 •

edited

Loading

truph01 Jun 25, 2024 •

edited

Loading

jjcoffee Jun 25, 2024

truph01 commented Jun 25, 2024

truph01 commented Jun 25, 2024

jjcoffee left a comment

shawnborton commented Jun 25, 2024

shawnborton commented Jun 25, 2024

shawnborton commented Jun 25, 2024

github-actions bot commented Jun 25, 2024

blimpich left a comment

shawnborton commented Jun 25, 2024

truph01 commented Jun 25, 2024

shawnborton commented Jun 25, 2024

truph01 commented Jun 25, 2024

shawnborton commented Jun 25, 2024

blimpich commented Jun 25, 2024

OSBotify commented Jun 25, 2024

OSBotify commented Jul 3, 2024

OSBotify commented Jul 10, 2024

Fix: Implement skeleton view in workspace member page #43893

Fix: Implement skeleton view in workspace member page #43893

Conversation

truph01 commented Jun 18, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 18, 2024

truph01 commented Jun 18, 2024

shawnborton commented Jun 19, 2024

This comment has been minimized.

shawnborton commented Jun 19, 2024

jjcoffee commented Jun 19, 2024

truph01 commented Jun 20, 2024

jjcoffee commented Jun 20, 2024

jjcoffee commented Jun 24, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

jjcoffee commented Jun 24, 2024

jjcoffee Jun 24, 2024

Choose a reason for hiding this comment

truph01 Jun 25, 2024

Choose a reason for hiding this comment

jjcoffee Jun 25, 2024

Choose a reason for hiding this comment

truph01 Jun 25, 2024

Choose a reason for hiding this comment

jjcoffee Jun 25, 2024 • edited Loading

Choose a reason for hiding this comment

truph01 Jun 25, 2024 • edited Loading

Choose a reason for hiding this comment

jjcoffee Jun 25, 2024

Choose a reason for hiding this comment

truph01 commented Jun 25, 2024

truph01 commented Jun 25, 2024

jjcoffee left a comment

Choose a reason for hiding this comment

shawnborton commented Jun 25, 2024

shawnborton commented Jun 25, 2024

shawnborton commented Jun 25, 2024

github-actions bot commented Jun 25, 2024

blimpich left a comment

Choose a reason for hiding this comment

shawnborton commented Jun 25, 2024

truph01 commented Jun 25, 2024

shawnborton commented Jun 25, 2024

truph01 commented Jun 25, 2024

shawnborton commented Jun 25, 2024

blimpich commented Jun 25, 2024

OSBotify commented Jun 25, 2024

OSBotify commented Jul 3, 2024

OSBotify commented Jul 10, 2024

truph01 commented Jun 18, 2024 •

edited

Loading

jjcoffee commented Jun 24, 2024 •

edited

Loading

jjcoffee Jun 25, 2024 •

edited

Loading

truph01 Jun 25, 2024 •

edited

Loading