Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offline indicator appears in Edit categories RHP on large layout #43740

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Fix offline indicator appears in Edit categories RHP on large layout #43740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/ScreenWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ function ScreenWrapper(
const navigationFallback = useNavigation<StackNavigationProp<RootStackParamList>>();
const navigation = navigationProp ?? navigationFallback;
const {windowHeight} = useWindowDimensions(shouldUseCachedViewportHeight);
const {isSmallScreenWidth} = useResponsiveLayout();
const {isSmallScreenWidth, shouldUseNarrowLayout} = useResponsiveLayout();
const {initialHeight} = useInitialDimensions();
const styles = useThemeStyles();
const keyboardState = useKeyboardState();
Expand Down Expand Up @@ -279,7 +279,7 @@ function ScreenWrapper(
: children
}
{isSmallScreenWidth && shouldShowOfflineIndicator && <OfflineIndicator style={offlineIndicatorStyle} />}
{!isSmallScreenWidth && shouldShowOfflineIndicatorInWideScreen && (
{!shouldUseNarrowLayout && shouldShowOfflineIndicatorInWideScreen && (
<OfflineIndicator
containerStyles={[]}
style={[styles.pl5, styles.offlineIndicatorRow, offlineIndicatorStyle]}
Expand Down
Loading