-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate payment card section with API #43473
Merged
blimpich
merged 9 commits into
Expensify:main
from
pasyukevich:feature/card-billing-banner-api-integration
Jun 21, 2024
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1601259
integrate payment card section with API
pasyukevich 049a75c
fix translations
pasyukevich b6fe126
add tests, update utils , address comments
pasyukevich abe1923
fix billing date calculation issue
pasyukevich 08e6547
fix billing date
pasyukevich 2d624ca
add comment to CardsSectionUtilsTest
JKobrynski 59b2bf5
update comment in CardsSectionUtilsTest
JKobrynski e1b6425
Merge branch 'main' into feature/card-billing-banner-api-integration
JKobrynski 134e433
Merge branch 'main' into feature/card-billing-banner-api-integration
JKobrynski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,25 @@ | ||
import {addMonths, format, startOfMonth} from 'date-fns'; | ||
import * as SubscriptionUtils from '@libs/SubscriptionUtils'; | ||
import CONST from '@src/CONST'; | ||
|
||
/** | ||
* Get the next billing date. | ||
* | ||
* @returns - The next billing date in 'yyyy-MM-dd' format. | ||
*/ | ||
function getNextBillingDate(): string { | ||
const today = new Date(); | ||
|
||
const nextBillingDate = startOfMonth(addMonths(today, 1)); | ||
|
||
return format(nextBillingDate, CONST.DATE.MONTH_DAY_YEAR_FORMAT); | ||
} | ||
|
||
function shouldShowPreTrialBillingBanner(): boolean { | ||
return !SubscriptionUtils.isUserOnFreeTrial() && !SubscriptionUtils.hasUserFreeTrialEnded(); | ||
} | ||
|
||
export default { | ||
shouldShowPreTrialBillingBanner, | ||
getNextBillingDate, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
import CardSectionUtils from '@src/pages/settings/Subscription/CardSection/utils'; | ||
|
||
describe('getNextBillingDate', () => { | ||
beforeAll(() => { | ||
jest.useFakeTimers(); | ||
// Month is zero indexed, so this is July 5th 2024 | ||
jest.setSystemTime(new Date(2024, 6, 5)); | ||
}); | ||
|
||
afterAll(() => { | ||
jest.useRealTimers(); | ||
}); | ||
|
||
it('should return the next billing date when initial date is valid', () => { | ||
const expectedNextBillingDate = 'August 1, 2024'; | ||
|
||
expect(CardSectionUtils.getNextBillingDate()).toEqual(expectedNextBillingDate); | ||
}); | ||
|
||
it('should handle end-of-month edge cases correctly', () => { | ||
const nextBillingDate = CardSectionUtils.getNextBillingDate(); | ||
const expectedNextBillingDate = 'August 1, 2024'; | ||
expect(nextBillingDate).toBe(expectedNextBillingDate); | ||
}); | ||
|
||
it('should handle date when it at the current month', () => { | ||
const nextBillingDate = CardSectionUtils.getNextBillingDate(); | ||
const expectedNextBillingDate = 'August 1, 2024'; | ||
expect(nextBillingDate).toBe(expectedNextBillingDate); | ||
}); | ||
|
||
it('should return the next billing date when initial date is invalid', () => { | ||
const expectedNextBillingDate = 'August 1, 2024'; | ||
|
||
expect(CardSectionUtils.getNextBillingDate()).toEqual(expectedNextBillingDate); | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB, maybe we can add a comment that month is zero-indexed? It tripped me up for a sec 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
CC: @blimpich
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the comment? I think what Amy meant was something like this