Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: navigate to invite list by arrow keys #42713

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Fix: navigate to invite list by arrow keys #42713

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c0ef9e
Fix: navigate to invite list by arrow keys
dragnoir May 28, 2024
9a6f4d9
Merge branch 'Expensify:main' into 41906-fix
dragnoir May 29, 2024
f65da7c
Merge branch 'Expensify:main' into 41906-fix
dragnoir Jun 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/SelectionList/BaseSelectionList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ function BaseSelectionList<TItem extends ListItem>(
initialFocusedIndex: flattenedSections.allOptions.findIndex((option) => option.keyForList === initiallyFocusedOptionKey),
maxIndex: Math.min(flattenedSections.allOptions.length - 1, CONST.MAX_SELECTION_LIST_PAGE_LENGTH * currentPage - 1),
disabledIndexes: disabledArrowKeyIndexes,
isActive: true,
isActive: isFocused,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line of change caused an issue #54587 where the background page of the Category list moved with the up and down keys when the RHP was opened. We removed this change #54587 (comment), which fixed the original issue 54587, and now this issue #41906 no longer occurs. Therefore, this change was redundant.

onFocusedIndexChange: (index: number) => {
scrollToIndex(index, true);
},
Expand Down
Loading