Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow split expense in announce room when creating workspace #42624

Merged
merged 5 commits into from
May 28, 2024
Merged

Disallow split expense in announce room when creating workspace #42624

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dbef557
Disallow split expense in announce room when creating workspace
nkdengineer May 27, 2024
c32bec5
disallow split expense for announce at all
nkdengineer May 27, 2024
3de0863
fix test
nkdengineer May 27, 2024
adf00ab
run prettier
nkdengineer May 27, 2024
474d71f
edit comment
nkdengineer May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/ReportUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5551,7 +5551,7 @@ function getMoneyRequestOptions(report: OnyxEntry<Report>, policy: OnyxEntry<Pol
// DM chats will have the Split Expense option.
// Your own workspace chats will have the split expense option.
if (
(isChatRoom(report) && otherParticipants.length > 0) ||
(isChatRoom(report) && !isAnnounceRoom(report) && otherParticipants.length > 0) ||
(isDM(report) && otherParticipants.length > 0) ||
(isGroupChat(report) && otherParticipants.length > 0) ||
(isPolicyExpenseChat(report) && report?.isOwnPolicyExpenseChat)
Expand Down
7 changes: 1 addition & 6 deletions tests/unit/ReportUtilsTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,12 +465,7 @@ describe('ReportUtils', () => {

describe('return only iou split option if', () => {
it('it is a chat room with more than one participant', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update this description?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@puneetlath I updated.

const onlyHaveSplitOption = [
CONST.REPORT.CHAT_TYPE.POLICY_ADMINS,
CONST.REPORT.CHAT_TYPE.POLICY_ANNOUNCE,
CONST.REPORT.CHAT_TYPE.DOMAIN_ALL,
CONST.REPORT.CHAT_TYPE.POLICY_ROOM,
].every((chatType) => {
const onlyHaveSplitOption = [CONST.REPORT.CHAT_TYPE.POLICY_ADMINS, CONST.REPORT.CHAT_TYPE.DOMAIN_ALL, CONST.REPORT.CHAT_TYPE.POLICY_ROOM].every((chatType) => {
const report = {
...LHNTestUtils.getFakeReport(),
chatType,
Expand Down
Loading