Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track expense lhn #41668

Merged
merged 20 commits into from
May 28, 2024
Merged

Track expense lhn #41668

merged 20 commits into from
May 28, 2024

Conversation

Nodebrute
Copy link
Contributor

@Nodebrute Nodebrute commented May 6, 2024

Details

Fixed Issues

$ #41183
PROPOSAL: #41183 (comment)

Tests

  1. Track an expense
  2. Select any of the actionable whisper options
  3. Confirm that the LHN displays the last visible message instead of 'What would you like to do with this expense?
  • Verify that no errors appear in the JS console

Offline tests

  1. Track an expense
  2. Go offline
  3. Select any of the actionable whisper options
  4. Confirm that the LHN displays the last visible message instead of 'What would you like to do with this expense?

QA Steps

  1. Track an expense
  2. Go offline
  3. Select any of the actionable whisper options
  4. Confirm that the LHN displays the last visible message instead of 'What would you like to do with this expense?
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2024-05-28.at.2.08.34.AM.mov
Android: mWeb Chrome
Screen.Recording.2024-05-28.at.2.14.52.AM.mov
iOS: Native
Screen.Recording.2024-05-27.at.10.58.41.PM.mov
iOS: mWeb Safari
Screen.Recording.2024-05-27.at.11.04.28.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-05-06.at.4.25.24.PM.mov
MacOS: Desktop
Screen.Recording.2024-05-27.at.10.35.54.PM.mov

@Nodebrute Nodebrute requested a review from a team as a code owner May 6, 2024 11:58
@melvin-bot melvin-bot bot requested review from c3024 and removed request for a team May 6, 2024 11:58
Copy link

melvin-bot bot commented May 6, 2024

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Nodebrute
Copy link
Contributor Author

@c3024 We need to address this on the backend too. It works fine in offline mode, but when the open report API is called, the last message text reverts to 'What would you like to do with this expense?

We still have one unhandled case regarding expense deletion. Let's first test this solution, and if everything works fine, we'll decide whether we need to fix that here too.

@c3024
Copy link
Contributor

c3024 commented May 7, 2024

I see it working fine for all but Do nothing because the expense is moved to another report in those cases.

I found the last message showing as What do you want to do with this expense? when I choose Do nothing for an expense. But it should show the last tracked expense.

I see we only use the lastMessageText from report as fallback here

return lastMessageTextFromReport || (report?.lastMessageText ?? '');

and this here
return actionType !== CONST.IOU.REPORT_ACTION_TYPE.CREATE && actionType !== CONST.IOU.REPORT_ACTION_TYPE.TRACK && !isSentMoneyReportAction(action);

is filtering track actions as well and removing the track action in the sorted report actions to display here
sortedReportActions = ReportActionUtils.getCombinedReportActions(allSortedReportActions[reportID], allSortedReportActions[transactionThreadReportID]);

and only CREATED action is left in the actions and the fallback is taken as last message. Since the backend still sends the whispers also as report actions I think we need not change the lastMessage sent from backend. We should fix the above to include the track action in the actions to display.

@c3024
Copy link
Contributor

c3024 commented May 10, 2024

@Nodebrute

Please check this. I don't think it needs a backend fix.

@Nodebrute
Copy link
Contributor Author

@c3024 I'm on it. I'll complete it today.

@Nodebrute
Copy link
Contributor Author

Nodebrute commented May 12, 2024

@c3024 The issue with the 'do nothing' behavior has been resolved after making this change. However, we're still encountering the same message from the backend when the 'open report' API is called

Screen.Recording.2024-05-12.at.7.10.57.PM.mov

@@ -320,7 +320,7 @@ function getCombinedReportActions(reportActions: ReportAction[], transactionThre
// Filter out request and send money request actions because we don't want to show any preview actions for one transaction reports
const filteredReportActions = [...reportActions, ...filteredTransactionThreadReportActions].filter((action) => {
const actionType = (action as OriginalMessageIOU).originalMessage?.type ?? '';
return actionType !== CONST.IOU.REPORT_ACTION_TYPE.CREATE && actionType !== CONST.IOU.REPORT_ACTION_TYPE.TRACK && !isSentMoneyReportAction(action);
return actionType !== CONST.IOU.REPORT_ACTION_TYPE.CREATE && !isSentMoneyReportAction(action);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not remove it directly.

Removing it breaks shows the report action in transaction report.

reportActionInWorkspaceChat.mp4

We should not filter track actions only in self DMs as far as I see. The following snippet fixes our bug and appears to cause no regressions.

Suggested change
return actionType !== CONST.IOU.REPORT_ACTION_TYPE.CREATE && !isSentMoneyReportAction(action);
const report = allReports?.[action?.reportID ?? ''];
const isSelfDM = report?.chatType === CONST.REPORT.CHAT_TYPE.SELF_DM;
if (isSelfDM) {
return actionType !== CONST.IOU.REPORT_ACTION_TYPE.CREATE && !isSentMoneyReportAction(action);
}
return actionType !== CONST.IOU.REPORT_ACTION_TYPE.CREATE && actionType !== CONST.IOU.REPORT_ACTION_TYPE.TRACK && !isSentMoneyReportAction(action);

@c3024
Copy link
Contributor

c3024 commented May 13, 2024

@Nodebrute

please fix the lint and ts failures.

@Nodebrute
Copy link
Contributor Author

@c3024 Hey, could you help me solve this TypeScript error? I've tried but haven't had any luck.

* Checks whether an action is actionable track expense.
*
*/
function isActionableTrackExpense(reportAction: OnyxEntry<ReportAction>): boolean {
Copy link
Contributor

@c3024 c3024 May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function isActionableTrackExpense(reportAction: OnyxEntry<ReportAction>): boolean {
function isActionableTrackExpense(reportAction: OnyxEntry<ReportAction>): reportAction is ReportActionBase & OriginalMessageActionableTrackedExpenseWhisper {

We should retain the type predicate so that TS knows the originalMessage is of track whisper when this returns true.

Comment on lines 322 to 323
const report = allReports?.[action?.reportID ?? ''];
const isSelfDM = report?.chatType === CONST.REPORT.CHAT_TYPE.SELF_DM;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const report = allReports?.[action?.reportID ?? ''];
const isSelfDM = report?.chatType === CONST.REPORT.CHAT_TYPE.SELF_DM;

My bad! There is no reportID on action. Could not catch Copilot's shenanigans. I think we better pass the reportID to getCombinedReportActions in OptionsListUtils and add reportID as an optional parameter for getCombinedReportActions.

@@ -320,6 +319,11 @@ function getCombinedReportActions(reportActions: ReportAction[], transactionThre
// Filter out request and send money request actions because we don't want to show any preview actions for one transaction reports
const filteredReportActions = [...reportActions, ...filteredTransactionThreadReportActions].filter((action) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const filteredReportActions = [...reportActions, ...filteredTransactionThreadReportActions].filter((action) => {
const report = allReports?.[reportID ?? ''];
const isSelfDM = report?.chatType === CONST.REPORT.CHAT_TYPE.SELF_DM;
const filteredReportActions = [...reportActions, ...filteredTransactionThreadReportActions].filter((action) => {

@@ -309,17 +309,22 @@ function shouldIgnoreGap(currentReportAction: ReportAction | undefined, nextRepo
* Returns a sorted and filtered list of report actions from a report and it's associated child
* transaction thread report in order to correctly display reportActions from both reports in the one-transaction report view.
*/
function getCombinedReportActions(reportActions: ReportAction[], transactionThreadReportActions: ReportAction[]): ReportAction[] {
function getCombinedReportActions(reportActions: ReportAction[], transactionThreadReportActions: ReportAction[], reportID: string): ReportAction[] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function getCombinedReportActions(reportActions: ReportAction[], transactionThreadReportActions: ReportAction[], reportID: string): ReportAction[] {
function getCombinedReportActions(reportActions: ReportAction[], transactionThreadReportActions: ReportAction[], reportID?: string): ReportAction[] {

@@ -149,7 +149,7 @@ function ReportActionsView({
// Get a sorted array of reportActions for both the current report and the transaction thread report associated with this report (if there is one)
// so that we display transaction-level and report-level report actions in order in the one-transaction view
const combinedReportActions = useMemo(
() => ReportActionsUtils.getCombinedReportActions(allReportActions, transactionThreadReportActions),
() => ReportActionsUtils.getCombinedReportActions(allReportActions, transactionThreadReportActions,reportID),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
() => ReportActionsUtils.getCombinedReportActions(allReportActions, transactionThreadReportActions,reportID),
() => ReportActionsUtils.getCombinedReportActions(allReportActions, transactionThreadReportActions),

@@ -3041,31 +3057,6 @@ const getConvertTrackedExpenseInformation = (
},
});

// Resolve actionable whisper message
optimisticData?.push({

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as resolved.

@c3024
Copy link
Contributor

c3024 commented May 24, 2024

@Nodebrute there are conflicts as well now.

@Nodebrute
Copy link
Contributor Author

@c3024 I'll priorities this and finish it today.

@Nodebrute
Copy link
Contributor Author

@c3024 Hey, I have resolved the conflicts in my code. I have tested it and it still shows the message when the openReport API is called. Can you help me understand what the next steps are to finish this up? Let's get this issue closed.

@c3024
Copy link
Contributor

c3024 commented May 27, 2024

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
trackExpenseAndroid.mp4
Android: mWeb Chrome
trackExpenseAndroidChrome.mp4
iOS: Native
trackExpenseiOS.mp4
iOS: mWeb Safari
trackExpenseiOSSafari.mp4
MacOS: Chrome / Safari
trackExpenseChrome.mp4
MacOS: Desktop
trackExpenseDesktop.mp4

@c3024
Copy link
Contributor

c3024 commented May 27, 2024

All works well except with a small issue.

Do nothing fails again because this filter

ReportActionUtils.shouldReportActionBeVisible(reportAction, actionKey) &&
!ReportActionUtils.isWhisperAction(reportAction) &&
reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.CREATED &&
reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,

now does not use shouldReportActionBeVisibleAsLastAction where isResolvedActionTrackExpense change is included.

So, we should change this

ReportActionUtils.shouldReportActionBeVisible(reportAction, actionKey) &&
!ReportActionUtils.isWhisperAction(reportAction) &&
reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.CREATED &&
reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,

to

ReportActionUtils.shouldReportActionBeVisible(reportAction, actionKey) &&
                    !ReportActionUtils.isWhisperAction(reportAction) &&
                    reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.CREATED &&
                    reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE &&
                    !ReportActionUtils.isResolvedActionTrackExpense(reportAction),

@c3024
Copy link
Contributor

c3024 commented May 27, 2024

@c3024 Hey, I have resolved the conflicts in my code. I have tested it and it still shows the message when the openReport API is called. Can you help me understand what the next steps are to finish this up? Let's get this issue closed.

Yes, this needs a backend fix separately.

@c3024
Copy link
Contributor

c3024 commented May 27, 2024

@Nodebrute

Please fix this and it is done.

@Nodebrute
Copy link
Contributor Author

Nodebrute commented May 27, 2024

@c3024 Hey, I have added videos for all platforms. I have updated the code and it works well. Thank you for your patience.

Copy link
Contributor

@c3024 c3024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melvin-bot melvin-bot bot requested a review from thienlnam May 28, 2024 09:55
@c3024
Copy link
Contributor

c3024 commented May 28, 2024

@thienlnam there is a backend fix required as well because when all track expenses are submitted/categorized (when all track expense whispers are resolved) there are no valid visible report actions and backend sends last message for the report as "What would you like to do with this expense?" even though all the whispers are resolved and expenses are moved to other reports.

I think backend should not send this as last message text when all the track expense whispers are resolved.

@thienlnam
Copy link
Contributor

Thanks, I'll create an issue to track that internally

@thienlnam
Copy link
Contributor

Is this still a problem? https://github.com/Expensify/App/pull/41668/files#r1600275772

@Nodebrute
Copy link
Contributor Author

@thienlnam No.

cc @c3024

Copy link
Contributor

@thienlnam thienlnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@thienlnam thienlnam merged commit 1c1e88a into Expensify:main May 28, 2024
18 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.77-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Nodebrute Nodebrute deleted the trackExpenseLHN branch September 16, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants