Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Android - Distance - Waypoint does not change position correctly by dragging. #41378

Merged
merged 12 commits into from
May 28, 2024
Merged

fix: Android - Distance - Waypoint does not change position correctly by dragging. #41378

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7183083
fix: Android - Distance - Waypoint does not change position correctly…
Krishna2323 May 1, 2024
15d52e2
Merge branch 'Expensify:main' into krishna2323/issue/40105
Krishna2323 May 8, 2024
e1c6d5f
Merge branch 'Expensify:main' into krishna2323/issue/40105
Krishna2323 May 14, 2024
bbe32c4
add unique keys for waypoints.
Krishna2323 May 14, 2024
e76180b
add keyForList when address is selected.
Krishna2323 May 18, 2024
111476d
use Date.now() for keyForList.
Krishna2323 May 18, 2024
8124981
Merge branch 'Expensify:main' into krishna2323/issue/40105
Krishna2323 May 24, 2024
800c12e
remove redundant code.
Krishna2323 May 24, 2024
56f13d8
minor update.
Krishna2323 May 24, 2024
a74c13d
minor update.
Krishna2323 May 24, 2024
14f864f
minor fixes.
Krishna2323 May 27, 2024
257d956
Merge branch 'Expensify:main' into krishna2323/issue/40105
Krishna2323 May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/iou/request/step/IOURequestStepDistance.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ function IOURequestStepDistance({
<View style={styles.flex1}>
<DraggableList
data={waypointsList}
keyExtractor={(item) => item}
keyExtractor={(item) => (waypoints[item]?.address ?? '') + item || item}
Copy link
Contributor

@ishpaul777 ishpaul777 May 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about the case when the address is same for 2 location?

VIDEO-2024-05-03-17-48-20.mp4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for delay, will look at this today.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishpaul777, I added keyForList for each waypoint when they are added and it works perfectly, should we do that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please push change so i can evaluate ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gentle bump @Krishna2323

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will push changes in few hours, sorry for delay again, I missed you previous comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishpaul777, you can retest the changes now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll test this within few hours

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishpaul777, friendly bump.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing now 👀

shouldUsePortal
onDragEnd={updateWaypoints}
ref={scrollViewRef}
Expand Down
Loading