Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the OpenApp has finished or not before updating Onyx data #39979

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Check if the OpenApp has finished or not before updating Onyx data #39979

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
374406d
fix: check if the OpenApp has finished or not before updating Onyx data
Apr 9, 2024
ccbbe13
fix: use false when the value is null
Apr 9, 2024
6392d49
fix: remove null from the type declaration
Apr 10, 2024
fe9f6b2
chore: add log statement
Apr 10, 2024
ac9b108
fix: condition to log the info
Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/libs/actions/OnyxUpdateManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,22 @@ Onyx.connect({
callback: (value) => (lastUpdateIDAppliedToClient = value),
});

let isLoadingApp = false;
Onyx.connect({
key: ONYXKEYS.IS_LOADING_APP,
callback: (value) => {
isLoadingApp = value ?? false;
},
});

export default () => {
console.debug('[OnyxUpdateManager] Listening for updates from the server');
Onyx.connect({
key: ONYXKEYS.ONYX_UPDATES_FROM_SERVER,
callback: (value) => {
if (!value) {
// When the OpenApp command hasn't finished yet, we should not process any updates.
if (!value || isLoadingApp) {
console.debug(`[OnyxUpdateManager] Ignoring Onyx updates while OpenApp hans't finished yet.`);
return;
}
// This key is shared across clients, thus every client/tab will have a copy and try to execute this method.
Expand Down
Loading