-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Reddot pinned chat appears for approver after failed scanned #39970
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
69263a4
fix Reddot pinned chat appears for approver for submitter's failed sc…
dukenv0307 fe5f752
fix lint
dukenv0307 1303c69
fix update hasMissingSmartscanFields
dukenv0307 f082a5a
fix update hasSmartscanError
dukenv0307 ec854c5
fix merge main
dukenv0307 48ad489
fix type
dukenv0307 590547f
fix type
dukenv0307 1be1d08
fix add comment
dukenv0307 de0ae91
Merge branch 'main' into fix/37044
dukenv0307 4d03c16
fix update comment
dukenv0307 4560da2
fix create shouldShowRBRForMissingSmartscanFields
dukenv0307 3fbf0f7
fix lint
dukenv0307 8866eb7
fix create hasMissingFields variable
dukenv0307 83500fc
fix merge main
dukenv0307 97ce514
fix suggestion logics
dukenv0307 4c35a47
fix create isRequestor
dukenv0307 0c68919
fix merge main
dukenv0307 6e342bc
Merge branch 'main' into fix/37044
dukenv0307 4ef770d
fix remove isLHNPreview and create actionWasTakenByCurrentUser
dukenv0307 728ae68
fix typecheck
dukenv0307 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
fix create isRequestor
- Loading branch information
commit 4c35a470baf64859d0e3954e22f8b511df5b6ccb
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I kinda missed this in the proposal and original review, but I was thinking about reports when thinking about
isRequestor
, but for report actions, this name isn't great.How about we call this something like
ReportActionUtils.actionWasTakenByCurrentUser(reportAction)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed it in commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, let me know when this is ready for re-review. Thanks