fix: Standardize the hover menu options to always include the same options #39894

nkdengineer · 2024-04-09T04:20:36Z

Details

Fixed Issues

$ #39068
PROPOSAL: #39068 (comment)

Tests

Open a report
Move the mouse to each report action
Verify that: the hover menu options to always include the same options

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open a report
Move the mouse to each report action
Verify that: the hover menu options to always include the same options

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…tions

melvin-bot · 2024-04-09T04:29:17Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2024-04-09T14:52:26Z

src/pages/home/report/ContextMenu/ContextMenuActions.tsx

-            }
-        },
-        getDescription: () => {},
-    },
    {


Please move this up too.

Sorry, what do you mean?

Move mark as read up before edit action.

shubham1206agra · 2024-04-11T06:00:46Z

@nkdengineer Sorry, but can you move common.download down too?

nkdengineer · 2024-04-12T03:11:35Z

@shubham1206agra I moved the "download" option to the bottom:

Screen.Recording.2024-04-12.at.10.10.24.mov

shubham1206agra · 2024-04-12T03:58:33Z

Tagging @Expensify/design here as they know the correct order for actions inside the 3-dot menu.

dubielzyk-expensify · 2024-04-12T04:10:12Z

My take on the example above's order from top to bottom:

Copy link
Download
Delete commment

I think the deletion should always be the last option. I'll let @shawnborton and @dannymcclain chime in though

shawnborton · 2024-04-12T07:22:06Z

Yup I like that, and I like the idea that delete is always the last option.

shubham1206agra · 2024-04-12T08:03:44Z

@nkdengineer Please fix the order.
Thanks.

nkdengineer · 2024-04-15T09:22:33Z

@shubham1206agra I moved the "Remove" option to the bottom

nkdengineer · 2024-04-22T02:20:28Z

@shubham1206agra Any update here.

shubham1206agra · 2024-04-22T03:46:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-04-22.at.9.11.25.AM.mov

MacOS: Desktop

Screen.Recording.2024-04-22.at.9.13.25.AM.mov

dubielzyk-expensify · 2024-04-22T03:58:38Z

Just for prosperity, can you show me a recording with an attachment so we can see the "Download" option too?

shubham1206agra · 2024-04-22T04:25:23Z

src/pages/home/report/ContextMenu/ContextMenuActions.tsx

@@ -499,6 +476,55 @@ const ContextMenuActions: ContextMenuAction[] = [
        },
        getDescription: () => {},
    },
+    {
+        isAnonymousAction: true,


@nkdengineer You forgot to remove this option from above. Now it got duplicated.

shubham1206agra

Please fix duplicated download option.

shubham1206agra · 2024-04-22T12:30:07Z

Screen.Recording.2024-04-22.at.5.59.10.PM.mov

@dubielzyk-expensify For your reference.

dubielzyk-expensify

This looks good from a design perspective. I'll leave it to others for the code 😄

OSBotify · 2024-04-23T14:59:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-24T00:06:53Z

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.4.65-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-25T13:45:12Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: Standardize the hover menu options to always include the same op…

1d40295

…tions

nkdengineer marked this pull request as ready for review April 9, 2024 04:29

nkdengineer requested a review from a team as a code owner April 9, 2024 04:29

melvin-bot bot requested review from shubham1206agra and removed request for a team April 9, 2024 04:29

shubham1206agra reviewed Apr 9, 2024

View reviewed changes

fix move mark as read

d6735f2

fix move download option down

8702354

nkdengineer added 2 commits April 15, 2024 16:01

fix merge main

8c9eb6e

fix move delete option to bottom

32c87ec

resolve conflict

c1c6c94

shubham1206agra approved these changes Apr 22, 2024

View reviewed changes

melvin-bot bot requested a review from tylerkaraszewski April 22, 2024 03:46

dubielzyk-expensify self-requested a review April 22, 2024 03:57

shubham1206agra reviewed Apr 22, 2024

View reviewed changes

shubham1206agra suggested changes Apr 22, 2024

View reviewed changes

nkdengineer added 3 commits April 22, 2024 11:44

fix merge main

af867f2

fix merge main

d7b0e1c

fix remove duplicate download option

2d88758

shubham1206agra approved these changes Apr 22, 2024

View reviewed changes

dubielzyk-expensify approved these changes Apr 22, 2024

View reviewed changes

tylerkaraszewski approved these changes Apr 23, 2024

View reviewed changes

tylerkaraszewski merged commit 0701442 into Expensify:main Apr 23, 2024
17 checks passed

github-actions bot mentioned this pull request Apr 23, 2024

Deploy Checklist: New Expensify 2024-04-23 #40843

Closed

74 tasks

melvin-bot bot mentioned this pull request Apr 25, 2024

[HOLD for payment 2024-05-02] [$500] FEATURE REQUEST: Standardize the hover menu options to always include the same options #39068

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Standardize the hover menu options to always include the same options #39894

fix: Standardize the hover menu options to always include the same options #39894

nkdengineer commented Apr 9, 2024 •

edited

Loading

melvin-bot bot commented Apr 9, 2024

shubham1206agra Apr 9, 2024

nkdengineer Apr 10, 2024

shubham1206agra Apr 10, 2024

nkdengineer Apr 10, 2024

shubham1206agra commented Apr 11, 2024

nkdengineer commented Apr 12, 2024

shubham1206agra commented Apr 12, 2024

dubielzyk-expensify commented Apr 12, 2024

shawnborton commented Apr 12, 2024

shubham1206agra commented Apr 12, 2024

nkdengineer commented Apr 15, 2024

nkdengineer commented Apr 22, 2024

shubham1206agra commented Apr 22, 2024

dubielzyk-expensify commented Apr 22, 2024

shubham1206agra Apr 22, 2024

shubham1206agra left a comment

shubham1206agra commented Apr 22, 2024

dubielzyk-expensify left a comment

OSBotify commented Apr 23, 2024

OSBotify commented Apr 24, 2024

OSBotify commented Apr 25, 2024

fix: Standardize the hover menu options to always include the same options #39894

fix: Standardize the hover menu options to always include the same options #39894

Conversation

nkdengineer commented Apr 9, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 9, 2024

shubham1206agra Apr 9, 2024

Choose a reason for hiding this comment

nkdengineer Apr 10, 2024

Choose a reason for hiding this comment

shubham1206agra Apr 10, 2024

Choose a reason for hiding this comment

nkdengineer Apr 10, 2024

Choose a reason for hiding this comment

shubham1206agra commented Apr 11, 2024

nkdengineer commented Apr 12, 2024

shubham1206agra commented Apr 12, 2024

dubielzyk-expensify commented Apr 12, 2024

shawnborton commented Apr 12, 2024

shubham1206agra commented Apr 12, 2024

nkdengineer commented Apr 15, 2024

nkdengineer commented Apr 22, 2024

shubham1206agra commented Apr 22, 2024

Reviewer Checklist

Screenshots/Videos

dubielzyk-expensify commented Apr 22, 2024

shubham1206agra Apr 22, 2024

Choose a reason for hiding this comment

shubham1206agra left a comment

Choose a reason for hiding this comment

shubham1206agra commented Apr 22, 2024

dubielzyk-expensify left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 23, 2024

OSBotify commented Apr 24, 2024

OSBotify commented Apr 25, 2024

nkdengineer commented Apr 9, 2024 •

edited

Loading