Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hmmm log level to onyx #39076

Merged
merged 1 commit into from
May 1, 2024
+2 −0
Merged

feat: add hmmm log level to onyx #39076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Expensify.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ Onyx.registerLogger(({level, message}) => {
if (level === 'alert') {
Log.alert(message);
console.error(message);
} else if (level === 'hmmm') {
Log.hmmm(message);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can get this part merged now - it will start working once the version is bumped. Can you remove the package.json stuff?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcaaron I reverted but now it throws expected TS compilation problem, because level definition comes from onyx and current version from main doesn't have a new type hmmm yet 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see. Then let's update the type and then we can hold this one some more.

This PR is not too critical since the default is to do an info instead of hmm so we can just fix the types then come back and bump this one again.

} else {
Log.info(message);
}
Expand Down
Loading