Feat/track whispers #38709

ishpaul777 · 2024-03-20T21:04:11Z

Details

Fixed Issues

$ #38533
PROPOSAL:

Tests

Verify that no errors appear in the JS console
Same as QA

Offline tests

QA Steps

Verify that no errors appear in the JS console

Click on track expense from FAB and create some tracked expenses. (Manual/Scan/Distance) and follow below steps for every tracked expense.
Verify a actionable whisper shows for every tracked expense.
Click on Nothing for now in actionable whisper, verify the whisper dismisses and hides.
Click on Request someone to pay in another actionable whisper for different tracked expense, verify you are redirected participants selector (P2P only, workspace chat will not be visible) and able to complete the request flow. (request field prefilled with existing tracked transaction)
Click on Categorize it in another actionable whisper for different tracked expense, verify you are redirected participants selector (only workspaces visible) and able to complete the request flow. (flow: workspace selector -> category selector -> confirmation page)
Click on "Share it with accountant" in another actionable whisper for different tracked expense, verify you are redirected participants selector (only workspaces visible) and able to complete the request flow. (flow: workspace selector -> confirmation page -> request made-> invte page to invite a member (accountant))

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

shubham1206agra · 2024-04-16T13:01:42Z

This should not happen ig.

shubham1206agra · 2024-04-16T16:17:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2024-04-16T17:37:51Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/38709/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/38709/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/38709/NewExpensify.dmg	https://38709.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2024-04-16T17:55:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

tgolen · 2024-04-17T16:07:29Z

src/CONST.ts

@@ -1429,6 +1436,7 @@ const CONST = {
            DELETE: 'delete',
            APPROVE: 'approve',
            TRACK: 'track',
+            MOVE: 'move',


Why was this constant added? I can't find it referenced anywhere so I am thinking of removing it in this PR.

Yes this can be removed, Sorry I didn't remember to remove it when i no longer need it : (

OK, thank you! I'll move forward with removing it.

OSBotify · 2024-04-18T04:54:56Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

shubham1206agra · 2024-04-21T16:03:43Z

src/components/MoneyTemporaryForRefactorRequestConfirmationList.tsx

@@ -978,9 +939,9 @@ function MoneyTemporaryForRefactorRequestConfirmationList({
                    <ConfirmedRoute transaction={transaction ?? ({} as OnyxTypes.Transaction)} />
                </View>
            )}
-            {
+            {(!isMovingTransactionFromTrackExpense || !hasRoute) &&


Just use !isDistanceRequest here instead.

OSBotify · 2024-04-22T14:55:55Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jjcoffee · 2024-05-06T08:41:26Z

src/libs/actions/IOU.ts

+        }
+    }
+    if (action === CONST.IOU.ACTION.SHARE) {
+        Navigation.navigate(ROUTES.ROOM_INVITE.getRoute(activeReportID ?? '', CONST.IOU.SHARE.ROLE.ACCOUNTANT));


Coming from #40490. We needed to close all RHP first before navigating to the invite page (more details here). This stops a confusing UX where you can go back to the confirmation page but not proceed again (because the form is already submitted).

rojiphil · 2024-06-12T07:11:54Z

src/libs/actions/IOU.ts

+                waypoints: validWaypoints ? JSON.stringify(validWaypoints) : undefined,
+            };
+
+            API.write(WRITE_COMMANDS.TRACK_EXPENSE, parameters, onyxData);


Coming from #40664, we missed adding an optimistic actionable whisper while creating track expense for self-DM.

rojiphil · 2024-07-19T06:40:44Z

src/libs/actions/IOU.ts

-        transactionID,
-        reportActionID: reportAction.reportActionID,
-    };
+    const {parameters, optimisticData, successData, failureData, shouldDeleteTransactionThread} = getDeleteTrackExpenseInformation(chatReportID, transactionID, reportAction);


When we introduced track expense whisper, we missed handling the whisper when the track expense gets deleted thereby resulting in #43560

ntdiary · 2024-11-12T04:09:27Z

src/libs/ReportUtils.ts

+        linkedTrackedExpenseReportID: reportID,
+        amount: transactionAmount,
+        created: transactionCreated,
+    } as Transaction);


Coming from #51030.
We need to reset some modifiedXXX fields, they should not exist in a new draft transaction. Otherwise, if the user edits these fields again before submitting the draft, the new values can't display correctly :)

App/src/libs/ReportUtils.ts

Lines 8183 to 8190 in 64cb4ee

modifiedCreated: undefined,

modifiedAmount: undefined,

modifiedCurrency: undefined,

amount,

currency,

comment,

merchant,

modifiedMerchant: '',

thienlnam and others added 30 commits March 21, 2024 00:12

Basic handling for new ACTIONABLETRACKEXPENSEWHISPER

ce8e379

Show buttons

cb398c2

adds a draft transaction while moving a tracked to request someone

bb4483f

Merge branch 'main' into feat/track-whispers

3cf05a6

Merge branch 'Expensify:main' into feat/track-whispers

403765b

adds route param for move iou action

5461f4c

Merge branch 'Expensify:main' into feat/track-whispers

53b3160

Merge branch 'Expensify:main' into feat/track-whispers

8f22cc8

fixes routes

0099a39

adds dismiss actionable whisper

a3dc485

fixes type error and run prettier

7573852

fixes more type errors

cabc1e7

fixes lint

161c67e

prettier diffs

9482163

scroll down when whisper is resolved

113d7b4

exclude workspace chat from the participant list

4c3bd1a

adds api command for request someone whisper

816a190

Merge branch 'Expensify:main' into feat/track-whispers

9bed62e

adds basic handling for categorize tracked exp.

0420ab5

fixes type errors

deb3d6b

fix navigation from confirmation page to catgory page

0d4a429

run prettier

f860fa0

Merge branch 'Expensify:main' into feat/track-whispers

98e97ae

polish categorize flow

a460367

remove unused code

302b536

fix header title for whisper actions

2ba1c65

Merge branch 'Expensify:main' into feat/track-whispers

127a53c

adds categorize api call

65544d2

fix money request reportid

60eed83

fixes blocking vie conditional

a20ab3b

ishpaul777 added 2 commits April 16, 2024 20:40

fixes category not showing

3064d3a

disable threads for whisper message and use correct translations

c5e794b

AndrewGable added the Ready To Build label Apr 16, 2024

This was referenced Apr 16, 2024

CRITICAL: [Actionable Whispers] Changes when categorizing / sharing a tracked expense are not saved #40304

Closed

CRITICAL: [Actionable Whispers] Changes Error converting tracked expense to a user with an existing IOU #40305

Closed

thienlnam approved these changes Apr 16, 2024

View reviewed changes

thienlnam merged commit c416b1a into Expensify:main Apr 16, 2024
15 of 47 checks passed

thienlnam mentioned this pull request Apr 16, 2024

CRITICAL: [Actionable Whispers] [$250] All actionable whisper actions are resolved with 'None' #40306

Closed

6 tasks

thienlnam mentioned this pull request Apr 16, 2024

CRITICAL: [Actionable Whispers] [$250] Not found page on selecting categories from actionable whisper #40308

Closed

6 tasks

tgolen reviewed Apr 17, 2024

View reviewed changes

ishpaul777 mentioned this pull request Apr 17, 2024

Fix/pdf not showing for money request #40385

Merged

50 tasks

github-actions bot mentioned this pull request Apr 18, 2024

Deploy Checklist: New Expensify 2024-04-18 #40392

Closed

lanitochka17 mentioned this pull request Apr 18, 2024

CRITICAL: [Actionable Whispers] Track scan expense is duplicated when it is submitted to someone #40485

Closed

6 tasks

kbecciv mentioned this pull request Apr 18, 2024

[HOLD for payment 2024-05-02] CRITICAL: [Actionable Whispers] [$500] Unable to return to invite page after returning to confirmation page #40490

Closed

6 tasks

allgandalf mentioned this pull request Apr 18, 2024

[TS migration] Migrate MoneyTemporaryForRefactorRequestConfirmationList.js component to TypeScript #37181

Merged

50 tasks

izarutskaya mentioned this pull request Apr 19, 2024

Track expense - Categorize it - Email result shows up and it leads to not here page #40549

Closed

6 tasks

shubham1206agra reviewed Apr 21, 2024

View reviewed changes

jjcoffee reviewed May 6, 2024

View reviewed changes

rojiphil reviewed Jun 12, 2024

View reviewed changes

rojiphil mentioned this pull request Jun 12, 2024

[HOLD for payment 2024-06-11] CRITICAL: [Track Expense] [$250] Self DM doesn't scroll down when tracking new expense #40664

Closed

rojiphil reviewed Jul 19, 2024

View reviewed changes

rojiphil mentioned this pull request Jul 19, 2024

[HOLD for payment 2024-07-17] [$250] Actionable whisper - Whisper options are interactable when the expense is deleted offline #43560

Closed

6 tasks

ntdiary reviewed Nov 12, 2024

View reviewed changes

bernhardoj mentioned this pull request Nov 28, 2024

[$250] Search-Invoice with +2 expense submitted in OD is displayed with a negative total amount in ND #53045

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/track whispers #38709

Feat/track whispers #38709

ishpaul777 commented Mar 20, 2024 •

edited

Loading

shubham1206agra commented Apr 16, 2024

shubham1206agra commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

OSBotify commented Apr 16, 2024

tgolen Apr 17, 2024

ishpaul777 Apr 17, 2024

tgolen Apr 18, 2024

OSBotify commented Apr 18, 2024

shubham1206agra Apr 21, 2024

OSBotify commented Apr 22, 2024

jjcoffee May 6, 2024

rojiphil Jun 12, 2024

rojiphil Jul 19, 2024

ntdiary Nov 12, 2024

	modifiedCreated: undefined,
	modifiedAmount: undefined,
	modifiedCurrency: undefined,
	amount,
	currency,
	comment,
	merchant,
	modifiedMerchant: '',

Feat/track whispers #38709

Feat/track whispers #38709

Conversation

ishpaul777 commented Mar 20, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

shubham1206agra commented Apr 16, 2024

shubham1206agra commented Apr 16, 2024

Reviewer Checklist

Screenshots/Videos

github-actions bot commented Apr 16, 2024

OSBotify commented Apr 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented Apr 18, 2024

Choose a reason for hiding this comment

OSBotify commented Apr 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ishpaul777 commented Mar 20, 2024 •

edited

Loading