Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Quick Action Button #38669
Display Quick Action Button #38669
Changes from all commits
d98eacd
a38a1b2
9ae46bb
3bc4a5a
d724d36
0d5489e
583a397
9913831
f2c30a9
cf56da1
bee853a
95724b0
c95240c
7dd132d
56f0aaf
2eb7a4d
62fc68f
e438fdb
5bb163b
d76ce0f
bc00787
98e8385
e95214a
a8419b2
b73e154
184668e
dc736de
33735ca
37cd485
8201e4c
9428a61
844c4b8
1bfe96d
5f5356b
9da221a
4db50be
e557a48
c17cba6
d89fa9a
df90dc3
b4a221f
a31cc59
25db0ee
1bea6a6
5b85cfb
1f5f213
8137d9f
ab8d07f
6760426
fe56250
399d95b
be686d3
f08a249
6b4a73e
97c8d0e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid crashes (even if we've missed some action type), we should have added some default fallback key here instead of an empty string. This caused #38972
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see where we are using the
isFirstQuickAction
, am I missing something?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll be using that to determine if we show an educational tooltip about the quick action: #38054
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Not in use yet, but it'll come with the follow-up PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line created a bug where the icon and group name is not updated correctly. More details here #40536
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were missing
policy
in the dependencies here, which caused #39045 where the avatar was not kept in sync if the workspace's avatar changed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the hook for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, my bad. This is fine. I thought that this is current user's details which has a hook.