Only bold user display name when it's unread in search page #37306

bernhardoj · 2024-02-27T14:42:04Z

Details

We want to bold user display name in search page when it's unread.

Fixed Issues

$ #36075
PROPOSAL: #36075 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open search page
Verify the user display name is bold when you have unread chats
Search for a new user
Verify the user display name is bold

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-27.at.22.32.47.mov

Android: mWeb Chrome

Screen.Recording.2024-02-27.at.22.33.53.mov

iOS: Native

Screen.Recording.2024-02-27.at.22.31.48.mov

iOS: mWeb Safari

Screen.Recording.2024-02-27.at.22.27.01.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-27.at.22.20.14.mov

MacOS: Desktop

Screen.Recording.2024-02-27.at.22.22.06.mov

melvin-bot · 2024-02-27T14:42:09Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2024-02-27T15:22:54Z

Nice! And just to confirm, when you go to create a new chat from the global create menu, the names always appear in bold because it is a list of contacts and not chats, right?

bernhardoj · 2024-02-27T15:24:39Z

Yes, the name is always in bold in new chat page

abdulrahuman5196 · 2024-02-28T18:51:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-29.at.12.09.10.AM.mp4

Android: mWeb Chrome

Screen.Recording.2024-02-29.at.12.16.10.AM.mp4

iOS: Native

Screen.Recording.2024-02-29.at.12.03.01.AM.mp4

iOS: mWeb Safari

Screen.Recording.2024-02-29.at.12.07.24.AM.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-02-28.at.11.54.09.PM.mp4

MacOS: Desktop

Screen.Recording.2024-02-28.at.11.59.02.PM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @neil-marcellini

🎀 👀 🎀
C+ Reviewed

abdulrahuman5196 · 2024-03-01T17:53:38Z

Gentle Ping @neil-marcellini

neil-marcellini

Great thanks

neil-marcellini · 2024-03-01T21:56:57Z

src/components/SelectionList/UserListItem.tsx

@@ -86,7 +86,7 @@ function UserListItem({
                            textStyles={[
                                styles.optionDisplayName,
                                isFocused ? styles.sidebarLinkActiveText : styles.sidebarLinkText,
-                                styles.sidebarLinkTextBold,
+                                item.isBold !== false && styles.sidebarLinkTextBold,


NAB: Why do we need !== false if it's a boolean?

Can we fix that with a default prop maybe?

It could be undefined. item is an object, I'm not sure if we can set a default value for an object attribute.

neil-marcellini · 2024-03-01T21:57:33Z

src/components/SelectionList/types.ts

@@ -55,6 +55,9 @@ type ListItem = {
    /** Whether this option is disabled for selection */
    isDisabled?: boolean;

+    /** List title is bold by default. Use this props to customize it */


NAB: Use this props to customize it => Use this prop to customize it

neil-marcellini · 2024-03-01T22:01:57Z

@bernhardoj to keep things moving I'll merge this. If you want to fix the NAB comments please create a follow up PR.

OSBotify · 2024-03-01T22:06:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-04T21:04:26Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.4.47-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-06T21:53:28Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.47-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

s77rt · 2024-08-21T17:17:38Z

src/pages/SearchPage/index.js

@@ -93,7 +94,7 @@ function SearchPage({betas, reports, isSearchingForReports}) {

        if (recentReports.length > 0) {
            newSections.push({
-                data: recentReports,
+                data: _.map(recentReports, (report) => ({...report, isBold: report.isUnread})),


This caused inconsistency with LHN where the bold style was applied based on other factors too (the notification preference of the report)

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Line 67 in 2093642

const textUnreadStyle = optionItem?.isUnread && optionItem.notificationPreference !== CONST.REPORT.NOTIFICATION_PREFERENCE.MUTE ? [textStyle, styles.sidebarLinkTextBold] : [textStyle];

only bold user display name when it's unread

707f913

bernhardoj requested a review from a team as a code owner February 27, 2024 14:42

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team February 27, 2024 14:42

use underscore map

2093642

abdulrahuman5196 approved these changes Feb 28, 2024

View reviewed changes

melvin-bot bot requested a review from neil-marcellini February 28, 2024 18:55

neil-marcellini approved these changes Mar 1, 2024

View reviewed changes

neil-marcellini merged commit ea2bda2 into Expensify:main Mar 1, 2024
17 checks passed

github-actions bot mentioned this pull request Mar 4, 2024

Deploy Checklist: New Expensify 2024-03-04 #37698

Closed

97 tasks

melvin-bot bot mentioned this pull request Mar 6, 2024

[HOLD for payment 2024-03-13] [$500] Search - Display names are bold regardless of unread state #36075

Closed

6 tasks

s77rt reviewed Aug 21, 2024

View reviewed changes

s77rt mentioned this pull request Aug 21, 2024

[HOLD for payment 2024-08-23] [$500] Some chats are showing as bold (unread) in the chat search, but showing as non-bold (read) in the LHN #46423

Closed

6 tasks

bernhardoj mentioned this pull request Aug 31, 2024

[PAY 15th SEP][$250] Member names in member selection views are not bold or using correct text color and styles #48364

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only bold user display name when it's unread in search page #37306

Only bold user display name when it's unread in search page #37306

bernhardoj commented Feb 27, 2024

melvin-bot bot commented Feb 27, 2024

shawnborton commented Feb 27, 2024

bernhardoj commented Feb 27, 2024

abdulrahuman5196 commented Feb 28, 2024 •

edited

Loading

abdulrahuman5196 left a comment

abdulrahuman5196 commented Mar 1, 2024

neil-marcellini left a comment

neil-marcellini Mar 1, 2024

neil-marcellini Mar 1, 2024

bernhardoj Mar 2, 2024

neil-marcellini Mar 1, 2024

neil-marcellini commented Mar 1, 2024

OSBotify commented Mar 1, 2024

OSBotify commented Mar 4, 2024

OSBotify commented Mar 6, 2024

s77rt Aug 21, 2024

Only bold user display name when it's unread in search page #37306

Only bold user display name when it's unread in search page #37306

Conversation

bernhardoj commented Feb 27, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 27, 2024

shawnborton commented Feb 27, 2024

bernhardoj commented Feb 27, 2024

abdulrahuman5196 commented Feb 28, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

abdulrahuman5196 commented Mar 1, 2024

neil-marcellini left a comment

Choose a reason for hiding this comment

neil-marcellini Mar 1, 2024

Choose a reason for hiding this comment

neil-marcellini Mar 1, 2024

Choose a reason for hiding this comment

bernhardoj Mar 2, 2024

Choose a reason for hiding this comment

neil-marcellini Mar 1, 2024

Choose a reason for hiding this comment

neil-marcellini commented Mar 1, 2024

OSBotify commented Mar 1, 2024

OSBotify commented Mar 4, 2024

OSBotify commented Mar 6, 2024

s77rt Aug 21, 2024

Choose a reason for hiding this comment

abdulrahuman5196 commented Feb 28, 2024 •

edited

Loading