[TS migration] Migrate 'ReimbursementAccount' page to TypeScript #37214

kubabutkiewicz · 2024-02-26T16:38:06Z

Details

Fixed Issues

$ #25227

Tests

Login to app
Go to Settings -> Wallet
Enable bank account, and go through whole flow
Go to Settings
Select workspaces
Select free workspace
Go to Reimbursements page
Verify that Reimbursements page is working as expected

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login to app
Go to Settings -> Wallet
Enable bank account, and go through whole flow
Go to Settings
Select workspaces
Select free workspace
Go to Reimbursements page
Verify that Reimbursements page is working as expected

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web3.mp4

MacOS: Desktop

…g on IdentityForm migration

…s-migration/ReimbursementAccount/page

melvin-bot · 2024-02-26T16:38:11Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

…s-migration/ReimbursementAccount/page

src/types/onyx/ReimbursementAccount.ts

src/pages/workspace/WorkspaceResetBankAccountModal.tsx

src/pages/ReimbursementAccount/ContinueBankAccountSetup.tsx

src/pages/ReimbursementAccount/BankInfo/BankInfo.tsx

src/pages/ReimbursementAccount/ReimbursementAccountPage.tsx

src/pages/workspace/withPolicy.tsx

src/pages/ReimbursementAccount/ContinueBankAccountSetup.tsx

src/pages/ReimbursementAccount/ReimbursementAccountPage.tsx

src/types/onyx/ReimbursementAccount.ts

src/components/Form/InputWrapper.tsx

src/pages/ReimbursementAccount/AddressForm.tsx

src/pages/ReimbursementAccount/CompanyStep.tsx

src/pages/ReimbursementAccount/ContinueBankAccountSetup.tsx

src/pages/ReimbursementAccount/ReimbursementAccountPage.tsx

fabioh8010 · 2024-03-11T16:32:18Z

@kubabutkiewicz Any updates here?

kubabutkiewicz · 2024-03-11T19:31:27Z

@fabioh8010 this is on hold till #36495 this will be merged based on the conversation from here https://callstack-hq.slack.com/archives/C05P72RDZD2/p1709283763867649

DylanDylann · 2024-04-05T08:18:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-09.at.22.32.01.mov

Android: mWeb Chrome

Screen.Recording.2024-04-09.at.22.32.17.mov

iOS: Native

Screen.Recording.2024-04-09.at.22.28.58.mov

iOS: mWeb Safari

Screen.Recording.2024-04-09.at.22.26.28.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-09.at.22.16.45.mov

MacOS: Desktop

Screen.Recording.2024-04-09.at.22.25.18.mov

…s-migration/ReimbursementAccount/page

kubabutkiewicz · 2024-04-05T09:55:23Z

@DylanDylann answered/ resolved comments and conflicts

DylanDylann · 2024-04-05T10:28:37Z

@kubabutkiewicz Please remove the definition of RenamedInputKeysProps because we don't use this type anymore

melvin-bot · 2024-04-05T10:29:15Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #25227 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

rlinoz · 2024-04-05T12:54:04Z

@kubabutkiewicz can you add some test steps, please?

rlinoz

Looks good, just one small question

rlinoz · 2024-04-05T13:08:51Z

src/components/AddressSearch/types.ts

@@ -79,7 +80,7 @@ type AddressSearchProps = {
    predefinedPlaces?: Place[] | null;

    /** A map of inputID key names */
-    renamedInputKeys?: RenamedInputKeysProps;
+    renamedInputKeys?: Address;


Is there a reason to replace the type here?

I find a little confusing to sometimes use the Address type as an address and sometimes as this key map.

the reason for replacing that it turned out that both types are the same so there is no reason to keep them both

kubabutkiewicz · 2024-04-05T14:36:59Z

@rlinoz Tests are added

…s-migration/ReimbursementAccount/page

DylanDylann · 2024-04-08T07:54:43Z

@kubabutkiewicz To go Reimbursements page, we need to connect the bank account first. Currently, I can't connect bank account successfully as I asked here

rlinoz · 2024-04-08T12:23:25Z

It seems to be working fine for me, but @kubabutkiewicz can you add a step to add a bank account in the testing steps?

Also, just want to be sure that it is working well for @DylanDylann

…s-migration/ReimbursementAccount/page

kubabutkiewicz · 2024-04-09T08:34:25Z

@DylanDylann @rlinoz Test steps are added

rlinoz · 2024-04-09T13:43:23Z

@DylanDylann were you able to add the bank account?

DylanDylann · 2024-04-09T15:19:46Z

@rlinoz I am updating. Everything will be done soon

DylanDylann · 2024-04-09T15:34:22Z

@rlinoz Updated. All yours

OSBotify · 2024-04-10T17:45:21Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-04-10T17:54:14Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-04-10T19:33:27Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-18T04:31:12Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.62-17 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kubabutkiewicz added 10 commits February 23, 2024 10:52

ref: migrate AddressForm to TS

8fb16bc

ref: move WorkspaceResetBanAccountModal to TS, fixes for AddressForm

06d3b9a

ref: move RequestorStep to TS

9f40e79

ref: remove RequestorOnfidoStep because its not used anywhere

3125cbe

ref: move ReimbursementAccount page and did few adjustments

08a5d4e

ref: move ACHContractStep to TS

8c18188

ref: move BankAccountStep to TS

1ca6fb0

ref: move CompanyStep to TS

ceb9fab

ref: move ContinueBankAccountStep, ExampleCheck to TS, started workin…

646a2e5

…g on IdentityForm migration

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

d13da54

…s-migration/ReimbursementAccount/page

kubabutkiewicz added 9 commits February 27, 2024 08:55

fix: typecheck

67f3da4

fix: typecheck

093fe8f

fix: small adjustment

ee1949b

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

3907ee7

…s-migration/ReimbursementAccount/page

fix: lint

a3dbead

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

2a416fd

…s-migration/ReimbursementAccount/page

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

997c4ed

…s-migration/ReimbursementAccount/page

fix: lint

55630d6

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

0743b0e

…s-migration/ReimbursementAccount/page

VickyStash reviewed Feb 29, 2024

View reviewed changes

kubabutkiewicz added 4 commits February 29, 2024 12:30

fix: resolve comments

bd53388

fix: typecheck

0148be1

fix: lint

6b82c5d

fix: resolve comments

7f85aba

VickyStash reviewed Feb 29, 2024

View reviewed changes

src/pages/ReimbursementAccount/ContinueBankAccountSetup.tsx Outdated Show resolved Hide resolved

src/pages/ReimbursementAccount/ReimbursementAccountPage.tsx Outdated Show resolved Hide resolved

src/types/onyx/ReimbursementAccount.ts Outdated Show resolved Hide resolved

fix: resolve comments

3929cc8

fabioh8010 reviewed Mar 1, 2024

View reviewed changes

kubabutkiewicz added 2 commits April 5, 2024 11:37

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

302b4c4

…s-migration/ReimbursementAccount/page

fix: resolve comments

3bd3b3b

DylanDylann approved these changes Apr 5, 2024

View reviewed changes

melvin-bot bot requested a review from rlinoz April 5, 2024 10:29

rlinoz reviewed Apr 5, 2024

View reviewed changes

kubabutkiewicz added 2 commits April 5, 2024 16:39

fix: removed unused type

dea796d

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

9086168

…s-migration/ReimbursementAccount/page

kubabutkiewicz added 2 commits April 9, 2024 10:05

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

7f1ec9d

…s-migration/ReimbursementAccount/page

fix: typecheck

7023d38

rlinoz approved these changes Apr 9, 2024

View reviewed changes

rlinoz merged commit 51704e5 into Expensify:main Apr 9, 2024
15 checks passed

github-actions bot mentioned this pull request Apr 10, 2024

Deploy Checklist: New Expensify 2024-04-10 #40026

Closed

melvin-bot bot mentioned this pull request Apr 18, 2024

[HOLD for payment 2024-04-25] [TS migration] Migrate 'ReimbursementAccount' page to TypeScript #25227

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'ReimbursementAccount' page to TypeScript #37214

[TS migration] Migrate 'ReimbursementAccount' page to TypeScript #37214

kubabutkiewicz commented Feb 26, 2024 •

edited

Loading

melvin-bot bot commented Feb 26, 2024

fabioh8010 commented Mar 11, 2024

kubabutkiewicz commented Mar 11, 2024

DylanDylann commented Apr 5, 2024 •

edited

Loading

kubabutkiewicz commented Apr 5, 2024

DylanDylann commented Apr 5, 2024

melvin-bot bot commented Apr 5, 2024

rlinoz commented Apr 5, 2024

rlinoz left a comment

rlinoz Apr 5, 2024

kubabutkiewicz Apr 5, 2024

kubabutkiewicz commented Apr 5, 2024

DylanDylann commented Apr 8, 2024

rlinoz commented Apr 8, 2024

kubabutkiewicz commented Apr 9, 2024

rlinoz commented Apr 9, 2024

DylanDylann commented Apr 9, 2024

DylanDylann commented Apr 9, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 18, 2024

[TS migration] Migrate 'ReimbursementAccount' page to TypeScript #37214

[TS migration] Migrate 'ReimbursementAccount' page to TypeScript #37214

Conversation

kubabutkiewicz commented Feb 26, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 26, 2024

fabioh8010 commented Mar 11, 2024

kubabutkiewicz commented Mar 11, 2024

DylanDylann commented Apr 5, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

kubabutkiewicz commented Apr 5, 2024

DylanDylann commented Apr 5, 2024

melvin-bot bot commented Apr 5, 2024

rlinoz commented Apr 5, 2024

rlinoz left a comment

Choose a reason for hiding this comment

rlinoz Apr 5, 2024

Choose a reason for hiding this comment

kubabutkiewicz Apr 5, 2024

Choose a reason for hiding this comment

kubabutkiewicz commented Apr 5, 2024

DylanDylann commented Apr 8, 2024

rlinoz commented Apr 8, 2024

kubabutkiewicz commented Apr 9, 2024

rlinoz commented Apr 9, 2024

DylanDylann commented Apr 9, 2024

DylanDylann commented Apr 9, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 18, 2024

kubabutkiewicz commented Feb 26, 2024 •

edited

Loading

DylanDylann commented Apr 5, 2024 •

edited

Loading