Use new isDeleted property for deleted actions #36747

arosiclair · 2024-02-16T23:00:25Z

HELD on https://github.com/Expensify/Web-Expensify/pull/41106

Details

We are now marking report actions as deleted by setting the deleted timestamp in their message array. We'll hide and ignore these actions like we did with deleted comments. For legacy support, we're still hiding ADDCOMMENT actions that have an empty message.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/367794

Tests

Deleting a money request

Sign into two accounts user A and B
As user A, start a new money request from user B such that there is only one expense on the report
Verify there's a report preview in their DM
Navigate to Report > Expense
Select Delete request in the 3 dot menu
Verify you're navigated back to the DM and the report preview is deleted

Changing a workspace money request into an invoice

Sign in as a collect policy admin
Open the policy settings page and run this JS snippet to enable policy expense chats

p = Policy.getCurrent();
p.policy.isPolicyExpenseChatEnabled = "true";
p.save();

Invite a new member
As the member, request money in the workspace chat
Sign into OldDot as the member
Find the expense report for the money request
Go to Details and change the Type to invoice
In NewDot, verify the report is removed from the workspace chat

Offline tests

None

QA Steps

Same as Tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…ed-report-actions

melvin-bot · 2024-03-12T13:39:39Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

arosiclair · 2024-03-12T13:43:19Z

@DylanDylann backend changes that are needed for this are on staging so make sure to test against that API. I'm not sure if you can test the second part (Changing a workspace money request into an invoice), but if you can't, that's okay. The internal engineer can take a look instead.

DylanDylann · 2024-03-12T13:44:14Z

Let's me try

DylanDylann · 2024-03-13T16:00:01Z

@arosiclair Do we only use deleted property for money request action?

arosiclair · 2024-03-13T16:07:48Z

@arosiclair Do we only use deleted property for money request action?

With the new backend changes, yes.

DylanDylann · 2024-03-13T16:40:31Z

@arosiclair Should we update deleted property of money report action in the IOU report? Currently, BE also doesn't support that

DylanDylann · 2024-03-13T16:43:46Z

In case, we have many money requests. If we delete a request money, we need to hide it in the IOU report instead of hiding the report preview in the main report (1:1 chat)

arosiclair · 2024-03-13T21:51:41Z

@arosiclair Should we update deleted property of money report action in the IOU report? Currently, BE also doesn't support that

That shouldn't be necessary atm.

In case, we have many money requests. If we delete a request money, we need to hide it in the IOU report instead of hiding the report preview in the main report (1:1 chat)

Ah yes to clarify, you must test with a new money request that only has one expense. Deleting the last expense will also delete the report and the report preview in the chat. I just updated the tests to reflect that.

The scenario of deleting one expense with others still left on the report should be unaffected.

DylanDylann · 2024-03-14T05:09:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-14.at.12.37.29.mov

Screen.Recording.2024-03-14.at.12.36.44.mov

Android: mWeb Chrome

Screen.Recording.2024-03-14.at.12.39.26.mov

Screen.Recording.2024-03-14.at.12.39.01.mov

iOS: Native

Screen.Recording.2024-03-14.at.12.41.58.mov

Screen.Recording.2024-03-14.at.12.41.45.mov

iOS: mWeb Safari

Screen.Recording.2024-03-14.at.12.04.14.mov

Screen.Recording.2024-03-14.at.12.04.53.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-14.at.11.59.11.mov

Screen.Recording.2024-03-14.at.12.00.07.mov

MacOS: Desktop

Screen.Recording.2024-03-14.at.12.12.54.mov

Screen.Recording.2024-03-14.at.12.13.17.mov

melvin-bot · 2024-03-14T06:14:24Z

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann

@grgia All yours

melvin-bot · 2024-03-20T03:04:10Z

@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-03-20T03:04:43Z

@arosiclair Test fails. Please help to merge main

DylanDylann · 2024-03-20T07:46:39Z

I shouldn't approve again

@Julesssss Please ignore this PR. @grgia is assigned before

grgia · 2024-03-20T10:25:26Z

@arosiclair bump on merge main :)

…ed-report-actions

arosiclair · 2024-03-20T15:53:17Z

We actually need a strict equality check for the message html (message[0].html === '') because CREATED actions have html undefined in their message array for some reason. That doesn't seem right but that's a separate issue. Ready for another review.

grgia · 2024-03-21T12:09:14Z

@DylanDylann can you confirm if you've retested

DylanDylann · 2024-03-21T12:11:18Z

@grgia Yeah, everything work well

OSBotify · 2024-03-21T14:28:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-22T16:19:24Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.56-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-27T04:48:33Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.56-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

add new isDeleted property

64ccb57

arosiclair self-assigned this Feb 16, 2024

arosiclair added 4 commits February 27, 2024 16:14

Merge branch 'main' of github.com:Expensify/App into arosiclair-delet…

6ac95af

…ed-report-actions

Merge branch 'main' of github.com:Expensify/App into arosiclair-delet…

415efe8

…ed-report-actions

use timestamp value for deleted

1b685c9

remove old comment

a197c1d

arosiclair changed the title ~~Use new isDeleted property for deleted actions~~ [HOLD] Use new isDeleted property for deleted actions Mar 4, 2024

arosiclair added 6 commits March 5, 2024 11:18

optimistically set deleted timestamp

926701c

stop deleting the preview action

a376718

use const

d34836f

fix condition order

f0cd568

Merge branch 'main' of github.com:Expensify/App into arosiclair-delet…

61680ba

…ed-report-actions

fix optional chaining

af1e735

arosiclair changed the title ~~[HOLD] Use new isDeleted property for deleted actions~~ Use new isDeleted property for deleted actions Mar 12, 2024

arosiclair marked this pull request as ready for review March 12, 2024 13:39

arosiclair requested a review from a team as a code owner March 12, 2024 13:39

melvin-bot bot removed the request for review from a team March 12, 2024 13:39

melvin-bot bot requested a review from DylanDylann March 12, 2024 13:39

DylanDylann approved these changes Mar 14, 2024

View reviewed changes

melvin-bot bot requested a review from grgia March 14, 2024 06:14

arosiclair dismissed grgia’s stale review via 68f5bbe March 19, 2024 19:36

arosiclair requested review from grgia and DylanDylann March 19, 2024 20:11

DylanDylann approved these changes Mar 20, 2024

View reviewed changes

melvin-bot bot requested a review from Julesssss March 20, 2024 03:04

grgia previously approved these changes Mar 20, 2024

View reviewed changes

Julesssss removed their request for review March 20, 2024 10:59

arosiclair added 2 commits March 20, 2024 10:27

Merge branch 'main' of github.com:Expensify/App into arosiclair-delet…

dd3af33

…ed-report-actions

use strict equality check for html string

82c9fc6

arosiclair dismissed grgia’s stale review via 82c9fc6 March 20, 2024 15:31

arosiclair requested a review from grgia March 20, 2024 15:53

grgia approved these changes Mar 21, 2024

View reviewed changes

arosiclair merged commit fb344de into main Mar 21, 2024
16 checks passed

arosiclair deleted the arosiclair-deleted-report-actions branch March 21, 2024 14:22

github-actions bot mentioned this pull request Mar 22, 2024

Deploy Checklist: New Expensify 2024-03-22 #38811

Closed

bondydaa mentioned this pull request Mar 22, 2024

[HOLD for payment 2024-04-05] [$500] Avatar of user who sent message disappears after deleting comment #38830

Closed

6 tasks

kbecciv mentioned this pull request Mar 23, 2024

[Backwards Compatibility] Workspace chat shows skeleton loading when changing report from Invoice to Expense #38888

Closed

6 tasks

marcochavezf mentioned this pull request Mar 26, 2024

[MEDIUM] Collect approvers-Report changed to invoice by employee still displayed in ND #38132

Closed

6 tasks

bernhardoj mentioned this pull request May 9, 2024

[HOLD for payment 2024-05-22] Hold expense - Thread header for system message is different from the actual system message #41202

Closed

6 tasks

ikevin127 mentioned this pull request Feb 9, 2025

[$250] Room - Whisper to invite member, disappears when mentioning another user. #56517

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use new isDeleted property for deleted actions #36747

Use new isDeleted property for deleted actions #36747

arosiclair commented Feb 16, 2024 •

edited

Loading

melvin-bot bot commented Mar 12, 2024

arosiclair commented Mar 12, 2024

DylanDylann commented Mar 12, 2024

DylanDylann commented Mar 13, 2024 •

edited

Loading

arosiclair commented Mar 13, 2024

DylanDylann commented Mar 13, 2024 •

edited

Loading

DylanDylann commented Mar 13, 2024

arosiclair commented Mar 13, 2024

DylanDylann commented Mar 14, 2024 •

edited

Loading

melvin-bot bot commented Mar 14, 2024

DylanDylann left a comment

melvin-bot bot commented Mar 20, 2024

DylanDylann commented Mar 20, 2024

DylanDylann commented Mar 20, 2024

grgia commented Mar 20, 2024

arosiclair commented Mar 20, 2024

grgia commented Mar 21, 2024

DylanDylann commented Mar 21, 2024

OSBotify commented Mar 21, 2024

OSBotify commented Mar 22, 2024

OSBotify commented Mar 27, 2024

Use new isDeleted property for deleted actions #36747

Use new isDeleted property for deleted actions #36747

Conversation

arosiclair commented Feb 16, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 12, 2024

arosiclair commented Mar 12, 2024

DylanDylann commented Mar 12, 2024

DylanDylann commented Mar 13, 2024 • edited Loading

arosiclair commented Mar 13, 2024

DylanDylann commented Mar 13, 2024 • edited Loading

DylanDylann commented Mar 13, 2024

arosiclair commented Mar 13, 2024

DylanDylann commented Mar 14, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Mar 14, 2024

DylanDylann left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Mar 20, 2024

DylanDylann commented Mar 20, 2024

DylanDylann commented Mar 20, 2024

grgia commented Mar 20, 2024

arosiclair commented Mar 20, 2024

grgia commented Mar 21, 2024

DylanDylann commented Mar 21, 2024

OSBotify commented Mar 21, 2024

OSBotify commented Mar 22, 2024

OSBotify commented Mar 27, 2024

arosiclair commented Feb 16, 2024 •

edited

Loading

DylanDylann commented Mar 13, 2024 •

edited

Loading

DylanDylann commented Mar 13, 2024 •

edited

Loading

DylanDylann commented Mar 14, 2024 •

edited

Loading