Drop domain names when searching for users and auto-filling mentions #36697

tienifr · 2024-02-16T14:00:42Z

Details

Fixed Issues

$ #35532
PROPOSAL: #35532 (comment)

Tests

Create a room with 4 members: 2 on the same private domain, 1 on another private domain, and 1 on a public domain
Draft a message that includes mentions for each user.
Verify that when mentioning a user on the same private domain, the search result for the mention should not include the domain for the user's email
Verify that when mentioning a user on a public domain or on a different private domain, the behavior should remain largely as it is, though we will now prepend an @ to the front of the login details when showing the mention options in search.

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Create a room with 4 members: 2 on the same private domain, 1 on another private domain, and 1 on a public domain
Draft a message that includes mentions for each user.
Verify that when mentioning a user on the same private domain, the search result for the mention should not include the domain for the user's email
Verify that when mentioning a user on a public domain or on a different private domain, the behavior should remain largely as it is, though we will now prepend an @ to the front of the login details when showing the mention options in search.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-16.at.21.11.33.mov

Android: mWeb Chrome

Screen.Recording.2024-02-16.at.21.16.12.mov

iOS: Native

Screen.Recording.2024-02-16.at.21.06.08.mov

iOS: mWeb Safari

Screen.Recording.2024-02-16.at.21.12.44.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-16.at.15.10.29.mov

MacOS: Desktop

Screen.Recording.2024-02-16.at.16.25.17.mov

…ions

melvin-bot · 2024-02-16T14:18:02Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2024-02-21T09:50:31Z

Hi @tienifr!
Can you please resolve conflicts?

allroundexperts · 2024-02-21T10:40:48Z

BUG

The name mention is not highlighted on Android.

allroundexperts · 2024-02-21T10:41:36Z

BUG

Email not getting shortened after a message is sent.

allroundexperts · 2024-02-21T10:45:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-21.at.3.37.50.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-02-21.at.3.35.50.PM.mov

iOS: Native

Screen.Recording.2024-02-21.at.3.34.05.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-02-21.at.3.31.35.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-21.at.3.27.29.PM.mov

MacOS: Desktop

Screen.Recording.2024-02-21.at.3.29.22.PM.mov

tienifr · 2024-02-22T10:13:36Z

Email not getting shortened after a message is sent.

@allroundexperts This should be fixed in #36347

allroundexperts

Looks good!

NikkiWines

Looks good but the auto-complete for phone number accounts still includes the @expensify.sms suffix.

Screen.Recording.2024-02-23.at.23.57.31.mov

tienifr · 2024-02-24T11:07:10Z

@NikkiWines As I see the phone number domain is expensify.sms, and it's not the private domain, I think all phone numbers have this domain. Beside it's different from test.com so I think we should preserve expensify.sms as it is in staging/production. Please correct me if I misunderstand sth. Thanks

NikkiWines · 2024-02-26T19:34:15Z

Yes, all phone numbers have the expensify.sms domain attached to them, but we don't want to display it.

Ideally, we'd be consistent in showing it or not showing it, and right now we've got kind of a mix (it's not shown in the room description or mention suggestions list, but it is shown in the auto-complete and the actual mention itself - the latter of which I think should also be resolved when the regression for domains showing up in mentions is fixed)

tienifr · 2024-02-27T04:43:57Z

@NikkiWines I fixed your case above. Please check the video below

Screen.Recording.2024-02-27.at.11.08.09.mov

tienifr · 2024-02-28T02:58:02Z

@allroundexperts Seems like @NikkiWines agrees with my fix above ^. Can you help review and test again? Thanks

NikkiWines

One very small suggestion but otherwise looks good 👍

src/libs/ReportUtils.ts

tienifr · 2024-02-28T04:05:23Z

Fixed

allroundexperts · 2024-02-28T06:06:48Z

Will re-review today!

allroundexperts · 2024-02-28T19:25:22Z

@tienifr Conflicts!

NikkiWines

oh whoops sorry I thought this had been updated.

tienifr · 2024-02-29T02:42:42Z

@allroundexperts fixed conflicts

tienifr · 2024-03-01T02:51:16Z

@allroundexperts This is almost done, can you please review soon? Thanks

allroundexperts · 2024-03-01T06:19:46Z

Working good. Tested with private & public domains. For phone numbers however, @expensify.sms is added after sending the message. I think that is related to the backend, but its showing up as @expensify.sms even when offline. @tienifr is this a bug?

Screen.Recording.2024-03-01.at.11.07.26.AM.mov

NikkiWines · 2024-03-01T07:46:01Z

Ah yeah, that's known and I commented on it recently here since that PR was intended to fix the actual mentions. I think we can handle it separately from this PR

allroundexperts

Looks good!

OSBotify · 2024-03-01T07:51:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-04T21:03:11Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.4.47-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-06T21:52:13Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.47-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

NikkiWines · 2024-03-08T18:37:16Z

Noticed a bug tied to this where you can't dismiss the mentions search bar if you're selecting a mention that's shorter than other mentions with the same first set of characters

Screen.Recording.2024-03-08.at.10.29.11.mov

tienifr added 3 commits February 16, 2024 15:22

fix: Drop domain names when searching for users and auto-filling ment…

8bce441

…ions

add useCallback

dc4d231

add logic to reconstruct mention

62b753f

tienifr marked this pull request as ready for review February 16, 2024 14:17

tienifr requested a review from a team as a code owner February 16, 2024 14:17

melvin-bot bot removed the request for review from a team February 16, 2024 14:18

melvin-bot bot requested a review from allroundexperts February 16, 2024 14:18

fix: conflicts

db89712

allroundexperts approved these changes Feb 23, 2024

View reviewed changes

melvin-bot bot requested a review from NikkiWines February 23, 2024 08:05

NikkiWines requested changes Feb 24, 2024

View reviewed changes

Merge branch 'main' into fix/35532

b2a2405

tienifr added 2 commits February 27, 2024 10:19

Merge branch 'main' into fix/35532

8a4dd0e

fix phonenumber mention

6ed7a05

resolve conflicts

3674d8f

NikkiWines requested changes Feb 28, 2024

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

change var name

c7b2c5f

NikkiWines previously approved these changes Feb 28, 2024

View reviewed changes

resolve conflicts

599904a

tienifr dismissed NikkiWines’s stale review via 599904a February 29, 2024 02:42

NikkiWines approved these changes Mar 1, 2024

View reviewed changes

NikkiWines merged commit 0c09803 into Expensify:main Mar 1, 2024
16 checks passed

allroundexperts approved these changes Mar 1, 2024

View reviewed changes

melvin-bot bot requested a review from NikkiWines March 1, 2024 07:47

tienifr mentioned this pull request Mar 1, 2024

[HOLD for payment 2024-03-13] MEDIUM: [$500] Drop domain names when searching for users and auto-filling mentions #35532

Closed

6 tasks

github-actions bot mentioned this pull request Mar 4, 2024

Deploy Checklist: New Expensify 2024-03-04 #37698

Closed

97 tasks

NikkiWines mentioned this pull request Mar 8, 2024

[$500] Domain name is not dropped when sending text with user mention from same domain #36347

Closed

6 tasks

jeremy-croff mentioned this pull request Mar 12, 2024

[HOLD for payment 2024-04-05] [$500] mentioning a user from a different domain with same "front part" of the email address as logged in account causes the mention render as you #38074

Closed

6 tasks

allroundexperts mentioned this pull request Mar 17, 2024

[HOLD for payment 2024-03-26] [HIGH] [$500] [Mentions] Cannot confirm mention via clicking or hitting the enter key #38358

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop domain names when searching for users and auto-filling mentions #36697

Drop domain names when searching for users and auto-filling mentions #36697

tienifr commented Feb 16, 2024 •

edited

Loading

melvin-bot bot commented Feb 16, 2024

allroundexperts commented Feb 21, 2024

allroundexperts commented Feb 21, 2024

allroundexperts commented Feb 21, 2024

allroundexperts commented Feb 21, 2024 •

edited

Loading

tienifr commented Feb 22, 2024

allroundexperts left a comment

NikkiWines left a comment

tienifr commented Feb 24, 2024

NikkiWines commented Feb 26, 2024

tienifr commented Feb 27, 2024

tienifr commented Feb 28, 2024

NikkiWines left a comment

tienifr commented Feb 28, 2024

allroundexperts commented Feb 28, 2024

allroundexperts commented Feb 28, 2024

NikkiWines left a comment •

edited

Loading

tienifr commented Feb 29, 2024

tienifr commented Mar 1, 2024

allroundexperts commented Mar 1, 2024

NikkiWines commented Mar 1, 2024

allroundexperts left a comment

OSBotify commented Mar 1, 2024

OSBotify commented Mar 4, 2024

OSBotify commented Mar 6, 2024

NikkiWines commented Mar 8, 2024

Drop domain names when searching for users and auto-filling mentions #36697

Drop domain names when searching for users and auto-filling mentions #36697

Conversation

tienifr commented Feb 16, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 16, 2024

allroundexperts commented Feb 21, 2024

allroundexperts commented Feb 21, 2024

allroundexperts commented Feb 21, 2024

allroundexperts commented Feb 21, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

tienifr commented Feb 22, 2024

allroundexperts left a comment

Choose a reason for hiding this comment

NikkiWines left a comment

Choose a reason for hiding this comment

tienifr commented Feb 24, 2024

NikkiWines commented Feb 26, 2024

tienifr commented Feb 27, 2024

tienifr commented Feb 28, 2024

NikkiWines left a comment

Choose a reason for hiding this comment

tienifr commented Feb 28, 2024

allroundexperts commented Feb 28, 2024

allroundexperts commented Feb 28, 2024

NikkiWines left a comment • edited Loading

Choose a reason for hiding this comment

tienifr commented Feb 29, 2024

tienifr commented Mar 1, 2024

allroundexperts commented Mar 1, 2024

NikkiWines commented Mar 1, 2024

allroundexperts left a comment

Choose a reason for hiding this comment

OSBotify commented Mar 1, 2024

OSBotify commented Mar 4, 2024

OSBotify commented Mar 6, 2024

NikkiWines commented Mar 8, 2024

tienifr commented Feb 16, 2024 •

edited

Loading

allroundexperts commented Feb 21, 2024 •

edited

Loading

NikkiWines left a comment •

edited

Loading