[TS Migration] Migrate 'CategoryPicker' to TypeScript #36353

mateuuszzzzz · 2024-02-12T17:45:00Z

Details

Fixed Issues

$ #31952

PROPOSAL:

Tests

Go to CategoryPicker via payment request or any other flow that uses it.
Use the search bar in CategoryPicker.
Try to pick different categories and cancel them by clicking for the second time on the same category.

Offline tests

QA Steps

Same as Tests

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android.native.webm

Android: mWeb Chrome

Android.mWeb.webm

iOS: Native

iOS.native.mp4

iOS: mWeb Safari

iOS.mWeb.mov

MacOS: Chrome / Safari

Desktop.browser.mov

MacOS: Desktop

Desktop.electron.mov

src/components/CategoryPicker.tsx

blazejkustra

Apart from onSubmit looks good, LGTM!

kubabutkiewicz

One nitpick, but LGTM

src/components/CategoryPicker.tsx

melvin-bot · 2024-02-16T09:37:00Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abdulrahuman5196 · 2024-02-16T18:41:41Z

I can take over this issue as per https://expensify.slack.com/archives/C02NK2DQWUX/p1708107813288869

cc: @Santhosh-Sellavel

abdulrahuman5196

Just comment so that it comes to my K2 for reference.

abdulrahuman5196 · 2024-02-19T09:22:04Z

Will be working on review today.

abdulrahuman5196 · 2024-02-20T08:57:46Z

Reviewing now

abdulrahuman5196 · 2024-02-20T11:24:42Z

@mateuuszzzzz Can you kindly fix the merge conflicts?
And tag me? I did initially testing and the changes looks fine.

mateuuszzzzz · 2024-02-20T12:45:16Z

@abdulrahuman5196 I merged the main branch. Unfortunately, it looks like GitHub has a bug and still shows conflicts.

abdulrahuman5196 · 2024-02-20T13:37:52Z

@mateuuszzzzz The changes haven't merged with main completely, still there are 30+ commits in main.

Could you pull the main locally and merge from main again?

mateuuszzzzz · 2024-02-20T15:24:51Z

@abdulrahuman5196 I noticed some PRs from the master changed a significant part of logic. Probably I need to record new videos etc. So It might take a little bit longer than I expected

abdulrahuman5196 · 2024-02-20T16:15:20Z

Sure. Do let me know once done. I will re-review

mateuuszzzzz · 2024-02-21T14:42:42Z

@abdulrahuman5196 ready

abdulrahuman5196 · 2024-02-21T17:16:20Z

@mateuuszzzzz Editing the category isn't working in this PR.

But its working in staging. (I think it was not working in staging also a day back)

Screen.Recording.2024-02-21.at.10.43.53.PM.mov

mateuuszzzzz · 2024-02-23T12:32:16Z

@mateuuszzzzz Editing the category isn't working in this PR.

But its working in staging. (I think it was not working in staging also a day back)

Screen.Recording.2024-02-21.at.10.43.53.PM.mov

@abdulrahuman5196 could you try one more time and do rm -rf node_modules; npm i before testing? I checked it again. This time with the latest fixes of CategoryPicker from the main branch, it works as expected. If this happens again could you share the reproduction steps?

abdulrahuman5196 · 2024-02-24T15:59:27Z

@mateuuszzzzz The previously mentioned issue is fixed now.

But I see a different issue now. The selected row is not showing with tick mark while searching in the category picker.

Screen.Recording.2024-02-24.at.9.26.15.PM.mov

mateuuszzzzz · 2024-02-26T10:46:43Z

@mateuuszzzzz The previously mentioned issue is fixed now.

But I see a different issue now. The selected row is not showing with tick mark while searching in the category picker.

Screen.Recording.2024-02-24.at.9.26.15.PM.mov

Could you let me know if you are sure this is not defined behavior? I checked how it works on the latest main branch and the selected row also won't show a check mark while searching. Perhaps this is bug from main branch

abdulrahuman5196 · 2024-02-26T10:59:50Z

@mateuuszzzzz

It is working fine in staging

Screen.Recording.2024-02-26.at.4.27.59.PM.mov

But seems to not work in main. Seems someone broke it in main.

mateuuszzzzz · 2024-02-26T15:02:44Z

@abdulrahuman5196 I can take a look at the root cause of this issue tomorrow. If it won't be very complicated I think we can resolve this in the current PR. What do you think?

abdulrahuman5196 · 2024-02-26T15:10:38Z

I can take a look at the root cause of this issue tomorrow. If it won't be very complicated I think we can resolve this in the current PR. What do you think?

@mateuuszzzzz I am fine to even report it as a separate issue, since this is not caused by this PR. Anyways your call.

mateuuszzzzz · 2024-02-27T08:33:06Z

I can take a look at the root cause of this issue tomorrow. If it won't be very complicated I think we can resolve this in the current PR. What do you think?

@mateuuszzzzz I am fine to even report it as a separate issue, since this is not caused by this PR. Anyways your call.

@abdulrahuman5196 I checked it and I don't see a fast solution so let's report it as a separate issue 👍

abdulrahuman5196 · 2024-02-28T16:53:43Z

Hi, @mateuuszzzzz Sorry, yesterday caught up in couple of blockers.

Could you kindly fix the merge conflicts? I can take a look?

abdulrahuman5196 · 2024-02-29T19:09:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-01.at.12.16.38.AM.mp4

Android: mWeb Chrome

Screen.Recording.2024-03-01.at.12.21.48.AM.mp4

iOS: Native

Screen.Recording.2024-02-29.at.11.54.09.PM.mp4

iOS: mWeb Safari

Screen.Recording.2024-02-29.at.11.58.09.PM.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-02-29.at.11.36.07.PM.mp4

MacOS: Desktop

Screen.Recording.2024-02-29.at.11.47.07.PM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours.

🎀 👀 🎀
C+ Reviewed

melvin-bot · 2024-02-29T19:18:14Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #31952 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

abdulrahuman5196 · 2024-02-29T19:20:44Z

FYI: @blimpich is assigned for internal review.

blimpich

One question, otherwise looks good 👍

src/components/CategoryPicker.tsx

blimpich

OSBotify · 2024-03-01T17:27:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-04T21:03:02Z

🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.47-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-06T21:52:04Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.47-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Migrate CategoryPicker to typescript

5462e35

blazejkustra suggested changes Feb 13, 2024

View reviewed changes

src/components/CategoryPicker.tsx Show resolved Hide resolved

src/components/CategoryPicker.tsx Outdated Show resolved Hide resolved

src/components/CategoryPicker.tsx Outdated Show resolved Hide resolved

src/components/CategoryPicker.tsx Outdated Show resolved Hide resolved

mateuuszzzzz added 2 commits February 13, 2024 12:30

Address part of the review

b052c10

Fix typo

1848f34

mateuuszzzzz requested a review from blazejkustra February 13, 2024 11:58

blazejkustra approved these changes Feb 13, 2024

View reviewed changes

mateuuszzzzz added 3 commits February 13, 2024 16:45

Add function argument for onSubmit

9470112

Resolve conflicts with main

dbf4921

Format code

6cb7f58

kubabutkiewicz approved these changes Feb 15, 2024

View reviewed changes

src/components/CategoryPicker.tsx Outdated Show resolved Hide resolved

mateuuszzzzz added 2 commits February 16, 2024 10:26

Remove Category type from function argument

b98d35a

Merge branch 'main' into ts/category-picker

f06ce4b

mateuuszzzzz marked this pull request as ready for review February 16, 2024 09:36

mateuuszzzzz requested a review from a team as a code owner February 16, 2024 09:36

melvin-bot bot removed the request for review from a team February 16, 2024 09:36

melvin-bot bot requested a review from Santhosh-Sellavel February 16, 2024 09:37

abdulrahuman5196 reviewed Feb 16, 2024

View reviewed changes

mateuuszzzzz added 2 commits February 20, 2024 13:34

Merge branch 'main' into ts/category-picker

7d4fd93

Force empty commit to prevent github bug

6e25272

Resolve conflicts with main branch

ce34761

mateuuszzzzz requested a review from blazejkustra February 21, 2024 13:04

mateuuszzzzz added 3 commits February 21, 2024 14:05

Rename type

a8ef57d

Format comment

a8c9838

Remove redundant const

de906e7

blazejkustra approved these changes Feb 21, 2024

View reviewed changes

Merge branch 'main' into ts/category-picker

5874a69

Resolve conflicts

4eba41d

abdulrahuman5196 approved these changes Feb 29, 2024

View reviewed changes

blimpich previously approved these changes Feb 29, 2024

View reviewed changes

src/components/CategoryPicker.tsx Outdated Show resolved Hide resolved

Move optionKey back to separate useMemo

50d5db0

mateuuszzzzz dismissed blimpich’s stale review via 50d5db0 March 1, 2024 09:29

blimpich approved these changes Mar 1, 2024

View reviewed changes

blimpich merged commit cda8b87 into Expensify:main Mar 1, 2024
17 checks passed

github-actions bot mentioned this pull request Mar 4, 2024

Deploy Checklist: New Expensify 2024-03-04 #37698

Closed

97 tasks

melvin-bot bot mentioned this pull request Mar 6, 2024

[HOLD for payment 2024-03-13] [TS migration] Migrate 'CategoryPicker' component to TypeScript #31952

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS Migration] Migrate 'CategoryPicker' to TypeScript #36353

[TS Migration] Migrate 'CategoryPicker' to TypeScript #36353

mateuuszzzzz commented Feb 12, 2024 •

edited

Loading

blazejkustra left a comment

kubabutkiewicz left a comment

melvin-bot bot commented Feb 16, 2024

abdulrahuman5196 commented Feb 16, 2024

abdulrahuman5196 left a comment

abdulrahuman5196 commented Feb 19, 2024

abdulrahuman5196 commented Feb 20, 2024

abdulrahuman5196 commented Feb 20, 2024

mateuuszzzzz commented Feb 20, 2024

abdulrahuman5196 commented Feb 20, 2024

mateuuszzzzz commented Feb 20, 2024

abdulrahuman5196 commented Feb 20, 2024

mateuuszzzzz commented Feb 21, 2024

abdulrahuman5196 commented Feb 21, 2024

mateuuszzzzz commented Feb 23, 2024 •

edited

Loading

abdulrahuman5196 commented Feb 24, 2024

mateuuszzzzz commented Feb 26, 2024 •

edited

Loading

abdulrahuman5196 commented Feb 26, 2024

mateuuszzzzz commented Feb 26, 2024

abdulrahuman5196 commented Feb 26, 2024 •

edited

Loading

mateuuszzzzz commented Feb 27, 2024

abdulrahuman5196 commented Feb 28, 2024

abdulrahuman5196 commented Feb 29, 2024 •

edited

Loading

abdulrahuman5196 left a comment

melvin-bot bot commented Feb 29, 2024

abdulrahuman5196 commented Feb 29, 2024

blimpich left a comment

blimpich left a comment

OSBotify commented Mar 1, 2024

OSBotify commented Mar 4, 2024

OSBotify commented Mar 6, 2024

[TS Migration] Migrate 'CategoryPicker' to TypeScript #36353

[TS Migration] Migrate 'CategoryPicker' to TypeScript #36353

Conversation

mateuuszzzzz commented Feb 12, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

blazejkustra left a comment

Choose a reason for hiding this comment

kubabutkiewicz left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Feb 16, 2024

abdulrahuman5196 commented Feb 16, 2024

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

abdulrahuman5196 commented Feb 19, 2024

abdulrahuman5196 commented Feb 20, 2024

abdulrahuman5196 commented Feb 20, 2024

mateuuszzzzz commented Feb 20, 2024

abdulrahuman5196 commented Feb 20, 2024

mateuuszzzzz commented Feb 20, 2024

abdulrahuman5196 commented Feb 20, 2024

mateuuszzzzz commented Feb 21, 2024

abdulrahuman5196 commented Feb 21, 2024

mateuuszzzzz commented Feb 23, 2024 • edited Loading

abdulrahuman5196 commented Feb 24, 2024

mateuuszzzzz commented Feb 26, 2024 • edited Loading

abdulrahuman5196 commented Feb 26, 2024

mateuuszzzzz commented Feb 26, 2024

abdulrahuman5196 commented Feb 26, 2024 • edited Loading

mateuuszzzzz commented Feb 27, 2024

abdulrahuman5196 commented Feb 28, 2024

abdulrahuman5196 commented Feb 29, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Feb 29, 2024

abdulrahuman5196 commented Feb 29, 2024

blimpich left a comment

Choose a reason for hiding this comment

blimpich left a comment

Choose a reason for hiding this comment

OSBotify commented Mar 1, 2024

OSBotify commented Mar 4, 2024

OSBotify commented Mar 6, 2024

mateuuszzzzz commented Feb 12, 2024 •

edited

Loading

mateuuszzzzz commented Feb 23, 2024 •

edited

Loading

mateuuszzzzz commented Feb 26, 2024 •

edited

Loading

abdulrahuman5196 commented Feb 26, 2024 •

edited

Loading

abdulrahuman5196 commented Feb 29, 2024 •

edited

Loading