Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev/prod issues by splitting up webpack configs #36

Merged
merged 3 commits into from
Aug 10, 2020
Merged

Conversation

AndrewGable
Copy link
Contributor

Our IS_ON_PRODUCTION check wasn't working due to the single webpack config, this splits them up into a dev and production config. I verified that the production config calls prod.

@AndrewGable AndrewGable requested a review from tgolen August 10, 2020 17:54
@AndrewGable AndrewGable self-assigned this Aug 10, 2020
Copy link
Contributor

@tgolen tgolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@tgolen tgolen merged commit fb44706 into master Aug 10, 2020
@tgolen tgolen deleted the andrew-fix branch August 10, 2020 18:00
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 13, 2023

Deploying helpdot with  Cloudflare Pages  Cloudflare Pages

Latest commit: d80d267
Status: ✅  Deploy successful!
Preview URL: https://b283c06a.helpdot.pages.dev

View logs

hayata-suenaga pushed a commit that referenced this pull request Feb 1, 2024
…-merge-fixes-v6

ideal-nav-merge fixes v6
grgia pushed a commit that referenced this pull request Oct 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

🚀 Deployed to staging by https://github.com/tgolen in version: 9.0.46-0 🚀

platform result
🤖 android 🤖 cancelled 🔪
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪
🕸 web 🕸 success ✅

Copy link
Contributor

github-actions bot commented Oct 9, 2024

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.46-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants