Fix/31730: Remove green dot after deleting the Money request #32707

DylanDylann · 2023-12-08T05:04:36Z

Details

Remove green dot after deleting the Money request

Fixed Issues

$ #31730
PROPOSAL: #31730 (comment)

Tests

Create a new workspace
Go to FAB > Request Money
Choose the newly created workspace > Request money
Notice the green dot will appear on LHN to indicate money to be settled
On the main chat in the workspace go to the IOU report
Send a message (Important step)
Delete the money requested.
Verify that the green dot disappear and there is no settle button

Verify that no errors appear in the JS console

Offline tests

Same above

QA Steps

Same above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screencast.from.08-12-2023.17.28.06.webm

Android: mWeb Chrome

iOS: Native

ios.mp4

iOS: mWeb Safari

sa.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

de.mp4

melvin-bot · 2023-12-08T05:48:28Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif

There should be failure data as well

aimane-chnaif · 2023-12-10T15:15:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

DylanDylann · 2023-12-11T05:25:27Z

@aimane-chnaif When deleting the request fails, the request still exists. Do you want to hide green dot in this case ?

aimane-chnaif · 2023-12-11T05:30:47Z

@aimane-chnaif When deleting the request fails, the request still exists. Do you want to hide green dot in this case ?

Why hide? If delete fails, outstanding request still remains

DylanDylann · 2023-12-11T05:31:55Z

There should be failure data as well

@aimane-chnaif what do you mean here ?

aimane-chnaif · 2023-12-11T05:37:21Z

There should be failure data as well

@aimane-chnaif what do you mean here ?

With your current change, green dot will be hidden even though delete fails and request still exists, right?

aimane-chnaif

LGTM 🎉

DylanDylann · 2023-12-11T06:36:59Z

@aimane-chnaif Got it, I updated

aldo-expensify · 2023-12-12T15:41:37Z

The testing step 8 is incorrect, right? it looks like it has the wrong expected result

aimane-chnaif · 2023-12-12T15:43:59Z

The testing step 8 is incorrect, right? it looks like it has the wrong expected result

Good catch! @DylanDylann you just copied OP in the issue. Please copy one more from Expected Result

@aldo-expensify what is plan for backend fix? Can this be merged earlier?

aldo-expensify · 2023-12-12T15:55:20Z

@aldo-expensify what is plan for backend fix?

I'll start investigating asap

Can this be merged earlier?

hmm, I think we can... there will be inconsistent behaviour while we don't have both fixes deployed, no matter the order.

aldo-expensify · 2023-12-12T15:55:50Z

Tested well for me!, thanks for the fix.

OSBotify · 2023-12-12T15:59:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-13T11:30:40Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.4.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-13T11:51:23Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.4.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-13T12:18:57Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.4.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-14T15:25:40Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.12-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

DylanDylann added 2 commits December 8, 2023 12:02

reset green button when deleting request

cafae77

add condition

dea8ce1

DylanDylann marked this pull request as ready for review December 8, 2023 05:48

DylanDylann requested a review from a team as a code owner December 8, 2023 05:48

melvin-bot bot requested review from aimane-chnaif and removed request for a team December 8, 2023 05:48

aimane-chnaif reviewed Dec 10, 2023

View reviewed changes

add failure daat

5b7ccea

aimane-chnaif approved these changes Dec 11, 2023

View reviewed changes

melvin-bot bot requested a review from aldo-expensify December 11, 2023 06:36

aldo-expensify approved these changes Dec 12, 2023

View reviewed changes

aldo-expensify merged commit da2a96b into Expensify:main Dec 12, 2023

github-actions bot mentioned this pull request Dec 13, 2023

[$500] Deploy Checklist: New Expensify 2023-12-13 #32963

Closed

64 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/31730: Remove green dot after deleting the Money request #32707

Fix/31730: Remove green dot after deleting the Money request #32707

DylanDylann commented Dec 8, 2023 •

edited

Loading

melvin-bot bot commented Dec 8, 2023

aimane-chnaif left a comment

aimane-chnaif commented Dec 10, 2023

DylanDylann commented Dec 11, 2023

aimane-chnaif commented Dec 11, 2023

DylanDylann commented Dec 11, 2023 •

edited

Loading

aimane-chnaif commented Dec 11, 2023

aimane-chnaif left a comment

DylanDylann commented Dec 11, 2023

aldo-expensify commented Dec 12, 2023

aimane-chnaif commented Dec 12, 2023

aldo-expensify commented Dec 12, 2023

aldo-expensify commented Dec 12, 2023

OSBotify commented Dec 12, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 14, 2023

Fix/31730: Remove green dot after deleting the Money request #32707

Fix/31730: Remove green dot after deleting the Money request #32707

Conversation

DylanDylann commented Dec 8, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 8, 2023

aimane-chnaif left a comment

Choose a reason for hiding this comment

aimane-chnaif commented Dec 10, 2023

Reviewer Checklist

Screenshots/Videos

DylanDylann commented Dec 11, 2023

aimane-chnaif commented Dec 11, 2023

DylanDylann commented Dec 11, 2023 • edited Loading

aimane-chnaif commented Dec 11, 2023

aimane-chnaif left a comment

Choose a reason for hiding this comment

DylanDylann commented Dec 11, 2023

aldo-expensify commented Dec 12, 2023

aimane-chnaif commented Dec 12, 2023

aldo-expensify commented Dec 12, 2023

aldo-expensify commented Dec 12, 2023

OSBotify commented Dec 12, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 14, 2023

DylanDylann commented Dec 8, 2023 •

edited

Loading

DylanDylann commented Dec 11, 2023 •

edited

Loading