[NO QA] update wallet banner UI, wallet red dot condition #32106

pasyukevich · 2023-11-28T12:13:33Z

Details

Fixed Issues

$ #30677
PROPOSAL:

Tests

Add test data to the InitialSettingsPage.js

window.Onyx.merge('cardList', {
        "1": {
            "availableSpend": 1000000,
            "bank": "Expensify Card",
            "cardID": 1,
            "cardholderFirstName": "FirstName",
            "cardholderLastName": "LastName",
            "domainName": "expensify.com",
            "fraud": "individual",
            "isVirtual": false,
            "lastFourPAN": "1234",
            "state": 3
          },
          "2": {
            "availableSpend": 1000000,
            "bank": "Expensify Card",
            "cardID": 2,
            "cardholderFirstName": "FirstName",
            "cardholderLastName": "LastName",
            "domainName": "expensify.com",
            "fraud": "none",
            "isVirtual": true,
            "lastFourPAN": "9876",
            "state": 3
          }
    });

Open settings and verify that the wallet item is displayed with the red dot
Open the wallet and press on the Expensify card
Verify updated design for individual fraud
update test data with "fraud": "domain"
verify for domain fraud

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

anrdoid-native-converted.webm

Android: mWeb Chrome

anrdoid-web-converted.webm

iOS: Native

ios-native-converted.mp4

iOS: mWeb Safari

ios-web-converted.mp4

MacOS: Chrome / Safari

desktop-web-converted.mov

MacOS: Desktop

desktop-naive-converted.mov

src/libs/CardUtils.ts

src/pages/settings/Wallet/RedDotCardSection.js

Co-authored-by: Fábio Henriques <fabio.lacerda@outlook.com>

melvin-bot · 2023-11-29T16:12:21Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

pasyukevich · 2023-12-06T11:15:39Z

@eVoloshchak friendly bump

eVoloshchak · 2023-12-06T20:54:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

eVoloshchak

LGTM

grgia · 2023-12-08T13:08:06Z

@pasyukevich could you merge main? I'd like to check the new color key is used

pasyukevich · 2023-12-08T16:47:18Z

@grgia updated with latest main

grgia · 2023-12-11T16:02:56Z

src/styles/themes/light.ts

@@ -34,7 +34,7 @@ const lightTheme = {
    successPressed: colors.greenPressed,
    transparent: colors.transparent,
    signInPage: colors.green800,
-    dangerSection: colors.tangerine800,
+    darkSupportingText: colors.darkSupportingText,


this color key no longer exists, could you use productDark800?

grgia · 2023-12-11T16:03:07Z

src/styles/themes/default.ts

@@ -34,7 +34,7 @@ const darkTheme = {
    successPressed: colors.greenPressed,
    transparent: colors.transparent,
    signInPage: colors.green800,
-    dangerSection: colors.tangerine800,
+    darkSupportingText: colors.darkSupportingText,


this color key no longer exists, could you use productLight800?

grgia

Looks good in both themes and red dot is shown properly, thank you again!

OSBotify · 2023-12-12T17:39:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-13T11:29:04Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.4.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-13T11:49:47Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.4.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

kavimuru · 2023-12-13T11:59:53Z

@pasyukevich Could you share the QA steps? If I run the script mentioned in step 1 in console getting "uncaught error"

OSBotify · 2023-12-13T12:17:21Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.4.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2023-12-13T18:18:54Z

@Julesssss Is this internal QA? Could you help #32106 (comment), not sure if we are doing anything wrong.

Julesssss · 2023-12-14T09:04:41Z

@kavimuru ah yeah, this seems to be internal testing only 👍

OSBotify · 2023-12-14T15:24:04Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.12-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

pasyukevich force-pushed the feature/fraud-design-update branch from 1be0941 to 77ad9b1 Compare November 28, 2023 12:26

fabioh8010 reviewed Nov 28, 2023

View reviewed changes

pasyukevich force-pushed the feature/fraud-design-update branch from 77ad9b1 to 7b90e51 Compare November 28, 2023 13:43

pasyukevich and others added 2 commits November 29, 2023 15:11

update wallet banner UI, wallet red dot condition

bea9c64

update hasDetectedFraud return type

a5e82b1

Co-authored-by: Fábio Henriques <fabio.lacerda@outlook.com>

pasyukevich force-pushed the feature/fraud-design-update branch from ae06926 to a5e82b1 Compare November 29, 2023 14:11

apply prettier

2f63915

pasyukevich marked this pull request as ready for review November 29, 2023 16:12

pasyukevich requested a review from a team as a code owner November 29, 2023 16:12

melvin-bot bot requested review from eVoloshchak and removed request for a team November 29, 2023 16:12

eVoloshchak approved these changes Dec 6, 2023

View reviewed changes

melvin-bot bot requested a review from grgia December 6, 2023 21:21

Merge branch 'main' into feature/fraud-design-update

f3d3860

grgia requested changes Dec 11, 2023

View reviewed changes

update dark supporting text color

fef4dc4

pasyukevich requested a review from grgia December 12, 2023 16:45

grgia approved these changes Dec 12, 2023

View reviewed changes

grgia merged commit 1510651 into Expensify:main Dec 12, 2023

github-actions bot mentioned this pull request Dec 13, 2023

[$500] Deploy Checklist: New Expensify 2023-12-13 #32963

Closed

64 tasks

Julesssss changed the title ~~update wallet banner UI, wallet red dot condition~~ [NO QA] update wallet banner UI, wallet red dot condition Dec 14, 2023

eVoloshchak mentioned this pull request Jan 14, 2024

[ECard Settings] 🐛 Fraud is missing RBR on Settings Page + Update Banner UI #30677

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NO QA] update wallet banner UI, wallet red dot condition #32106

[NO QA] update wallet banner UI, wallet red dot condition #32106

pasyukevich commented Nov 28, 2023 •

edited

Loading

melvin-bot bot commented Nov 29, 2023

pasyukevich commented Dec 6, 2023

eVoloshchak commented Dec 6, 2023 •

edited

Loading

eVoloshchak left a comment

grgia commented Dec 8, 2023

pasyukevich commented Dec 8, 2023

grgia Dec 11, 2023

pasyukevich Dec 12, 2023

grgia Dec 11, 2023

pasyukevich Dec 12, 2023

grgia left a comment

OSBotify commented Dec 12, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 13, 2023

kavimuru commented Dec 13, 2023

OSBotify commented Dec 13, 2023

kavimuru commented Dec 13, 2023

Julesssss commented Dec 14, 2023

OSBotify commented Dec 14, 2023

[NO QA] update wallet banner UI, wallet red dot condition #32106

[NO QA] update wallet banner UI, wallet red dot condition #32106

Conversation

pasyukevich commented Nov 28, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 29, 2023

pasyukevich commented Dec 6, 2023

eVoloshchak commented Dec 6, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak left a comment

Choose a reason for hiding this comment

grgia commented Dec 8, 2023

pasyukevich commented Dec 8, 2023

grgia Dec 11, 2023

Choose a reason for hiding this comment

pasyukevich Dec 12, 2023

Choose a reason for hiding this comment

grgia Dec 11, 2023

Choose a reason for hiding this comment

pasyukevich Dec 12, 2023

Choose a reason for hiding this comment

grgia left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 12, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 13, 2023

kavimuru commented Dec 13, 2023

OSBotify commented Dec 13, 2023

kavimuru commented Dec 13, 2023

Julesssss commented Dec 14, 2023

OSBotify commented Dec 14, 2023

pasyukevich commented Nov 28, 2023 •

edited

Loading

eVoloshchak commented Dec 6, 2023 •

edited

Loading