added validation for image in reciept scan #27960

ishpaul777 · 2023-09-21T19:04:27Z

Details

Fixed Issues

$ #27389
PROPOSAL: #27389 (comment)

Tests

Verify that no errors appear in the JS console
On Android and IOS device -

Navigate to Request Money -> Scan
Upload a Image more than 24 mb.
Verify Error modal with "Attachement too large" message appears

Offline tests

QA Steps

Verify that no errors appear in the JS console
On Android and IOS device -

Navigate to Request Money -> Scan
Upload a Image more than 24 mb.
Verify Error modal with "Attachement too large" message appears

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-30.at.3.43.50.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-09-30.at.4.15.18.AM.mov

Mobile Web - Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-09-30.at.03.01.16.mp4

Desktop

Screen.Recording.2023-09-30.at.4.22.49.AM.mov

iOS

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-09-30.at.03.35.43.mp4

Android

Screen.Recording.2023-09-30.at.4.12.08.AM.mov

melvin-bot · 2023-09-21T19:04:32Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2023-09-21T19:07:20Z

@allroundexperts looks like the utility for file validation is removed in this PR, so I stick with my orignal proposal

src/pages/iou/ReceiptSelector/index.native.js

ishpaul777 · 2023-09-22T10:53:51Z

@allroundexperts Can you review changes and give feedback please 🙇

allroundexperts · 2023-09-24T17:48:48Z

@ishpaul777 Please resolve conflicts.

allroundexperts · 2023-09-24T22:50:01Z

@ishpaul777 Lint failing

allroundexperts · 2023-09-24T22:50:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

allroundexperts · 2023-09-24T22:56:41Z

src/pages/iou/ReceiptSelector/index.native.js

+    const hideReciptModal = () => {
+        setIsAttachmentInvalid(false);
+    };


The name of this function doesn't seem to match what its doing. Can you please rename it accordingly?

src/pages/iou/ReceiptSelector/index.native.js

allroundexperts

Requires changes.

ishpaul777 · 2023-09-25T10:07:28Z

@allroundexperts Thanks for reviewing, added require changes.

src/pages/iou/ReceiptSelector/index.native.js

allroundexperts

Changes requested.

ishpaul777 · 2023-09-26T10:02:23Z

@allroundexperts can you clarify questions above, Would be great if we can resolve and get this done before the end of today

…m/ishpaul777/App into fix/file-validation-native-device

ishpaul777 · 2023-09-26T17:29:47Z

@allroundexperts Added changes

ishpaul777 · 2023-09-27T08:59:16Z

gentle Bump @allroundexperts

allroundexperts

@ishpaul777 Much of the logic for validating the receipts is sort of duplicated from the web version of the file. Can we please DRY this up?

Since the state shape is same, maybe we can create a new hook?

The hook can be something like:

const {reset, validate, error: {title, description} } = useReceiptValidation()

src/hooks/useReceiptValidation.js

ishpaul777 · 2023-09-29T22:40:25Z

HI @allroundexperts, can you please priortize the review for this.

ishpaul777 · 2023-10-02T07:13:53Z

@allroundexperts Can I get a update here?

src/hooks/useReceiptValidation.js

ishpaul777 · 2023-10-02T09:50:31Z

Pushed requested change, waiting for your response on above unresolved review

ishpaul777 · 2023-10-04T08:26:32Z

hiI @allroundexperts, I have pushed the fix for requested changes please priortize the review.

ishpaul777 · 2023-10-06T10:50:05Z

@allroundexperts Any updates on when to expect a review?

ishpaul777 · 2023-10-09T13:59:01Z

@deetergp Hey, bumping for your thoughts on unresloved comment. context - #27960 (comment)

ishpaul777 · 2023-10-12T19:53:11Z

Hello @deetergp and @allroundexperts,

Sorry for the ping again, but I haven't received any feedback on above ^. I've invested a significant amount of effort into this PR. Initially, the first solution was nearly completed, but I had to rewrite it entirely based on the feedback provided here: #27960 (review).

Since then, I've been diligently keeping up with the main branch to resolve conflicts, and now I'm encountering numerous conflicts again, which require further refactoring. Given these circumstances, I kindly request that no penalties be applied to this situation.

Thank you for your understanding and consideration

allroundexperts · 2023-10-12T19:55:39Z

@ishpaul777 I think src/hooks/useReceiptValidation.js comment is still pending from your side. Can you please reply there?

ishpaul777 · 2023-10-12T19:58:24Z

can you comment on which comment you referring to.

allroundexperts · 2023-10-12T20:05:31Z

can you comment on which comment you referring to.

#27960 (comment)

allroundexperts · 2023-11-01T16:07:27Z

@ishpaul777 I've pinged you multiple times but I guess this was missed. Can you please address my below comment?

ishpaul777 · 2023-11-01T16:10:07Z

@allroundexperts i responded but i think there somthing wrong with github thread

allroundexperts · 2023-11-01T16:11:34Z

These are pending comments. I don't see them.

ishpaul777 · 2023-11-01T16:15:19Z

There is something wrong with github threads all replies are sent from my side.

ishpaul777 · 2023-11-01T16:15:51Z

Can you see these comments? @allroundexperts

ishpaul777 · 2023-11-01T16:20:25Z

Is this something that was happening prior to this PR as well?

Validations are added in this PR so there was no error modal before in ios app, but yes this can be noticed while sending images (size more than max limit) to a report.

added validation for image in reciept scan

d7e2e71

ishpaul777 requested a review from a team as a code owner September 21, 2023 19:04

melvin-bot bot requested review from allroundexperts and removed request for a team September 21, 2023 19:04

ishpaul777 commented Sep 21, 2023

View reviewed changes