Fix duplicate participant name and avatar #27912

hungvu193 · 2023-09-21T06:30:26Z

Details

Fix duplicate participant name and avatar

Fixed Issues

$ #25819
PROPOSAL: #25819 (comment)

Tests

Precondition: User A and User B never have any request moneys before.

Login as User A and User B in front of you at the same time.
As User A Open User B chat and request money.
As User B Open the same chat and request money from User A.
Verify that two different avatars and names appear on the IOU preview.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Precondition: User A and User B never have any request moneys before.

Login as User A and User B in front of you at the same time.
As User A Open User B chat and request money.
As User B Open the same chat and request money from User A.
Verify that two different avatars and names appear on the IOU preview.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-09-21.at.13.41.10.mov

Mobile Web - Chrome

Screen.Recording.2023-09-21.at.14.24.15.mov

Mobile Web - Safari

trim.F0E63ED6-D213-47D3-B32C-AC7B78CFBC13.MOV

Desktop

Screen.Recording.2023-09-21.at.13.41.10.mov

iOS

Screen.Recording.2023-09-21.at.14.23.23.mov

Android

Screen.Recording.2023-09-21.at.14.24.15.mov

melvin-bot · 2023-09-21T07:26:20Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2023-09-21T07:27:13Z

@jjcoffee PR is ready for review! Please have a look, ty 😄
@situchan Please share your thought on the PR, if it missed any cases, TIA 🙏

jjcoffee · 2023-09-21T12:25:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

chrome-desktop-2023-09-21_14.45.01.mp4

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

jjcoffee · 2023-09-21T15:12:09Z

src/pages/home/report/ReportActionItemSingle.js

@@ -114,14 +114,15 @@ function ReportActionItemSingle(props) {
    let secondaryAvatar = {};
    const primaryDisplayName = displayName;
    if (displayAllActors) {
-        const secondaryUserDetails = props.personalDetailsList[props.iouReport.ownerAccountID] || {};
+        const secondaryAccountId = props.iouReport.ownerAccountID === actorAccountID ? props.iouReport.managerID : props.iouReport.ownerAccountID;


I think we could do with an explanatory comment here as it's not obvious why/what we're doing.

Cool. Updated.
I'll test again in the morning to see if I missed any cases!

jjcoffee · 2023-09-21T15:19:04Z

@hungvu193 Tests well! I think the only thing I'm currently wondering about is if it's expected that the avatars should switch places when the other user requests money back (I understand why, but it feels a bit "jumpy" to me).

switching-avatars-2023-09-21_17.17.03.mp4

hungvu193 · 2023-09-22T11:15:23Z

So I've tested I didn't find any issue.

jjcoffee · 2023-09-22T12:07:07Z

@hungvu193 Thanks! I just want to clarify the expected behaviour with the avatar order, so I've raised this on Slack. Feel free to share your vote there.

jjcoffee · 2023-09-25T15:05:08Z

Discussion resolved - we're happy for the avatars to switch as long as the IOU owner is always the first (which will be the case here).

src/pages/home/report/ReportActionItemSingle.js

Co-authored-by: Joel Davies <joeld.dev@gmail.com>

jjcoffee

LGTM!

hayata-suenaga

looks good to me 🚀

OSBotify · 2023-09-26T01:14:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

jjcoffee · 2023-09-27T09:02:31Z

@hungvu193 Sorry, just realised I forgot to ask you to add a final test step to "Verify that two different avatars and names appear on the IOU preview" - otherwise QA might not know what they're testing for without reading the original issue!

hungvu193 · 2023-09-27T09:22:17Z

@hungvu193 Sorry, just realised I forgot to ask you to add a final test step to "Verify that two different avatars and names appear on the IOU preview" - otherwise QA might not know what they're testing for without reading the original issue!

My bad 😂 , I forgot to add verify step, thank you for pointing that out 🚀 . Updated the step btw.

OSBotify · 2023-09-28T19:20:24Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:24:20Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:52:58Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T15:53:55Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix duplicate participant name and avatar

8248196

hungvu193 marked this pull request as ready for review September 21, 2023 07:26

hungvu193 requested a review from a team as a code owner September 21, 2023 07:26

melvin-bot bot requested review from jjcoffee and removed request for a team September 21, 2023 07:26

jjcoffee reviewed Sep 21, 2023

View reviewed changes

add comment for secondaryAccountId

dfeabc8

jjcoffee reviewed Sep 25, 2023

View reviewed changes

src/pages/home/report/ReportActionItemSingle.js Outdated Show resolved Hide resolved

Update src/pages/home/report/ReportActionItemSingle.js

67ed516

Co-authored-by: Joel Davies <joeld.dev@gmail.com>

jjcoffee approved these changes Sep 25, 2023

View reviewed changes

melvin-bot bot requested a review from hayata-suenaga September 25, 2023 15:19

hayata-suenaga approved these changes Sep 26, 2023

View reviewed changes

hayata-suenaga merged commit c6b7eae into Expensify:main Sep 26, 2023

dummy-1111 mentioned this pull request Sep 27, 2023

[$500] IOU - avatar icon & names are showing incorrectly in IOU title (after requesting an IOU amount and then changing the IOU amount after) #27398

Closed

6 tasks

OSBotify mentioned this pull request Sep 28, 2023

Deploy Checklist: New Expensify 2023-09-28 #28412

Closed

lanitochka17 mentioned this pull request Sep 29, 2023

Send Message - App crashes when User creates new chat #28473

Closed

6 tasks

allroundexperts mentioned this pull request Oct 1, 2023

[$500] Request Money - Offline Receipt & Distance request to worspace don't show requestor name #28554

Closed

6 tasks

melvin-bot bot mentioned this pull request Oct 2, 2023

[HOLD for overpayment refund] [$1000] Web - Duplicate particpant name and avatar at the top of the Money request message. #25819

Closed

6 tasks

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix duplicate participant name and avatar #27912

Fix duplicate participant name and avatar #27912

hungvu193 commented Sep 21, 2023 •

edited

Loading

melvin-bot bot commented Sep 21, 2023

hungvu193 commented Sep 21, 2023

jjcoffee commented Sep 21, 2023 •

edited

Loading

jjcoffee Sep 21, 2023

hungvu193 Sep 21, 2023

jjcoffee commented Sep 21, 2023

hungvu193 commented Sep 22, 2023

jjcoffee commented Sep 22, 2023

jjcoffee commented Sep 25, 2023

jjcoffee left a comment

hayata-suenaga left a comment

OSBotify commented Sep 26, 2023

jjcoffee commented Sep 27, 2023

hungvu193 commented Sep 27, 2023 •

edited

Loading

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

Fix duplicate participant name and avatar #27912

Fix duplicate participant name and avatar #27912

Conversation

hungvu193 commented Sep 21, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 21, 2023

hungvu193 commented Sep 21, 2023

jjcoffee commented Sep 21, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

jjcoffee Sep 21, 2023

Choose a reason for hiding this comment

hungvu193 Sep 21, 2023

Choose a reason for hiding this comment

jjcoffee commented Sep 21, 2023

hungvu193 commented Sep 22, 2023

jjcoffee commented Sep 22, 2023

jjcoffee commented Sep 25, 2023

jjcoffee left a comment

Choose a reason for hiding this comment

hayata-suenaga left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 26, 2023

jjcoffee commented Sep 27, 2023

hungvu193 commented Sep 27, 2023 • edited Loading

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

hungvu193 commented Sep 21, 2023 •

edited

Loading

jjcoffee commented Sep 21, 2023 •

edited

Loading

hungvu193 commented Sep 27, 2023 •

edited

Loading