Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: styling of Google Sign In button on Safari #26874

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Fix: styling of Google Sign In button on Safari #26874

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b69622f
willChangeTransform added for google icon
Pujan92 Sep 6, 2023
028262f
comment updated
Pujan92 Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/SignInButtons/GoogleSignIn/index.website.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ function GoogleSignIn({translate, isDesktopFlow}) {
};
}, [loadScript]);

// willChangeTransform is used to prevent the icon cut in safari when the overflow hidden and width given to the parent
// ref: https://stackoverflow.com/questions/75306089/safari-when-using-border-radius-and-overflow-hidden-to-parent-and-the-child-th
return isDesktopFlow ? (
<View style={styles.googlePillButtonContainer}>
<div
Expand All @@ -77,7 +79,7 @@ function GoogleSignIn({translate, isDesktopFlow}) {
/>
</View>
) : (
<View style={styles.googleButtonContainer}>
<View style={[styles.googleButtonContainer, styles.willChangeTransform]}>
<div
id={mainId}
role="button"
Expand Down