[No QA] Prevent double translation of hint #26727

neil-marcellini · 2023-09-04T21:32:52Z

Details

We were translating the AddressSearch hint prop, but that prop is automatically translated, so all we need to pass is the translation key. The hint prop is ultimately passed to our TextInput component, then used as inputHelpText, then passed to FormHelpMessage as the message, where finally it is translated. Therefore we must make sure not to translate it twice. Admittedly this is pretty confusing.

cc @hayata-suenaga

Fixed Issues

Related to #26719, but just a console error
PROPOSAL:

Tests

Go to settings> preferences> language> choose Spanish
Click green plus, Pedir dinero, distancia
Click Comienzo
Open the JS console, search for alrt and verify there are no results
Type in a partial address
Click out of (blur) the input
Click Guardar to attempt to save it
Verify that no errors appear in the JS console
Open the JS console, search for alrt and verify there are no results
Verify that you see error messages on the page

Offline tests

N/A

QA Steps

No QA

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

I only tested web because the changes are platform independent.

Web

Screen.Recording.2023-09-12.at.5.10.16.PM.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

src/pages/iou/WaypointEditor.js

hayata-suenaga · 2023-09-05T17:45:46Z

Is my understanding correct that we don't have to deploy this PR by SEB?

I remember Jason or Tom mentioned that the conference will be held in Log Angeles where where is a large Hispanic population?

allroundexperts · 2023-09-05T17:48:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-05.at.11.40.07.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-09-05.at.11.42.59.PM.mov

Mobile Web - Safari

Screen.Recording.2023-09-05.at.11.41.31.PM.mov

Desktop

Screen.Recording.2023-09-05.at.11.48.44.PM.mov

iOS

Screen.Recording.2023-09-05.at.11.45.41.PM.mov

Android

Screen.Recording.2023-09-05.at.11.45.20.PM.mov

allroundexperts · 2023-09-05T18:52:51Z

The above filled checklist is completed for the console error that appears once you enter the address selection screen. This PR does fix that correctly!

OSBotify · 2023-09-05T19:25:54Z

🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪

android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/26727/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/26727/index.html

desktop 💻	web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/26727/NewExpensify.dmg	https://26727.pr-testing.expensify.com

hayata-suenaga · 2023-09-06T16:06:29Z

@allroundexperts where you able to reproduce the issue this PR is trying to solve?

allroundexperts · 2023-09-06T16:09:15Z

@allroundexperts where you able to reproduce the issue this PR is trying to solve?

No. Were the internal engineers able to reproduce / debug the error message?

hayata-suenaga · 2023-09-06T16:12:15Z

Yes, on the staging application on a physical iOS device 😅

allroundexperts · 2023-09-06T16:13:13Z

Yes, on the staging application on a physical iOS device 😅

No. Remember that they were supposed to test the adhoc build which we generated above?
ref: https://expensify.slack.com/archives/C02NK2DQWUX/p1693936088030859

hayata-suenaga · 2023-09-06T16:38:55Z

Yes, on the staging application on a physical iOS device 😅

No. Remember that they were supposed to test the adhoc build which we generated above? ref: https://expensify.slack.com/archives/C02NK2DQWUX/p1693936088030859

Yep. I gonna recheck the result on this and will get back to you shortly

hayata-suenaga · 2023-09-06T16:42:29Z

Yes the internal engineer was able to reproduce the issue on the ad hoc build with the code from the main brach

Internal Slack convo as a memo for myself.

hayata-suenaga · 2023-09-06T16:45:14Z

This is the crash log the internal engineer got when tested with the ad hoc build from the main branch

crash.txt

allroundexperts · 2023-09-06T16:45:15Z

@hayata-suenaga How about the adhoc build of this branch?

hayata-suenaga · 2023-09-06T16:47:42Z

@allroundexperts an internal engineer is testing ad hoc build from this PR right now 🙇

will get back to you once done

hayata-suenaga · 2023-09-06T19:14:13Z

the app still crashed with the ad hoc build from this PR 😞

internal slack

allroundexperts · 2023-09-06T19:15:39Z

the app still crashed with the ad hoc build from this PR 😞

internal slack

Yup. I guessed it right. This PR just fixes the console error (which is a different and unrelated issue).

melvin-bot · 2023-09-13T00:08:02Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2023-09-13T00:16:12Z

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

neil-marcellini · 2023-09-13T00:17:17Z

@allroundexperts @hayata-suenaga this is ready for review now. The only purpose of this PR now is to clean up existing console errors.

neil-marcellini · 2023-09-13T00:17:49Z

@deetergp sorry I have no idea why you got PullerBear'ed here. Please ignore, or review if you really want to 😄

hayata-suenaga

I didn't know we have Error Utils! nice fix

are you planning to follow up with another PR that actually fixes the crash issue?

allroundexperts

Let's

melvin-bot · 2023-09-19T19:50:55Z

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2023-09-19T19:50:59Z

🎯 @allroundexperts, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #27811.

OSBotify · 2023-09-21T03:50:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-22T14:00:41Z

🚀 Deployed to staging by https://github.com/Gonals in version: 1.3.73-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-25T09:35:32Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.73-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-25T10:07:36Z

🚀 Deployed to staging by https://github.com/Gonals in version: 1.3.74-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-28T18:49:57Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Prevent double translation of hint

3df1cf7

neil-marcellini self-assigned this Sep 4, 2023

hayata-suenaga reviewed Sep 5, 2023

View reviewed changes

src/pages/iou/WaypointEditor.js Show resolved Hide resolved

hayata-suenaga added the Ready To Build label Sep 5, 2023

neil-marcellini changed the title ~~Prevent double translation of hint~~ [No QA] Prevent double translation of hint Sep 12, 2023

neil-marcellini added 2 commits September 12, 2023 16:44

Merge branch 'main' into neil-fix-date-crash

7a0682e

Update errorText prop type

0f359e1

Use addErrorMessage for all errors

7e632df

neil-marcellini marked this pull request as ready for review September 13, 2023 00:15

neil-marcellini requested a review from a team as a code owner September 13, 2023 00:15

neil-marcellini requested a review from allroundexperts September 13, 2023 00:15

melvin-bot bot requested review from deetergp and removed request for a team September 13, 2023 00:16

neil-marcellini requested review from hayata-suenaga and removed request for deetergp September 13, 2023 00:16

hayata-suenaga approved these changes Sep 13, 2023

View reviewed changes

allroundexperts approved these changes Sep 19, 2023

View reviewed changes

melvin-bot bot requested a review from Gonals September 19, 2023 19:50

melvin-bot bot mentioned this pull request Sep 19, 2023

Payment issue for E/App PR#26727 #27811

Closed

Gonals approved these changes Sep 21, 2023

View reviewed changes

Gonals merged commit f65c58e into main Sep 21, 2023

Gonals deleted the neil-fix-date-crash branch September 21, 2023 03:45

OSBotify mentioned this pull request Sep 22, 2023

Deploy Checklist: New Expensify 2023-09-22 #28013

Closed

96 tasks

This was referenced Sep 25, 2023

Deploy Checklist: New Expensify DUPE 2023-09-25 #28118

Closed

Deploy Checklist: New Expensify 2023-09-25 #28119

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] Prevent double translation of hint #26727

[No QA] Prevent double translation of hint #26727

neil-marcellini commented Sep 4, 2023 •

edited

Loading

hayata-suenaga commented Sep 5, 2023

allroundexperts commented Sep 5, 2023 •

edited

Loading

allroundexperts commented Sep 5, 2023

OSBotify commented Sep 5, 2023

hayata-suenaga commented Sep 6, 2023

allroundexperts commented Sep 6, 2023

hayata-suenaga commented Sep 6, 2023

allroundexperts commented Sep 6, 2023 •

edited

Loading

hayata-suenaga commented Sep 6, 2023

hayata-suenaga commented Sep 6, 2023

hayata-suenaga commented Sep 6, 2023

allroundexperts commented Sep 6, 2023

hayata-suenaga commented Sep 6, 2023 •

edited

Loading

hayata-suenaga commented Sep 6, 2023

allroundexperts commented Sep 6, 2023

melvin-bot bot commented Sep 13, 2023

melvin-bot bot commented Sep 13, 2023

neil-marcellini commented Sep 13, 2023

neil-marcellini commented Sep 13, 2023

hayata-suenaga left a comment

allroundexperts left a comment

melvin-bot bot commented Sep 19, 2023

melvin-bot bot commented Sep 19, 2023

OSBotify commented Sep 21, 2023

OSBotify commented Sep 22, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 28, 2023

[No QA] Prevent double translation of hint #26727

[No QA] Prevent double translation of hint #26727

Conversation

neil-marcellini commented Sep 4, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

hayata-suenaga commented Sep 5, 2023

allroundexperts commented Sep 5, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts commented Sep 5, 2023

OSBotify commented Sep 5, 2023

hayata-suenaga commented Sep 6, 2023

allroundexperts commented Sep 6, 2023

hayata-suenaga commented Sep 6, 2023

allroundexperts commented Sep 6, 2023 • edited Loading

hayata-suenaga commented Sep 6, 2023

hayata-suenaga commented Sep 6, 2023

hayata-suenaga commented Sep 6, 2023

allroundexperts commented Sep 6, 2023

hayata-suenaga commented Sep 6, 2023 • edited Loading

hayata-suenaga commented Sep 6, 2023

allroundexperts commented Sep 6, 2023

melvin-bot bot commented Sep 13, 2023

melvin-bot bot commented Sep 13, 2023

neil-marcellini commented Sep 13, 2023

neil-marcellini commented Sep 13, 2023

hayata-suenaga left a comment

Choose a reason for hiding this comment

allroundexperts left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 19, 2023

melvin-bot bot commented Sep 19, 2023

OSBotify commented Sep 21, 2023

OSBotify commented Sep 22, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 28, 2023

neil-marcellini commented Sep 4, 2023 •

edited

Loading

allroundexperts commented Sep 5, 2023 •

edited

Loading

allroundexperts commented Sep 6, 2023 •

edited

Loading

hayata-suenaga commented Sep 6, 2023 •

edited

Loading