Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculating the devicePixelRatio for the pdf to display with less pixels than the limit of the platform #25721
Calculating the devicePixelRatio for the pdf to display with less pixels than the limit of the platform #25721
Changes from all commits
e0708ec
ea8bc98
342688f
57e6499
7d34e6a
5c90a87
7e837eb
012fa2a
217e448
7c33146
145f15f
5fedae8
a8c3bfe
609c856
bebb637
ea4e5e8
5e8851b
7dbd94d
3400f2d
20fa08e
b80abb3
9565272
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would happen if we pass undefined to the page here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pecanoro, the default
devicePixelRatio
would be used, same as beforeBy default, it matches screen device pixel ratio, so for example 3 on most iPhones, 1 on standard resolution office monitor
This does return
undefined
for most PDFs, only the ones that won't fit require a custom devicePixelRatioThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation, just making sure I understand the code properly 😄