fix - Translate IOU contents to the correct langauage #25629

HezekielT · 2023-08-21T22:48:26Z

Details

Currently, we translate IOU contents only if their actionName is REPORTPREVIEW which means IOU contents whose report type is IOU will not be translated resulting in inconsistency. This PR aims to address this issue.

Fixed Issues

$ #21959
PROPOSAL: #21959 (comment)

Tests

Login to New Expensify.
Request money from account A to account B
Verify that, In the DM between A:B and LHN, the latest message displays as: "[account B's firstName] owes [amount]"
As account A, Go to Preferences -> Language, change to Spanish
Verify that, In the DM between A:B and LHN, the latest message displays as: "[account B's firstName] debe [amount]"
In account B, click "Pay elsewhere" button
As account A, verify that, In the DM between A:B and LHN, the latest message displays as: "pagó [amount] de otra forma"
Go to Preferences -> Language, change to English
Verify that, In the DM between A:B and LHN, the latest message displays as: "paid [amount] elsewhere"

NOTE

If you have a lot of IOU reports on LHN, you may notice some of them not being translated automatically until they are opened, this is a known limitation and will be handled.
Verify that no errors appear in the JS console

Offline tests

Needs an internet connection to request money.

QA Steps

Same As Test Section.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

translateIOUWeb.mov

Mobile Web - Chrome

translateIOUMWebChrome.mov

Mobile Web - Safari

translateIOUMWebSafari.mov

Desktop

translateIOUDesktop.mov

iOS

translateIOUiOSNative.mov

Android

translateIOUAndroidNative.mov

melvin-bot · 2023-08-21T22:48:30Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…he report

HezekielT · 2023-08-23T09:04:52Z

@aimane-chnaif Friendly bump for review 🙏

src/libs/OptionsListUtils.js

HezekielT · 2023-08-23T21:46:18Z

@aimane-chnaif I've made some change to make it more clear please take a look at it. sorry for any confusion I've caused.

src/libs/OptionsListUtils.js

madmax330 · 2023-08-28T18:22:12Z

@aimane-chnaif can you finish you review now that the comments are addressed?

src/pages/home/report/ReportActionItemMessage.js

aimane-chnaif · 2023-08-29T09:31:05Z

In main, IOU report seems broken in offline mode

desktop-offline.mov

aimane-chnaif · 2023-08-29T09:36:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

aimane-chnaif

LGTM 🎉

HezekielT · 2023-08-29T14:35:12Z

@aimane-chnaif Thanks for the review. Do you think I should update the Tests section of the PR to let the QA team know that some of the IOU contents may not be translated until they are opened so that they won't report it as a regression.

aimane-chnaif · 2023-08-29T14:36:00Z

@aimane-chnaif Thanks for the review. Do you think I should update the Tests section of the PR to let the QA team know that some of the IOU contents may not be translated until they are opened so that they won't report it as a regression.

Sure

HezekielT · 2023-08-29T14:42:53Z

Updated.

OSBotify · 2023-08-29T17:50:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-30T01:53:13Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.59-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T01:02:57Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.60-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T01:46:22Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.60-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T01:53:33Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T22:50:34Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.60-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aimane-chnaif · 2023-10-23T15:51:50Z

src/libs/OptionsListUtils.js

@@ -383,6 +383,8 @@ function getLastMessageTextForReport(report) {

    if (ReportUtils.isReportMessageAttachment({text: report.lastMessageText, html: report.lastMessageHtml, translationKey: report.lastMessageTranslationKey})) {
        lastMessageTextFromReport = `[${Localize.translateLocal(report.lastMessageTranslationKey || 'common.attachment')}]`;
+    } else if (ReportActionUtils.isMoneyRequestAction(lastReportAction)) {
+        lastMessageTextFromReport = ReportUtils.getReportPreviewMessage(report, lastReportAction);


We missed split bill case while localizing last message text for IOU action. So it showed $0 as last message for split action.
Issue - #26020

HezekielT and others added 5 commits August 22, 2023 00:15

Fix: translate iou contents

00c4d2c

Merge branch 'Expensify:main' into fix--21959-translate-IOU-contents

2a680b5

remove unnecessary indentations

7041495

remove unnecessary new lines

14b6145

fix indentation

3bc806f

HezekielT requested a review from a team as a code owner August 21, 2023 22:48

melvin-bot bot removed the request for review from a team August 21, 2023 22:48

melvin-bot bot requested a review from aimane-chnaif August 21, 2023 22:48

HezekielT mentioned this pull request Aug 21, 2023

[HOLD for payment 2023-09-07] [$1000] IOU - IOU content is not translated to Spanish and inconsistent message after kogout #21959

Closed

6 tasks

HezekielT added 3 commits August 22, 2023 01:54

fix prettier

19f5c9a

fix: check if the last report action is iou in addition to checking t…

9b29288

…he report

final fix for iou report actions

c0b459a

Merge branch 'Expensify:main' into fix--21959-translate-IOU-contents

acac4f3

aimane-chnaif reviewed Aug 23, 2023

View reviewed changes

src/libs/OptionsListUtils.js Outdated Show resolved Hide resolved

fix handle lastReportAction if it is undefined

ef76cda

aimane-chnaif reviewed Aug 23, 2023

View reviewed changes

src/libs/OptionsListUtils.js Outdated Show resolved Hide resolved

fix: use isMoneyRequest check in LHN

07887e1

HezekielT requested a review from aimane-chnaif August 29, 2023 02:16

aimane-chnaif reviewed Aug 29, 2023

View reviewed changes

src/pages/home/report/ReportActionItemMessage.js Outdated Show resolved Hide resolved

HezekielT and others added 2 commits August 29, 2023 11:21

fix: pass the iou message directly to ReportActionItemFragment

5992928

Merge branch 'Expensify:main' into fix--21959-translate-IOU-contents

968e886

aimane-chnaif approved these changes Aug 29, 2023

View reviewed changes

melvin-bot bot requested a review from madmax330 August 29, 2023 09:36

madmax330 approved these changes Aug 29, 2023

View reviewed changes

madmax330 merged commit 6660555 into Expensify:main Aug 29, 2023

OSBotify mentioned this pull request Aug 30, 2023

Deploy Checklist: New Expensify 2023-08-30 #26268

Closed

OSBotify mentioned this pull request Aug 31, 2023

Deploy Checklist: New Expensify 2023-08-31 #26359

Closed

69 tasks

DylanDylann mentioned this pull request Sep 16, 2023

[HOLD for payment 2023-10-09] [$500] LHN - Extra spaces between text is not displayed on LHN (works fine on android app) #27586

Closed

6 tasks

paultsimura mentioned this pull request Sep 28, 2023

[HOLD for payment 2023-10-23][$1000] IOU - When performing an invoice division in a group, the amount of this is set to zero #26020

Closed

5 tasks

aimane-chnaif reviewed Oct 23, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix - Translate IOU contents to the correct langauage #25629

fix - Translate IOU contents to the correct langauage #25629

HezekielT commented Aug 21, 2023 •

edited

Loading

melvin-bot bot commented Aug 21, 2023

HezekielT commented Aug 23, 2023

HezekielT commented Aug 23, 2023

madmax330 commented Aug 28, 2023

aimane-chnaif commented Aug 29, 2023

aimane-chnaif commented Aug 29, 2023

aimane-chnaif left a comment

HezekielT commented Aug 29, 2023

aimane-chnaif commented Aug 29, 2023

HezekielT commented Aug 29, 2023

OSBotify commented Aug 29, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023

aimane-chnaif Oct 23, 2023

fix - Translate IOU contents to the correct langauage #25629

fix - Translate IOU contents to the correct langauage #25629

Conversation

HezekielT commented Aug 21, 2023 • edited Loading

Details

Fixed Issues

Tests

NOTE

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 21, 2023

HezekielT commented Aug 23, 2023

HezekielT commented Aug 23, 2023

madmax330 commented Aug 28, 2023

aimane-chnaif commented Aug 29, 2023

aimane-chnaif commented Aug 29, 2023

Reviewer Checklist

Screenshots/Videos

aimane-chnaif left a comment

Choose a reason for hiding this comment

HezekielT commented Aug 29, 2023

aimane-chnaif commented Aug 29, 2023

HezekielT commented Aug 29, 2023

OSBotify commented Aug 29, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023

aimane-chnaif Oct 23, 2023

Choose a reason for hiding this comment

HezekielT commented Aug 21, 2023 •

edited

Loading