fix to getAccountIDForLogin applied #20818

burczu · 2023-06-15T13:08:41Z

Details

This PR fixes the issue with the lack of display name displayed in the tooltip while hovering over the avatars in the LHN.

Fixed Issues

$ #20801
PROPOSAL: #20801 (comment)

Tests

Open the App
Hover over some avatar in the LHN
Check if display shows up along with the user email

Verify that no errors appear in the JS console

Offline tests

Same as above.

QA Steps

Same as above.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

screen-capture-20801-web.mp4

Mobile Web - Chrome

n/a

Mobile Web - Safari

n/a

Desktop

screen-capture-20801-desktop.mp4

iOS

n/a

Android

n/a

melvin-bot · 2023-06-15T13:24:31Z

@Beamanator @fedirjh One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Beamanator

LGTM

Beamanator · 2023-06-15T13:31:58Z

@fedirjh please review when you have time and test on web & desktop

fedirjh · 2023-06-15T14:12:39Z

@burczu @Beamanator Unrelated to this PR, the logo of the tooltip for users with default avatars are different.

fedirjh · 2023-06-15T14:32:55Z

src/libs/ReportUtils.js

+    const keys = lodashKeys(allPersonalDetails);
+    const result = lodashFind(keys, (key) => allPersonalDetails[key].login === login) || '0';
+    return Number(result);


Suggested change

const keys = lodashKeys(allPersonalDetails);

const result = lodashFind(keys, (key) => allPersonalDetails[key].login === login) || '0';

return Number(result);

const accountID = _.findKey(allPersonalDetails, {login}) || '0';

return Number(accountID);

We can simplify this block , we can use underscore findKey .

This seemed to work well for me too 👍

fedirjh · 2023-06-15T14:38:01Z

src/libs/ReportUtils.js

+import lodashFind from 'lodash/find';
+import lodashKeys from 'lodash/keys';


Suggested change

import lodashFind from 'lodash/find';

import lodashKeys from 'lodash/keys';

Suggestion Follow up

fedirjh · 2023-06-15T14:53:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

0xmiros · 2023-06-15T16:43:37Z

Can we re-think of more optimized solution proposed here?

MonilBhavsar · 2023-06-15T16:54:47Z

Can anyone please confirm if this issue is fixed by this PR #20839
And if so linked the issue as closes. Thanks!

burczu · 2023-06-16T07:10:38Z

@0xmiroslav I think you are right and I agree that the other solution looks better. How do we want to tackle this? Should we close this PR and related issue, reopen the other one and let the author of that other proposal work on it?

cc: @Beamanator

burczu · 2023-06-16T07:14:57Z

@MonilBhavsar I think this PR won't fix the issue you've mentioned - it only fixes missing display name in the tooltip and doesn't handle too long emails/displayNames in any way...

0xmiros · 2023-06-16T07:21:39Z

@0xmiroslav I think you are right and I agree that the other solution looks better. How do we want to tackle this? Should we close this PR and related issue, reopen the other one and let the author of that other proposal work on it?

I am not sure. @alex-mechler will decide.

Beamanator · 2023-06-19T07:56:22Z

I agree with @0xmiroslav & @burczu that this solution looks best - Let's close this out & reopen that issue

fix to getAccountIDForLogin applied

855d4dd

burczu marked this pull request as ready for review June 15, 2023 13:24

burczu requested a review from a team as a code owner June 15, 2023 13:24

melvin-bot bot requested review from Beamanator and fedirjh and removed request for a team June 15, 2023 13:24

Beamanator approved these changes Jun 15, 2023

View reviewed changes

fedirjh reviewed Jun 15, 2023

View reviewed changes

alex-mechler mentioned this pull request Jun 15, 2023

[HOLD for payment 2023-06-29] [$1000] Tooltip not showing for single member in a group chat icon in LHN #20822

Closed

6 tasks

twisterdotcom mentioned this pull request Jun 15, 2023

[$1000] Default profile avatar is different in tooltip #20800

Closed

6 tasks

MonilBhavsar mentioned this pull request Jun 15, 2023

[HOLD for payment 2023-07-21] [HOLD for payment 2023-07-20] [$1000] Login(email) overflows out of tooltip #20839

Closed

6 tasks

fedirjh mentioned this pull request Jun 16, 2023

[HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] Tooltip not present on multiple avatar groups #20934

Closed

6 tasks

Beamanator closed this Jun 19, 2023

Beamanator mentioned this pull request Jun 19, 2023

[HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] [$1000] No avatar tooltip on "Workspace invite members" page (after inviting) #20820

Closed

6 tasks

burczu deleted the 20801_names-is-missing-in-lhn-tooltip branch June 19, 2023 08:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix to getAccountIDForLogin applied #20818

fix to getAccountIDForLogin applied #20818

burczu commented Jun 15, 2023 •

edited

Loading

melvin-bot bot commented Jun 15, 2023

Beamanator left a comment

Beamanator commented Jun 15, 2023

fedirjh commented Jun 15, 2023

fedirjh Jun 15, 2023 •

edited

Loading

Beamanator Jun 16, 2023

fedirjh Jun 15, 2023

fedirjh commented Jun 15, 2023

0xmiros commented Jun 15, 2023

MonilBhavsar commented Jun 15, 2023

burczu commented Jun 16, 2023 •

edited

Loading

burczu commented Jun 16, 2023

0xmiros commented Jun 16, 2023

Beamanator commented Jun 19, 2023

		import lodashFind from 'lodash/find';
		import lodashKeys from 'lodash/keys';

fix to getAccountIDForLogin applied #20818

fix to getAccountIDForLogin applied #20818

Conversation

burczu commented Jun 15, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 15, 2023

Beamanator left a comment

Choose a reason for hiding this comment

Beamanator commented Jun 15, 2023

fedirjh commented Jun 15, 2023

fedirjh Jun 15, 2023 • edited Loading

Choose a reason for hiding this comment

Beamanator Jun 16, 2023

Choose a reason for hiding this comment

fedirjh Jun 15, 2023

Choose a reason for hiding this comment

fedirjh commented Jun 15, 2023

Reviewer Checklist

Screenshots/Videos

0xmiros commented Jun 15, 2023

MonilBhavsar commented Jun 15, 2023

burczu commented Jun 16, 2023 • edited Loading

burczu commented Jun 16, 2023

0xmiros commented Jun 16, 2023

Beamanator commented Jun 19, 2023

burczu commented Jun 15, 2023 •

edited

Loading

fedirjh Jun 15, 2023 •

edited

Loading

burczu commented Jun 16, 2023 •

edited

Loading