Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[No QA] Use macos-13 runners for desktop builds" #20331

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

roryabraham
Copy link
Contributor

Reverts #20291. Straight revert.

@roryabraham roryabraham requested a review from a team as a code owner June 6, 2023 23:05
@roryabraham roryabraham self-assigned this Jun 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

@melvin-bot melvin-bot bot requested review from madmax330 and removed request for a team June 6, 2023 23:06
@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@roryabraham
Copy link
Contributor Author

Checklist ignored for straight revert of a GitHub Actions PR.

@AndrewGable AndrewGable merged commit 9245a4a into main Jun 6, 2023
@AndrewGable AndrewGable deleted the revert-20291-Rory-UseMacos13 branch June 6, 2023 23:15
@melvin-bot melvin-bot bot added the Emergency label Jun 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

@AndrewGable looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@AndrewGable
Copy link
Contributor

#20331 (comment)

OSBotify pushed a commit that referenced this pull request Jun 6, 2023
Revert "[No QA] Use macos-13 runners for desktop builds"

(cherry picked from commit 9245a4a)
@OSBotify
Copy link
Contributor

OSBotify commented Jun 8, 2023

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.26-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.26-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants