Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format whispers/welcome messages in the report action list of each chat #17527
Format whispers/welcome messages in the report action list of each chat #17527
Changes from 15 commits
c4b7c3d
8d59ce9
51fb7e4
1ed1046
621d79f
12f3c99
73919c7
e5aa976
46bd44c
ebc3534
d6e54cc
8c26440
503e0c3
2d4a524
21745be
a7b28fd
e7d4dad
b916bb6
c405a2f
64e5b04
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB: You might want to be careful with this line. I believe that
this.props.personalDetails
is an object (proptypes agrees) and this filter is turning it into an array (and the default value you've provided is also an array). Looking atReportUtils.getDisplayNamesWithTooltips()
the JSDoc says that the personal details parameter should be an object, but luckily, because all that method is doing is a_.map()
and it's never accessing they object keys, the code here technically works.I'd prefer to always keep personalDetails an object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typescript won't allow this 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this is out of scope of this PR but we caused this issue - #20451 (comment)
On native, the "New" message maker is hidden behind the whisper message because it's not transparent.