show not found page for invalid links #13027

aimane-chnaif · 2022-11-24T22:04:35Z

Details

show generic not found page when go to invalid links

Fixed Issues

$ #9818
PROPOSAL: #9818 (comment)

Tests

Scenario 1:

Go to any chat room
Send any message containing invalid links (i.e. https://staging.new.expensify.com/test, https://staging.new.expensify.com/r/4599960897843771/test)
Click that link
Verify that app shows full not found page

Scenario 2: (web, mWeb)

Go to https://staging.new.expensify.com
Login with any account
Enter any invalid Expensify link (i.e. https://staging.new.expensify.com/test, https://staging.new.expensify.com/r/4599960897843771/test) in address bar
Verify that app shows full not found page

Verify that no errors appear in the JS console

Offline tests

Scenario 1:

Go to any chat room
Turn off network
Send any message containing invalid links (i.e. https://staging.new.expensify.com/test, https://staging.new.expensify.com/r/4599960897843771/test)
Click that link
Verify that app shows full not found page

Scenario 2: (web, mWeb)
This can't be tested in offline mode

QA Steps

Scenario 1:

Go to any chat room
Send any message containing invalid links (i.e. https://staging.new.expensify.com/test, https://staging.new.expensify.com/r/4599960897843771/test)
Click that link
Verify that app shows full not found page

Scenario 2: (web, mWeb)

Go to https://staging.new.expensify.com
Login with any account
Enter any invalid Expensify link (i.e. https://staging.new.expensify.com/test, https://staging.new.expensify.com/r/4599960897843771/test) in address bar
Verify that app shows full not found page

Verify that no errors appear in the JS console

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

Mobile Web - Safari

msafari.mp4

Desktop

desktop.mov

iOS

ios.mp4

Android

melvin-bot · 2022-11-24T22:04:42Z

@pecanoro @Santhosh-Sellavel One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Santhosh-Sellavel · 2022-11-27T18:24:39Z

Seems to be working well. One doubt url alone is not persisted in address bar here when clicking link from message. Are we good with this @pecanoro

pecanoro · 2022-11-28T16:21:47Z

@aimane-chnaif Is there a way to keep the original URL in the navigation instead of showing /NotFound?

aimane-chnaif · 2022-11-28T16:23:22Z

@aimane-chnaif Is there a way to keep the original URL in the navigation instead of showing /NotFound?

I already researched that but found no way yet in react-navigation

pecanoro · 2022-11-28T17:12:32Z

@aimane-chnaif Ok! One last thing, is https://staging.new.expensify.com/r/4599960897843771 still working as before? We used to handle invalid chats properly already, just making sure we didn't remove it here.

Santhosh-Sellavel · 2022-11-28T17:20:46Z

@pecanoro

@aimane-chnaif Ok! One last thing, is https://staging.new.expensify.com/r/4599960897843771 still working as before? We used to handle invalid chats properly already, just making sure we didn't remove it here.

This is working fine!

aimane-chnaif · 2022-11-28T18:00:27Z

@aimane-chnaif Ok! One last thing, is https://staging.new.expensify.com/r/4599960897843771 still working as before? We used to handle invalid chats properly already, just making sure we didn't remove it here.

yes, my PR doesn't affect original behavior for that link

pecanoro · 2022-11-28T19:10:48Z

@marcaaron Just doubling checking, are you ok if we show /NotFound for the new route when we click a link that does not exist?

marcaaron · 2022-11-28T20:48:16Z

Oh hmm /NotFound is kind of a strange path. I would think we can make that whatever we want with a custom path like /404 or change it to /not-found, but if not then I don't think it's that big of a deal. The docs for this are here, but don't seem to mention customizing the path. Maybe it's possible to do something like this:

const config = {
  screens: {
    Home: {
      initialRouteName: 'Feed',
      screens: {
        Profile: 'users/:id',
        Settings: 'settings',
      },
    },
    'not-found': '*', // or 404: '*'
  },
};

aimane-chnaif · 2022-11-28T20:53:33Z

yeah different naming is possible. I also think NotFound is bad path in url.
What do you prefer? 'not-found' or '404' or any other else?

pecanoro · 2022-11-28T21:04:50Z

I prefer /not-found just because it is more descriptive, but not super strong opinion either way.

aimane-chnaif · 2022-11-28T22:08:44Z

updated to /not-found and pushed
since it's better naming than /NotFound

aimane-chnaif · 2022-11-28T23:59:53Z

@pecanoro please check

pecanoro · 2022-11-29T01:46:10Z

Can you update the videos to show the updated URL? I will review tomorrow morning!

aimane-chnaif · 2022-11-29T06:39:01Z

Can you update the videos to show the updated URL? I will review tomorrow morning!

@pecanoro updated videos

Santhosh-Sellavel · 2022-11-29T17:31:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2022-11-29.at.11.23.24.PM.mov

Mobile Web - Chrome & Safari

Screen.Recording.2022-11-29.at.11.19.46.PM.mov

Desktop

Screen.Recording.2022-11-29.at.11.22.19.PM.mov

iOS & Android

Screen.Recording.2022-11-29.at.11.16.03.PM.mov

Santhosh-Sellavel · 2022-11-29T18:18:44Z

Noticed one weird behavior, while clicking an invalid report URL from the message. Chat Not Found is shown on the Desktop. But in mWeb/native navigated to the chat list the behavior is the same on staging/production. It's not introduced here should we report this in slack?

ReportInvalid.mp4

Santhosh-Sellavel

Looks good, and tests well. Just a doubt here

src/pages/ErrorPage/NotFoundPage.js

pecanoro · 2022-11-29T21:53:34Z

Noticed one weird behavior, while clicking an invalid report URL from the message. Chat Not Found is shown on the Desktop. But in mWeb/native navigated to the chat list the behavior is the same on staging/production. It's not introduced here should we report this in slack?

I feel it should be part of the solution, do we know why the left navigation gets opened?

aimane-chnaif · 2022-11-30T00:41:39Z

I think that's out of scope for this GH. /r/xxx is considered valid url assuming xxx is report id but the issue is that user doesn't have access to that chat room or that report id doesn't exist.
So I think it can be handled in a separated GH

aimane-chnaif · 2022-11-30T00:51:56Z

Actually, we don't need to worry about that case.
@Santhosh-Sellavel that happens because you tested staging url in localhost.
If you test that url in staging, it should work as expected.

aimane-chnaif · 2022-11-30T01:25:03Z

Not sure thanksgiving holidays period are considered as business days but I'd like to get this sorted asap considering bonus/penalty timeline.

OSBotify · 2022-11-30T19:34:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Santhosh-Sellavel · 2022-11-30T19:42:48Z

Actually, we don't need to worry about that case. @Santhosh-Sellavel that happens because you tested staging url in localhost. If you test that url in staging, it should work as expected.

Check here as I mentioned

But in mWeb/native navigated to the chat list the behavior is the same on staging/production.

It already occurs on staging also.

OSBotify · 2022-12-01T17:08:50Z

🚀 Deployed to staging by @pecanoro in version: 1.2.35-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-12-02T18:58:57Z

🚀 Deployed to production by @luacmartins in version: 1.2.35-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

show not found page for invalid links

6b59d5e

aimane-chnaif requested a review from a team as a code owner November 24, 2022 22:04

melvin-bot bot requested review from pecanoro and Santhosh-Sellavel and removed request for a team November 24, 2022 22:04

update invalid path name

9eaede9

Santhosh-Sellavel reviewed Nov 29, 2022

View reviewed changes

src/pages/ErrorPage/NotFoundPage.js Show resolved Hide resolved

pecanoro approved these changes Nov 30, 2022

View reviewed changes

pecanoro merged commit 6a50344 into Expensify:main Nov 30, 2022

OSBotify mentioned this pull request Dec 1, 2022

Deploy Checklist: New Expensify 2022-12-01 #13240

Closed

11 tasks

situchan mentioned this pull request May 8, 2023

[$1000] Chat - Page not found is displayed when Copy link of any message and then click on it #17977

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

show not found page for invalid links #13027

show not found page for invalid links #13027

aimane-chnaif commented Nov 24, 2022 •

edited

Loading

melvin-bot bot commented Nov 24, 2022

Santhosh-Sellavel commented Nov 27, 2022

pecanoro commented Nov 28, 2022

aimane-chnaif commented Nov 28, 2022

pecanoro commented Nov 28, 2022

Santhosh-Sellavel commented Nov 28, 2022

aimane-chnaif commented Nov 28, 2022

pecanoro commented Nov 28, 2022

marcaaron commented Nov 28, 2022

aimane-chnaif commented Nov 28, 2022

pecanoro commented Nov 28, 2022 •

edited

Loading

aimane-chnaif commented Nov 28, 2022

aimane-chnaif commented Nov 28, 2022

pecanoro commented Nov 29, 2022

aimane-chnaif commented Nov 29, 2022

Santhosh-Sellavel commented Nov 29, 2022 •

edited

Loading

Santhosh-Sellavel commented Nov 29, 2022

Santhosh-Sellavel left a comment

pecanoro commented Nov 29, 2022

aimane-chnaif commented Nov 30, 2022

aimane-chnaif commented Nov 30, 2022

aimane-chnaif commented Nov 30, 2022

OSBotify commented Nov 30, 2022

Santhosh-Sellavel commented Nov 30, 2022 •

edited

Loading

OSBotify commented Dec 1, 2022

OSBotify commented Dec 2, 2022

show not found page for invalid links #13027

show not found page for invalid links #13027

Conversation

aimane-chnaif commented Nov 24, 2022 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

PR Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Nov 24, 2022

Santhosh-Sellavel commented Nov 27, 2022

pecanoro commented Nov 28, 2022

aimane-chnaif commented Nov 28, 2022

pecanoro commented Nov 28, 2022

Santhosh-Sellavel commented Nov 28, 2022

aimane-chnaif commented Nov 28, 2022

pecanoro commented Nov 28, 2022

marcaaron commented Nov 28, 2022

aimane-chnaif commented Nov 28, 2022

pecanoro commented Nov 28, 2022 • edited Loading

aimane-chnaif commented Nov 28, 2022

aimane-chnaif commented Nov 28, 2022

pecanoro commented Nov 29, 2022

aimane-chnaif commented Nov 29, 2022

Santhosh-Sellavel commented Nov 29, 2022 • edited Loading

Reviewer Checklist

Screenshots/Videos

Santhosh-Sellavel commented Nov 29, 2022

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

pecanoro commented Nov 29, 2022

aimane-chnaif commented Nov 30, 2022

aimane-chnaif commented Nov 30, 2022

aimane-chnaif commented Nov 30, 2022

OSBotify commented Nov 30, 2022

Santhosh-Sellavel commented Nov 30, 2022 • edited Loading

OSBotify commented Dec 1, 2022

OSBotify commented Dec 2, 2022

aimane-chnaif commented Nov 24, 2022 •

edited

Loading

pecanoro commented Nov 28, 2022 •

edited

Loading

Santhosh-Sellavel commented Nov 29, 2022 •

edited

Loading

Santhosh-Sellavel commented Nov 30, 2022 •

edited

Loading