-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TextInput, SignInPageForm - Migrate setNativeProps to setAttribute #11038
TextInput, SignInPageForm - Migrate setNativeProps to setAttribute #11038
Conversation
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
@rushatgabhane is this ready for review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well. Please complete the checklist!
@luacmartins checklist completed. |
|
Thanks @rushatgabhane! All yours @stitesExpensify |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @stitesExpensify in version: 1.2.5-0 🚀
|
🚀 Deployed to production by @luacmartins in version: 1.2.5-2 🚀
|
Details
setNativeProps
will not be supported in the post-Fabric world (docs). Removing it's usage is a prerequisite to enable Fabric in #8503I'm creating multiple PRs to migrate it's usage. This is one of many.
Usage of
setNativeProps
is migrated tosetAttribute
Fixed Issues
$ #11050
Tests
Test 1 / 2
sign in page
on web.Test 2 / 2
On mWeb,
PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
Test 1 / 2
sign in page
on web.Test 2 / 2
On mWeb,
Screenshots
Web
Mobile Web
Desktop
Can't get password manager working on desktop :(
iOS
Nothing to see here. Native code wasn't changed

Android
Nothing to see here. Native code wasn't changed
