Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-28] Reports - "Customize your search here" tooltip overlaps the expensify logo. #57070

Closed
4 of 8 tasks
mitarachim opened this issue Feb 19, 2025 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@mitarachim
Copy link

mitarachim commented Feb 19, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.1-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+262@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome
App Component: Other

Action Performed:

  1. Open the staging.new.expensify.com website.
  2. Log in with a new account and complete onboarding modal.
  3. Tap on "Reports" on the bottom of the screen.
  4. Check the "Customize your search here" tooltip.

Expected Result:

Tooltip shouldn´t overlap Expensify logo.

Actual Result:

"Customize your search here" tooltip, is displayed above expensify logo.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6747430_1739937845548.Tooltip.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @maddylewis
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Feb 19, 2025
Copy link

melvin-bot bot commented Feb 19, 2025

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 19, 2025

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 19, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 19, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@zfurtak
Copy link
Contributor

zfurtak commented Feb 19, 2025

Hello, I'm Zuzanna from swm expert agency and I'd like to care care of this issue :)

@maddylewis
Copy link
Contributor

assigned you, @zfurtak !

@SzymczakJ
Copy link
Contributor

Should this be a deploy blocker though, it's a visual bug and after all user has an easy workaround to just dismiss the modal. cc @luacmartins

@cristipaval
Copy link
Contributor

nah, this isn't a deploy blocker

@cristipaval cristipaval added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Feb 19, 2025
@zfurtak zfurtak mentioned this issue Feb 19, 2025
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 19, 2025
@luacmartins luacmartins self-assigned this Feb 19, 2025
@luacmartins
Copy link
Contributor

Agree that we don't need to block the deploy on this.

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Feb 21, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Feb 21, 2025
@melvin-bot melvin-bot bot changed the title Reports - "Customize your search here" tooltip overlaps the expensify logo. [Due for payment 2025-02-28] Reports - "Customize your search here" tooltip overlaps the expensify logo. Feb 21, 2025
Copy link

melvin-bot bot commented Feb 21, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 21, 2025
Copy link

melvin-bot bot commented Feb 21, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.3-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-28. 🎊

For reference, here are some details about the assignees on this issue:

  • @zfurtak does not require payment (Contractor)

Copy link

melvin-bot bot commented Feb 21, 2025

@cristipaval / @luacmartins @maddylewis @zfurtak The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@ahmedGaber93
Copy link
Contributor

@maddylewis please assign me here because I have reviewed the PR.

@ahmedGaber93
Copy link
Contributor

ahmedGaber93 commented Feb 22, 2025

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other: Applause Internal Team
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: https://github.com/Expensify/App/pull/54064/files#r1966392635

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: N/A.

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

It is a minor UI change, so no need for a regression test here.

Copy link

melvin-bot bot commented Feb 28, 2025

Payment Summary

Upwork Job

  • Reviewer: @ahmedGaber93 owed $250 via NewDot
  • Contributor: @zfurtak is from an agency-contributor and not due payment

BugZero Checklist (@maddylewis)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2025
@maddylewis
Copy link
Contributor

the payment summary is correct 👍

#57070 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

7 participants