Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-28] [$250] "Coming soon!" modal doesn't switch to the OldDot experience in the HybridApp. #57050

Closed
2 of 8 tasks
trjExpensify opened this issue Feb 18, 2025 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@trjExpensify
Copy link
Contributor

trjExpensify commented Feb 18, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.0.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: No
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1739903260453919

Action Performed:

Prerequisites:

  • User has accountNVP tryNewDot.classicRedirect.dismissed === true || false
  • User's default workspace does not have the policyNVP isPolicyExpenseChatEnabled === true
  • Access to the HybridApp

  1. Go to expensify.com on the web > Choose the 10+ option
  2. Sign-up for a new account > validate the account.
  3. Create a Control workspace on OldDot (such that isPolicyExpenseChatEnabled is not set)
  4. Run this JS snippet in the console to set a classicRedirect.dismissed value and see the "Try New Expensify" button.
const nvp = NVP.get('tryNewDot') ?? {classicRedirect: {}};
nvp.classicRedirect.dismissed = true;
NVP.set('tryNewDot', nvp);
  1. Go to the HybridApp > sign-in
  2. Click "Try New Expensify" to toggle to NewDot
  3. Go to + > Create expense
  4. Click "Switch to Expensify Classic" in the "Coming soon!" modal.

Expected Result:

User should switch to OldDot experience in the HybridApp

Actual Result:

User is sent to OldDot on mWeb

Workaround:

None.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

ScreenRecording_02-18-2025.18-22-58_1.MP4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021891940355072933384
  • Upwork Job ID: 1891940355072933384
  • Last Price Increase: 2025-02-18
  • Automatic offers:
    • ishpaul777 | Reviewer | 106180189
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @trjExpensify
@trjExpensify trjExpensify added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor labels Feb 18, 2025
Copy link

melvin-bot bot commented Feb 18, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021891940355072933384

@melvin-bot melvin-bot bot changed the title "Coming soon!" modal doesn't switch to the OldDot experience in the HybridApp. [$250] "Coming soon!" modal doesn't switch to the OldDot experience in the HybridApp. Feb 18, 2025
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 18, 2025
Copy link

melvin-bot bot commented Feb 18, 2025

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Feb 18, 2025

Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

@trjExpensify trjExpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 18, 2025
@trjExpensify
Copy link
Contributor Author

@ishpaul777 is going to work on this as a follow-up to the original implementation.

Copy link

melvin-bot bot commented Feb 18, 2025

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@puneetlath puneetlath self-assigned this Feb 18, 2025
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Feb 19, 2025
@melvin-bot melvin-bot bot changed the title [$250] "Coming soon!" modal doesn't switch to the OldDot experience in the HybridApp. [Due for payment 2025-02-28] [$250] "Coming soon!" modal doesn't switch to the OldDot experience in the HybridApp. Feb 21, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 21, 2025
Copy link

melvin-bot bot commented Feb 21, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 21, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.3-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-28. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Feb 21, 2025

@parasharrajat / @ishpaul777 @trjExpensify @parasharrajat / @ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@parasharrajat
Copy link
Member

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: Re-direct to Classic when creating expenses for non-migrated users #51804 #51979 (comment)

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: Not needed

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

Precondition:

Test:

  1. Go to expensify.com on the web > Choose the 10+ option
  2. Sign-up for a new account > validate the account.
  3. Create a Control workspace on OldDot (such that isPolicyExpenseChatEnabled is not set)
  4. Run this JS snippet in the console to set a classicRedirect.dismissed value and see the "Try New Expensify" button.
const nvp = NVP.get('tryNewDot') ?? {classicRedirect: {}};
nvp.classicRedirect.dismissed = true;
NVP.set('tryNewDot', nvp);
  1. Go to the HybridApp > sign-in
  2. Click "Try New Expensify" to toggle to NewDot
  3. Go to + > Create expense
  4. Click "Switch to Expensify Classic" in the "Coming soon!" modal.

Do we agree 👍 or 👎

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Feb 28, 2025
@ishpaul777
Copy link
Contributor

@ishpaul777 requires payment automatic offer (Reviewer)

i was assigned here on Feb19, my eligibility for ND is from 5 Feb, I am eligible for ND payment for this.

@trjExpensify
Copy link
Contributor Author

Created the regression test.

Payment summary as follows:

Go ahead and request, guys!

@parasharrajat
Copy link
Member

Payment requested as per #57050 (comment)

@JmillsExpensify
Copy link

$250 approved for @parasharrajat

@garrettmknight
Copy link
Contributor

$250 approved for @ishpaul777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Status: DONE
Development

No branches or pull requests

6 participants