Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2025-02-17 #56922

Closed
46 tasks done
github-actions bot opened this issue Feb 17, 2025 · 8 comments
Closed
46 tasks done

Deploy Checklist: New Expensify 2025-02-17 #56922

github-actions bot opened this issue Feb 17, 2025 · 8 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2025

Release Version: 9.0.99-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked Firebase Crashlytics for the previous release version and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mountiny mountiny added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Feb 17, 2025
@izarutskaya
Copy link

Regression is at 85% completed.

Unchecked PRs:
#56288 - failing with issue #56288 (comment)
#56305 - found issue #56305 (comment)

DB:
#56943
#56954
#56956

@mjasikowski
Copy link
Contributor

mjasikowski commented Feb 17, 2025

Checking off: #56943

@francoisl francoisl self-assigned this Feb 17, 2025
@francoisl
Copy link
Contributor

francoisl commented Feb 17, 2025

#56954 is now repro on production and likely a backend issue, demoting
#56956 was demoted - the restriction is from using a test Plaid account. TBD full testing steps

@mvtglobally
Copy link

Regression is completed.

Unchecked PRs:
#56288 - failing with #56934. Marked as not a blocker, checking off
#56305 - found issue #56956. Marked as not a blocker. ok to check off?
#56753 (comment) - Blocked to proceed. Can you QA internally?
#56768 (comment) - We are not able to force the error. Can you pls validate this internally?

@mvtglobally
Copy link

We are still able to reproduce the following critical test case bugs:
Create account - Desktop app opens with Magic Link #20121
Create and validate a new account with magic code - #55771
Admin - Issue a new card (VBA flow) -#52199
Pending transaction is created in the account - #48597
New user Onboarding - Invited to workspace as non-admin - #56235

@francoisl
Copy link
Contributor

#56305 - found issue #56956. Marked as not a blocker. ok to check off?

Yes I'm going to check it off, I don't think there's a way to fully complete the QA steps at the moment. See this comment for extra context

#56753 (comment) - Blocked to proceed. Can you QA internally?

Looking 👀

#56768 (comment) - We are not able to force the error. Can you pls validate this internally?

Looking 👀

We are still able to reproduce the following critical test case bugs:
Create account - Desktop app opens with Magic Link #20121
Create and validate a new account with magic code - #55771
Admin - Issue a new card (VBA flow) -#52199
Pending transaction is created in the account - #48597
New user Onboarding - Invited to workspace as non-admin - #56235

Looks like all those are known issues and didn't stop us from deploying in the past, so I'm not going to block either.

@francoisl
Copy link
Contributor

#56753 (comment) - Blocked to proceed. Can you QA internally?

I can't think of a way to QA this internally other than making an actual purchase. I'll use my card tomorrow to make a small purchase and test. It's a small change so I'm not going to wait on it. Worst case scenario we make a follow-up fix.

#56768 (comment) - We are not able to force the error. Can you pls validate this internally?

I think this actually needs some additional backend code that's not live yet. We'll QA it all internally when it's ready.

@francoisl
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

6 participants