Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-27] [Due for payment 2025-02-19] Hybrid - Bank Account - Plaid flow is not pointing to Sandbox environment #52199

Open
2 of 8 tasks
isagoico opened this issue Nov 7, 2024 · 29 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@isagoico
Copy link

isagoico commented Nov 7, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue reported by: Applause - Internal team
Slack conversation (hyperlinked to channel name): #qa

Action Performed:

  1. Navigate to the bank account connect flow
  2. Reach the plaid modal

Expected Result:

Plaid should point to the Sandbox environment to be able to test it.

Actual Result:

Plaid is pointing to the prod environment.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @VictoriaExpensify
@isagoico isagoico added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 7, 2024
Copy link

melvin-bot bot commented Nov 7, 2024

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@AndrewGable
Copy link
Contributor

Thanks for this issue, I assume this is because the HybridApp staging environment checker continues to not work.

@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2024
Copy link

melvin-bot bot commented Nov 11, 2024

@AndrewGable, @VictoriaExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Nov 21, 2024

@AndrewGable @VictoriaExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@VictoriaExpensify
Copy link
Contributor

Oh I'm not sure how I missed this in my queue.

I assume this is because the HybridApp staging environment checker continues to not work.

@AndrewGable it sounds like this is going to be fixed elsewhere, is that right? In which case, is there anything we need to do with this issue?

@VictoriaExpensify
Copy link
Contributor

Bump on the above @AndrewGable

@VictoriaExpensify
Copy link
Contributor

@flaviadefaria I still think #migrate is the best fit for this issue. If you disagree can you please let me know where you think it should go? Roadmap for reference.

@AndrewGable
Copy link
Contributor

We don't need to do anything in this issue, but it's fine to stay open until we fix it.

@AndrewGable AndrewGable added Monthly KSv2 Internal Requires API changes or must be handled by Expensify staff and removed Weekly KSv2 labels Dec 2, 2024
@flaviadefaria
Copy link
Contributor

If this is an issue currently happening in ND then it should go in #retain.

@AndrewGable
Copy link
Contributor

This was merged, but then reverted for blockers. We will continue working on it 🦾

@mountiny
Copy link
Contributor

@jnowakow what are the next steps here, this issue was highlighted as happening in production, can you please work on this one with priority? thank you!

@mountiny mountiny added Daily KSv2 and removed Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2 labels Feb 17, 2025
@jnowakow
Copy link
Contributor

I'll try to figure out what link is passed to Plaid because it seems the only what we pass configuration to it it from App

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 18, 2025
Copy link

melvin-bot bot commented Feb 19, 2025

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Feb 19, 2025

@AndrewGable @mountiny @VictoriaExpensify
As not to forget 😅
Could you assign me here, please, since I'm reviewing this PR ?

Copy link

melvin-bot bot commented Feb 20, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 20, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 20, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 20, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 20, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-02-19] Hybrid - Bank Account - Plaid flow is not pointing to Sandbox environment [Due for payment 2025-02-27] [Due for payment 2025-02-19] Hybrid - Bank Account - Plaid flow is not pointing to Sandbox environment Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.2-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-27. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Feb 20, 2025

@ZhenjaHorbach @VictoriaExpensify @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 27, 2025
Copy link

melvin-bot bot commented Feb 27, 2025

Payment Summary

Upwork Job

BugZero Checklist (@VictoriaExpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
Status: POLISH
Development

No branches or pull requests

8 participants