[Due for payment 2025-02-27] [$125] Update Copy on error message "Please make a selection to continue"

[laurenreidexpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.97-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
**If this was caught during regression testing, add the test name, ID and link from TestRail:**N/A
Email or phone of affected tester (no customers): N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/468859
Issue reported by: @laurenreidexpensify
Slack conversation (hyperlinked to channel name): https://expensify.slack.com/archives/C07HPDRELLD/p1738675483240029

Action Performed:

1. Sign up for a new account
2. Observe this modal
3. Tap or click to dismiss it
4. Observe error message

Expected Result:

Note: (this is not a bug, it's copy update)

Update error at bottom to read "select an option to move forward"

Actual Result:

Error shows - "Please make a selection to continue"

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021889722106893208538
• Upwork Job ID: 1889722106893208538
• Last Price Increase: 2025-02-12

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021889722106893208538

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[github-actions]

⚠️ @FitseTLT Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-12 17:11:15 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update Copy on error message "Please make a selection to continue"

What is the root cause of that problem?

Update copy

What changes do you think we should make in order to solve the problem?

Update copy

App/src/languages/en.ts

Line 1824 in 5ddef34

errorSelection: 'Please make a selection to continue.',

and its Spanish equivalent to "select an option to move forward"

Or

This copy is used in BaseOnboardingEmployee and BaseOnboardingAccounting too and for those cases I think "Please make a selection to continue" is correct because there is a selection to make so we can add a new copy for BaseOnboardingPurpose only as in OP and use it their only.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A - It is a simple copy change.

What alternative solutions did you explore? (Optional)

[ikevin127]

@FitseTLT's proposal looks good to me as this is a straight-forward copy change, they also identified 2 other scenarios where the same translation exists which should be considered.

🎀👀🎀 C+ reviewed

@laurenreidexpensify Two questions regarding this issue:

Update error at bottom to read "select an option to move forward"

1. Should the error read Select and option to move forward. instead, including uppercase S and . (dot) at the end of the sentence, or lowercase and no dot just as seen in OP Expected result ?
2. I'd like to confirm whether we should apply the same copy change to all 3 onboarding scenarios or just the one displayed in OP (First one -> OnboardingPurpose) ?

OnboardingPurpose (OP Issue)	OnboardingEmployees	OnboardingAccounting

[melvin-bot]

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Upwork job price has been updated to $125

[melvin-bot]

❌ There was an error making the offer to @ikevin127 for the Reviewer role. The BZ member will need to manually hire the contributor.

[melvin-bot]

❌ There was an error making the offer to @FitseTLT for the Contributor role. The BZ member will need to manually hire the contributor.

[FitseTLT]

Bump @laurenreidexpensify Waiting for your response on this

[laurenreidexpensify]

Should the error read Select and option to move forward. instead, including uppercase S and . (dot) at the end of the sentence, or lowercase and no dot just as seen in OP Expected result ?

Select an option to move forward. is correct format 👍

I'd like to confirm whether we should apply the same copy change to all 3 onboarding scenarios or just the one displayed in OP (First one -> OnboardingPurpose) ?

Yes please!

[laurenreidexpensify]

@ikevin127 @FitseTLT 👍 addressed above

[ikevin127]

🔄 Given Lauren's answer I think we can simply replace the curent onboarding.errorSelection copy with the updated one as we're using the same validation error message on all 3 onboarding screens (detailed here) which is the only place where that copy is currently used within the entire app.

Status update: currently awaiting PR to be opened by contributor.

[FitseTLT]

Confirmed copy here
Will Create the PR tomorrow

[melvin-bot]

@MonilBhavsar, @FitseTLT, @ikevin127, @laurenreidexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[laurenreidexpensify]

@FitseTLT is there a PR yet? thanks

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.2-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix - Update Copy on error message "Please make a selection to continue" #57111

If no regressions arise, payment will be issued on 2025-02-27. 🎊

For reference, here are some details about the assignees on this issue:

• @FitseTLT requires payment (Needs manual offer from BZ)
• @ikevin127 requires payment (Needs manual offer from BZ)

[melvin-bot]

@ikevin127 @laurenreidexpensify @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[ikevin127]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: Copy update.

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: No offending PR, this was a copy update issue.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A.

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

No regression test needed here as this was a copy update issue.

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @FitseTLT paid $(AMOUNT) via Upwork (LINK)
• ROLE: @ikevin127 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@laurenreidexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1889722106893208538/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[laurenreidexpensify]

Offers sent to @ikevin127 and @FitseTLT in Upwork

[ikevin127]

@laurenreidexpensify Offer accepted, thank you!

[FitseTLT]

Offer Accepted @laurenreidexpensify

[laurenreidexpensify]

Payment Summary:

$125 C+ @ikevin127 paid in upwork
$125 Contibutor @FitseTLT paid in upwork