[Due for payment 2025-02-18] [$500][not here] Prevent "Hmm... It's not here" when logging in by immediately navigating to a report user has access to

[Beamanator]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: ?
Slack conversation #quality:

Action Performed:

1. Get a report ID from an existing account A (can be concierge report, or chat, expense, whatever)
2. Log out of Account A
3. Navigate to the NewDot report link from above while logged out
   • Example: https://staging.new.expensify.com/r/72105063
4. Log in with Account B that doesn't have access to that report ^

Expected Result:

I'd expect your most recently accessed report, or maybe even Concierge report, would be open instead of being greeted with "Hmm... it's not here"

Actual Result:

See that after you log in, you immediately are greeted with "Hmm... it's not here"
- Example logs from my expensifail account

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021882791476183455793
• Upwork Job ID: 1882791476183455793
• Last Price Increase: 2025-01-28
• Automatic offers:
• OmarKoueifi | Contributor | 105922405

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021882791476183455793

[melvin-bot]

Current assignee @muttmuure is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[OmarKoueifi]

Contributor details
Expensify account email: omar.koueifi@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~016c1a735b187cb976

[melvin-bot]

📣 @OmarKoueifi! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[OmarKoueifi]

Contributor details
Your Expensify account email: omar.koueifi@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~016c1a735b187cb976

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[OmarKoueifi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The issue arises when a user navigates to a report they do not have access to (e.g., due to permission issues or the report being restricted). Instead of a smooth fallback mechanism, the user currently sees a message that says: "Hmm... it's not here. You don't have access to this chat".

What is the root cause of that problem?

The root cause lies in the openReportFromDeepLink function in src/libs/actions/Report.ts. After sign-in/sign-up, this function attempts to navigate to the report without first verifying the user's access. Consequently, the app loads the report page, and only then checks permissions, resulting in the error message being displayed.

What changes do you think we should make in order to solve the problem?

1. Modify the handleDeeplinkNavigation logic inside waitForUserSignIn().then to include a pre-check for report access:
   • Use const report = getReport(reportID); to fetch the report details.
   • If report is undefined, it indicates the user does not have access to the report.
2. Implement a fallback mechanism:
   • If the user lacks access, navigate them to a more appropriate screen, such as:
     • The Home Screen
     • The "Recently Accessed Reports" screen
     • The "Concierge Report" (depending on team preference).
   • Ensure valid deep links continue to function as expected for users with the appropriate permissions.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

1. Public Report Access:
   • Verify that users signing in with a public room link are able to access the report without issues.
2. Private Report Access:
   • Verify that users signing in with a private room link, which they have permission to access, are able to open the report successfully.
3. Restricted Access:
   • Verify that users signing in with a private room link, which they do not have permission to access, are redirected to the appropriate fallback screen (e.g., Home Screen or Concierge Report) instead of seeing the error message: "Hmm... it's not here. You don't have access to this chat."

What alternative solutions did you explore? (Optional)

NA

[ijmalik]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Prevent the "Hmm... It's not here" message during login by promptly navigating the user to a report they can access

What is the root cause of that problem?

New requirement

What changes do you think we should make in order to solve the problem?

Introduce a new prop, redirectLastAccessedReport, in the FullPageNotFoundView component. This prop will handle redirection to the most recently accessed report when enabled.

add following code at

App/src/components/BlockingViews/FullPageNotFoundView.tsx

Line 64 in b59f23b

    if (redirectLastAccessedReport) {
        const lastAccessedReport = findLastAccessedReport(false, false, '');
        const lastAccessedReportID = lastAccessedReport?.reportID;
        const lastAccessedReportRoute = ROUTES.REPORT_WITH_ID.getRoute(lastAccessedReportID);
        Navigation.navigate(lastAccessedReportRoute);
        return null;
    }

And when calling FullPageNotFoundView, pass redirectLastAccessedReport as true for redirection where required

Examples:
pass redirectLastAccessedReport prop at
1-

App/src/pages/home/ReportScreen.tsx

Line 793 in b59f23b

shouldShow={shouldShowNotFoundPage}

redirectLastAccessedReport = {shouldShowNotFoundPage}

2-

App/src/pages/iou/request/step/StepScreenWrapper.tsx

Line 67 in 5ec2edd

<FullPageNotFoundView shouldShow={shouldShowNotFoundPage}>

<FullPageNotFoundView shouldShow={shouldShowNotFoundPage} redirectLastAccessedReport = {shouldShowNotFoundPage}>

3-

App/src/pages/workspace/WorkspaceInitialPage.tsx

Line 398 in 5ec2edd

>

redirectLastAccessedReport = {shouldShowNotFoundPage}

4-

App/src/pages/workspace/WorkspacePageWithSections.tsx

Line 180 in 5ec2edd

shouldForceFullScreen

redirectLastAccessedReport = {shouldShow}

5-

App/src/pages/ProfilePage.tsx

Line 196 in 5ec2edd

<FullPageNotFoundView shouldShow={shouldShowBlockingView}>

<FullPageNotFoundView shouldShow={shouldShowBlockingView} redirectLastAccessedReport = {shouldShowBlockingView}>

6-

App/src/pages/ErrorPage/NotFoundPage.tsx

Line 26 in 5ec2edd

shouldShow

            <FullPageNotFoundView
                shouldShow
                redirectLastAccessedReport

Extend to Other Components
Similarly, we can analyze and optimize other components, such as AccessOrNotFoundWrapper, using the same approach applied to FullPageNotFoundView, if necessary.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Automated Test Scenarios
To ensure the issue does not reoccur, automated tests should comprehensively cover the following scenario:

Validate that upon login:
The application opens either:
The most recently accessed report available to the user.
Or the Concierge report (as a fallback).
Ensure that the user is not greeted with the "Hmm... It's not here" message.
This testing ensures proper redirection behavior and eliminates the risk of inaccessible reports disrupting the user experience.

Note:
The code will be further optimized during the PR process.

I have tested the following links, and they are functioning correctly after the changes.

55721-testCases-1.txt

Videos:

Before:

55721-Before-1.mp4

After:

55721-After-1.mp4

[Beamanator]

@rushatgabhane looks like you've got a few proposals to review :D

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.95-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Prevent It's not here message when logging in #55721 #56228

If no regressions arise, payment will be issued on 2025-02-18. 🎊

For reference, here are some details about the assignees on this issue:

• @OmarKoueifi requires payment automatic offer (Contributor)
• @rushatgabhane requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[rushatgabhane]

This is a new feature.
Regression steps:

Test Access When Logged Out and Switching Accounts

1. On Account A, navigate to any report (e.g., a concierge, chat, or expense report) and note the report ID.
2. Log out of Account A.
3. Open the report URL using the noted report ID (e.g., https://staging.new.expensify.com/r/72105063) while logged out.
4. Log in with Account B, which doesn't have access to the selected report.

Expected Result: The app should redirect to your most recently accessed report (or the Concierge report) rather than displaying "Hmm... it's not here".

Test Access When Already Signed In (Unauthorized Report)

1. Log in with an account that should not have access to a specific report.
2. Navigate directly to the report using its link.

Expected Result: The app should display "Hmm... it's not here" to indicate access is not permitted.

Test Access When Already Signed In (Authorized Report)

1. Log in with an account that has access to a known report.
2. Navigate to the report using its link.

Expected Result: The report opens normally without any redirection or error messages.

[muttmuure]

Heading out on leave - adding auto-assigner

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dylanexpensify]

Payment summary:

Contributor: @OmarKoueifi $250 via Upwork
Contributor+: @rushatgabhane $250 via NewDot

Please apply/request!

[garrettmknight]

$500 approved for @rushatgabhane