[Due for payment 2025-02-19] [$250] Copilot - No countdown and code requested message on magic code page when changing access level

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.89-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+100106kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: User Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Account settings > Security.
3. Click Add copilot.
4. Select a user, select access level and proceed to confirmation page.
5. Click Add copilot.
6. On magic code page, there is a countdown and "Code requested. Please check your device." message.
7. Enter correct magic code.
8. Click on the same member under "These members can access your account".
9. Click Change access level.
10. Select a different access level.

Expected Result:

On magic code page when changing access level for existing copilot, it should display a countdown and "Code requested. Please check your device." message.

Actual Result:

On magic code page when changing access level for existing copilot, it does not display a countdown and "Code requested. Please check your device." message, which is not consistent with the magic code page in Step 6.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021884532777502086335
• Upwork Job ID: 1884532777502086335
• Last Price Increase: 2025-01-29
• Automatic offers:
• cretadn22 | Contributor | 105926705

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[etCoderDysto]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-24 13:48:38 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Copilot - No countdown and code requested message on magic code page when changing access level

What is the root cause of that problem?

We have not implemented the timer feature in BaseValidateCodeForm.tsx as we are doing here

App/src/pages/settings/Security/AddDelegate/UpdateDelegateRole/ValidateCodeForm/BaseValidateCodeForm.tsx

Lines 169 to 172 in 95cc648

	/>
	<OfflineWithFeedback errorRowStyles={[styles.mt2]}>
	<View style={[styles.mt2, styles.dFlex, styles.flexColumn, styles.alignItemsStart]}>
	<PressableWithFeedback

What changes do you think we should make in order to solve the problem?

1. Create a state to store time and set it to 30 second
   

   App/src/components/ValidateCodeActionModal/ValidateCodeForm/BaseValidateCodeForm.tsx

   Line 103 in 95cc648

   const [timeRemaining, setTimeRemaining] = useState(CONST.REQUEST_CODE_DELAY as number);

2. Countdown the timer using setTimeOut
   

   App/src/components/ValidateCodeActionModal/ValidateCodeForm/BaseValidateCodeForm.tsx

   Lines 159 to 168 in 95cc648

   	useEffect(() => {
   	if (timeRemaining > 0) {
   	timerRef.current = setTimeout(() => {
   	setTimeRemaining(timeRemaining - 1);
   	}, 1000);
   	}
   	return () => {
   	clearTimeout(timerRef.current);
   	};
   	}, [timeRemaining]);

3. Show timer when time > 0 and user is not offline (shouldShowTimer)
   

   App/src/components/ValidateCodeActionModal/ValidateCodeForm/BaseValidateCodeForm.tsx

   Line 224 in 95cc648

   const shouldShowTimer = timeRemaining > 0 && !isOffline;

4. Show resend link when shouldShowTimer is false

App/src/components/ValidateCodeActionModal/ValidateCodeForm/BaseValidateCodeForm.tsx

Lines 238 to 240 in 95cc648

	{shouldShowTimer && (
	<Text style={[styles.mt5]}>
	{translate('validateCodeForm.requestNewCode')}

5. We should reset the timer when requesting a new magic code

setTimeRemaining(CONST.REQUEST_CODE_DELAY);

App/src/pages/settings/Security/AddDelegate/UpdateDelegateRole/ValidateCodeForm/BaseValidateCodeForm.tsx

Lines 114 to 118 in 95cc648

	const resendValidateCode = () => {
	if (!login) {
	return;
	}
	Delegate.requestValidationCode();

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A as it is a UI change

What alternative solutions did you explore? (Optional)

We can create hook that returns remainingTime and a function that resets the timer following the same logic as the existing timer implementation.

const {remainingTime, resetTimer} = useRequestTimeout(); 

And use remainingTime to decide if should display timer, and call resetTimer when requesting a new code to reset the time.

Tests

• remainingTime should be 30 sec when calling the hook
• remainingTime should be 0 after 30 second
• remaingTime should be 30 sec when resetTimer is called

[cretadn22]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-24 17:25:44 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

There’s no countdown and "Code Requested" message displayed on the Magic Code page when changing the access level.

What is the root cause of that problem?

In UpdateDelegateMagicCodePage Component

App/src/pages/settings/Security/AddDelegate/UpdateDelegateRole/UpdateDelegateMagicCodePage.tsx

Line 22 in 264728f

function UpdateDelegateMagicCodePage({route}: UpdateDelegateMagicCodePageProps) {

We are using an independent ValidateCodeForm (src/pages/settings/Security/AddDelegate/UpdateDelegateRole/ValidateCodeForm/index.tsx), but the code to display the countdown timer has not been implemented

App/src/pages/settings/Security/AddDelegate/UpdateDelegateRole/UpdateDelegateMagicCodePage.tsx

Line 61 in 264728f

<ValidateCodeForm

What changes do you think we should make in order to solve the problem?

Note: In all other instances, we consistently use the ValidateCodeActionModal.

Therefore, I suggest that in the UpdateDelegateMagicCodePage component, we also use ValidateCodeActionModal, as we’ve done in other places like DelegateMagicCodeModal, etc.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

I believe this section is unnecessary

What alternative solutions did you explore? (Optional)

No

[github-actions]

⚠️ @cretadn22 Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[melvin-bot]

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021884532777502086335

[JmillsExpensify]

Opened up to the community.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[jayeshmangwani]

Thank you for the proposals above.
I agree with @cretadn22 's Proposal to use the ValidateCodeActionModal for consistency with other pages that use a timer for the magic code.
Let's go with their proposal.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @cretadn22 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@JmillsExpensify, @jayeshmangwani, @aldo-expensify, @cretadn22 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jayeshmangwani]

We're waiting on @cretadn22 to raise the PR.

[cretadn22]

I'm currently working on this

[cretadn22]

@jayeshmangwani Take a look at this video. When an incorrect magic code is entered, the optimistic value updates initially, but once the backend returns a failure, the old value is reverted, causing a flickering effect. Since updating the delegate role requires a correct code that can only be verified by the backend, we shouldn't use optimistic data for this action. Instead, we could consider displaying a loading spinner while waiting for the API response. This might be out of scope for now, but it would be a valuable improvement.

Screen.Recording.2025-02-04.at.11.52.10.mov

[jayeshmangwani]

Thanks for the input, @cretadn22 , I checked a few cases where we use the magic input, and it flickers in the current production version. So, I think we can include this change in this PR to improve the visual effect.

[dylanexpensify]

@cretadn22 @jayeshmangwani agree with adding that in scope if easy. @cretadn22 when can we expect PR for review?

[cretadn22]

Almost done, @jayeshmangwani Please start reviewing. On the other way, I will update this additional point later today

[cretadn22]

I get this error because of many API calls. It block me from completing this PR

[cretadn22]

@jayeshmangwani All code changes are complete. Please proceed with the review. I will run another test and upload videos once the API is working again.

[jayeshmangwani]

@cretadn22 Maybe you can try with a new account, or you could wait an hour before calling this API again.

[jayeshmangwani]

Please proceed with the review

Yes sure, I'll review PR

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.97-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update delegate flow to use modal #56231

If no regressions arise, payment will be issued on 2025-02-19. 🎊

For reference, here are some details about the assignees on this issue:

• @jayeshmangwani requires payment through NewDot Manual Requests
• @cretadn22 requires payment automatic offer (Contributor)

[melvin-bot]

@jayeshmangwani @JmillsExpensify @jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[jayeshmangwani]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: N/A

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: I don't think this is a regression; rather, it's a design improvement to make it consistent with other Magic code pages.

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to Account settings > Security.
2. Click Add Copilot.
3. Select a user, choose an access level, and proceed to the confirmation page.
4. Click Add Copilot again.
5. Enter the correct magic code.
6. Click on the same member under "These members can access your account."
7. Click Change access level.
8. Select a different access level.
9. Verify that, on the magic code page, when changing the access level for an existing Copilot, a countdown and the message Code requested. Please check your device should be displayed.

Do we agree 👍 or 👎

[garrettmknight]

Taking over for payment - just waiting till Weds.

[garrettmknight]

Payment Summary:

• Contributor: @cretadn22 $250 via Upwork
• Contirbutor+: @jayeshmangwani $250 via NewDot

[garrettmknight]

@jayeshmangwani request whenever you're ready.

[JmillsExpensify]

Payment Summary:

Contributor: @cretadn22 $250 via Upwork
Contirbutor+: @jayeshmangwani $250 via NewDot

[garrettmknight]

$250 approved for @jayeshmangwani