[Due for payment 2025-02-04] Chat - Popup navigation is not seen for account that sent link of a comment

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.88-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #52149
Issue reported by: Applause Internal Team
Device used: Windows 11/ Chrome
App Component: Chat Report View

Action Performed:

Pre-condition:

1. Create a chat between Account A and Account B.
2. Send 200 messages from Account A to Account B.
3. Copy the link to the 70th message and send it to Account B (first link).
4. Copy the link to the 150th message and send it to Account B (second link).

Steps :

1. Sign in to staging.new.expensify.com with Account A from the pre-condition
2. Navigate to the conversation with Account B
3. Click on the first or the second link sent from the pre-condition above

Expected Result:

The conversation is redirected to the exact message. After redirection, a popup should appear at the top of the screen (similar to new message popup).

Actual Result:

Popup navigation does not appear.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6719875_1737464875120.bandicam_2025-01-21_15-48-02-049.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[janicduplessis]

Hello,

Are we talking about this popup?

Would it be possible to see what the expected behaviour is?

[RachCHopkins]

After redirection, a popup should appear at the top of the screen (similar to new message popup).

@IuliiaHerets do you have an example of the pop-up referred to?

When I do that, it navigates me to the line, and highlights it. I don't understand what is supposed to pop up.

But it is difficult to get back to the latest message, so I would assume what @janicduplessis refers to is correct, but doesn't that only appear when there are new messages? In which case it does come up:

[janicduplessis]

From what I understand, it is always supposed to show up when linking to a message, even if there are no new messages. This is the code I broke in #52149. Just want to double check this is the expected behaviour.

If that's the case I have a fix ready here.

[Beamanator]

Still hourly until we get the expected result resolved 😅 I just pinged in #qa to try to get some 👀

[izarutskaya]

Hello @Beamanator yes, we about this popup:

According Test 2: Popup Navigation step 3 from this PR we should see it

[Beamanator]

Thanks!! @janicduplessis how do you think we should proceed? I wonder if we should just call this NAB for now?

[Beamanator]

FYI I love the quick work on the PR but I think this isn't a big enough issue to be a deploy blocker, and it would be nice to give the fix a full test in the next cycle

[janicduplessis]

Sounds good, yes I also think it is not a critical issue.

[melvin-bot]

@janicduplessis, @youssef-lr, @RachCHopkins Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix new messages indicator after comment linking #55582

If no regressions arise, payment will be issued on 2025-02-04. 🎊

For reference, here are some details about the assignees on this issue:

• @janicduplessis does not require payment (Contractor)

[melvin-bot]

@youssef-lr @RachCHopkins @janicduplessis The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[hoangzinh]

@RachCHopkins could you help to assign me to this issue? I helped to review the PR #55582

[RachCHopkins]

Payment Summary:

• Contributor: @hoangzinh to be paid $250 via NewDot manual request
• Contributor+: @janicduplessis is a contractor - no payment required here

No upwork job.

@janicduplessis @youssef-lr does that look correct to you?

[RachCHopkins]

@janicduplessis @youssef-lr do one of you mind just giving your 👍🏼 on the payment summary above?

[melvin-bot]

@janicduplessis @hoangzinh @youssef-lr @RachCHopkins this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @janicduplessis is from an agency-contributor and not due payment
• Reviewer: @hoangzinh owed $250 via NewDot

BugZero Checklist (@RachCHopkins)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[hoangzinh]

Requested payment in ND

[RachCHopkins]

Excellent, Melvin did the confirming for me! The payment summary is correct.

Contributor has requested payment, there is no contract or Upwork post.

[garrettmknight]

$250 approved for @hoangzinh