Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-01-30] Unable to save Merchant or Description when making browser size relatively small #55165

Closed
1 of 8 tasks
m-natarajan opened this issue Jan 13, 2025 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Jan 13, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.84-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @Beamanator
Slack conversation (hyperlinked to channel name): expense

Action Performed:

  1. Create a manual expense
  2. Resize the browser to small when On Confirm details screen
  3. Enter any description or merchant name in the respective field
  4. Click "Save"

Expected Result:

User able to save the entered description or merchant name

Actual Result:

Unable to save and save button non functional when browser size resized to small

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Screen.Recording.2025-01-13.at.9.32.40.AM.mov
macOS.Sequoia.15.2.Chrome.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @michaelkwardrop
@m-natarajan m-natarajan added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Jan 13, 2025
Copy link

melvin-bot bot commented Jan 13, 2025

Triggered auto assignment to @michaelkwardrop (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@bernhardoj
Copy link
Contributor

Same offending PR as #54609. The issue isn't fully resolved yet.

@michaelkwardrop
Copy link
Contributor

Thank you @bernhardoj - I will follow along there!

@garrettmknight garrettmknight moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Jan 14, 2025
@michaelkwardrop
Copy link
Contributor

michaelkwardrop commented Jan 14, 2025

I was able to reproduce many times on michael@expensifail.com

@michaelkwardrop
Copy link
Contributor

@bernhardoj it looks like this is still occurring even with the merge fix for the other issue, are we still waiting on something I am not seeing?

@bernhardoj
Copy link
Contributor

@michaelkwardrop ah, what I'm trying to say is that their attempt to fix #54609 doesn't fully solve the issue yet. Maybe we can ask them to fix this too.

@michaelkwardrop
Copy link
Contributor

Oh got it, thank you @bernhardoj

@bfitzexpensify
Copy link
Contributor

Yes, let's fix as part of #54609

@github-project-automation github-project-automation bot moved this from Bugs and Follow Up Issues to Done in [#whatsnext] #expense Jan 15, 2025
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jan 16, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 23, 2025
@melvin-bot melvin-bot bot changed the title Unable to save Merchant or Description when making browser size relatively small [HOLD for payment 2025-01-30] Unable to save Merchant or Description when making browser size relatively small Jan 23, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 23, 2025
Copy link

melvin-bot bot commented Jan 23, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 23, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.88-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-30. 🎊

Copy link

melvin-bot bot commented Jan 23, 2025

@michaelkwardrop The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@michaelkwardrop
Copy link
Contributor

@bfitzexpensify confirming the above does not need completing, right? :)

@bfitzexpensify
Copy link
Contributor

Yup you can ignore!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 30, 2025
Copy link

melvin-bot bot commented Jan 30, 2025

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
Status: Done
Development

No branches or pull requests

4 participants