[HOLD for payment 2025-01-30] [HOLD for payment 2025-01-15] [$50] mWeb - Workspace - In offline, unable to save workspace name/ description

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.79-0
Reproducible in staging?: Yes
Reproducible in production?: No
Issue reported by: Applause Internal Team
Device used: Redmi note 10s Android 13
App Component: Workspace Settings

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Go to workspace settings
3. Turn off internet connection in the device and wait until header shows no internet connection
4. Create a new workspace
5. Try to rename and save workspace name/ description

Expected Result:

In offline, must be able to save workspace name/ description.

Actual Result:

In offline, unable to save workspace name/ description.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6702759_1735271645135.Screenrecorder-2024-12-27-09-18-10-255_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021872619802972851604
• Upwork Job ID: 1872619802972851604
• Last Price Increase: 2024-12-27
• Automatic offers:
• suneox | Reviewer | 105490775
• huult | Contributor | 105490778

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021872619802972851604

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

[melvin-bot]

Upwork job price has been updated to $50

[mountiny]

50$ to identify the offending PR and confirm with the revert.

I have demoted as I have tested and this is not a problem if the workspace is created online. Its very rare that the workspace would be created offline and user needs to update the name straight after

[bernhardoj]

This is caused by #53529

[mountiny]

@huult @suneox can you please have a look or should we revert your PR and address it later?

[huult]

I'm checking

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.81-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix offline workspace save #54634

If no regressions arise, payment will be issued on 2025-01-15. 🎊

For reference, here are some details about the assignees on this issue:

• @suneox requires payment automatic offer (Reviewer)
• @huult requires payment automatic offer (Contributor)
• @bernhardoj requires payment through NewDot Manual Requests

[melvin-bot]

@suneox @bfitzexpensify @suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[bfitzexpensify]

@suneox please accept the Upwork job.

Payment summary:

@suneox to be paid $50 via Upwork
@huult to be paid $50 via Upwork ✅
@bernhardoj to be paid $50 via ND manual request

[bernhardoj]

Requested in ND.

[bfitzexpensify]

@suneox @huult @bernhardoj - seems this isn't fully resolved: #55165.

Looks like we need to account for making the browser small.

Can you investigate?

[huult]

@bfitzexpensify Yes, I will investigate this issue.

[suneox]

@bfitzexpensify Yes, I will investigate this issue.

@huult Could you please try to update condition on this PR to only handle visualViewport resize for Browser.isMobile?

[huult]

@suneox Yes, I will update it today.

[huult]

The PR is ready: #55334

cc @suneox @bfitzexpensify

[bfitzexpensify]

PR merged but not yet deployed

[JmillsExpensify]

$50 approved for @bernhardoj

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.88-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• resolve issue with unable to save button functionality #55334

If no regressions arise, payment will be issued on 2025-01-30. 🎊

For reference, here are some details about the assignees on this issue:

• @suneox requires payment automatic offer (Reviewer)
• @huult requires payment automatic offer (Contributor)
• @bernhardoj requires payment through NewDot Manual Requests

[melvin-bot]

@suneox @bfitzexpensify @suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[bfitzexpensify]

Closing this out - the PR above was to extend the solution to miss a case that the original PR didn't cover, no further payment required.