[HOLD for payment 2025-01-22] [$250] Status message not cleared after the specified "Clear after" date #53518

m-natarajan · 2024-12-04T03:31:55Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.71-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @rafecolton
Slack conversation (hyperlinked to channel name): ts_external_expensify_bugs

Action Performed:

Set a status message with a "Clear after" date in the profile.
Wait until the specified "Clear after" date has passed.
Check if the status message is automatically cleared.

Expected Result:

The status message should be automatically cleared once the "Clear after" date is reached, ensuring timely updates to the display.

Actual Result:

The status message remains visible even after the "Clear after" date.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Recording.816.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021864198631680121664
Upwork Job ID: 1864198631680121664
Last Price Increase: 2024-12-04

Issue Owner

Current Issue Owner: @MitchExpensify

melvin-bot · 2024-12-04T03:32:03Z

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Shahidullah-Muffakir · 2024-12-04T04:12:59Z

Please re-state the problem that we are trying to solve in this issue.

Custom status is not cleared automatically, if the time defined is reached

What is the root cause of that problem?

It is not considered anywhere, it only clears if users manually clear it by clicking on the clearing status button.

What changes do you think we should make in order to solve the problem?

in the ProfilePage, add this useEffect:

App/src/pages/settings/Profile/ProfilePage.tsx

Line 34 in 0eec30d

function ProfilePage() {

 useEffect(() => {
        if (currentUserPersonalDetails?.status && currentUserPersonalDetails.status.clearAfter) {
            const clearAfterDate = new Date(currentUserPersonalDetails.status.clearAfter);
            const currentDate = new Date();
            // Check if the status has expired
            if (clearAfterDate <= currentDate) {
                // Clear the status
                User.clearCustomStatus();
            }
        }
    }, [currentUserPersonalDetails?.status]);

and we may use this as well:

User.updateDraftCustomStatus({
         text: '',
         emojiCode: '',
         clearAfter: DateUtils.getEndOfToday(),
     });

saifelance · 2024-12-04T04:27:38Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The status message with a "Clear after" date doesn't automatically clear after the specified date, leaving outdated information on the profile.

What is the root cause of that problem?

The component lacks logic to check and clear the status message after the "Clear after" date has passed.

What changes do you think we should make in order to solve the problem?

Solution:

Implement a check to compare the current date with the "Clear after" date.
If passed, clear the status message.
Use useEffect to update the status when currentUserPersonalDetails is updated.

App/src/pages/settings/Profile/ProfilePage.tsx

useEffect(() => {
    const clearDate = currentUserPersonalDetails?.status?.clearAfterDate;
    if (clearDate && new Date(clearDate) <= new Date()) {
        // Clear the status message
        const updatedStatus = { ...currentUserPersonalDetails?.status, text: '', emojiCode: '' };
        setStatus(updatedStatus); // Assuming setStatus is a function to update the state
    }
}, [currentUserPersonalDetails]);

What alternative solutions did you explore? (Optional)

Use a background job or cron job for server-side clearing (more complex).
Create an API endpoint to clear the status (scalable but adds complexity).

melvin-bot · 2024-12-04T06:42:45Z

Job added to Upwork: https://www.upwork.com/jobs/~021864198631680121664

melvin-bot · 2024-12-04T06:42:50Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

nkdengineer · 2024-12-04T07:37:14Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The status message remains visible even after the "Clear after" date.

What is the root cause of that problem?

We don't have any logic to clear the status when the clearAfter time is outdated

What changes do you think we should make in order to solve the problem?

We should add a useEffect in AuthScreen to clear the status when the clearAfter time is outdated. If the current time is more than clearAfter, clear the status immediately. If the current time is less than the clearAfter, create a setTimeout to clear the status after the time is archived

const clearStatus = () => {
    User.clearCustomStatus();
    User.updateDraftCustomStatus({
        text: '',
        emojiCode: '',
        clearAfter: DateUtils.getEndOfToday(),
    });
};
useEffect(() => {
    const currentTime = format(new Date(), 'yyyy-MM-dd HH:mm:ss');
    if (!currentUserPersonalDetails.status?.clearAfter) {
        return;
    }
    if (currentUserPersonalDetails.status?.clearAfter > currentTime) {
        const subMilisecondsTime = new Date(currentUserPersonalDetails.status?.clearAfter).getTime() - new Date(currentTime).getTime();
        const timeoutID = setTimeout(() => {
            clearStatus();
        }, subMilisecondsTime);
        return () => {
            clearTimeout(timeoutID);
        };
    }

    clearStatus();
}, [currentUserPersonalDetails.status?.clearAfter]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

I don't think we need to add a unit test in this case because the new logic is an useEffect in the component

What alternative solutions did you explore? (Optional)

shubham1206agra · 2024-12-04T07:59:25Z

This should be fixed via BE Pusher updates.

MitchExpensify · 2024-12-05T01:25:37Z

So you think this is an internal issue @shubham1206agra ?

eh2077 · 2024-12-05T01:31:21Z

This should be fixed via BE Pusher updates.

While I think frontend improvement is also necessary for offline use cases.

shubham1206agra · 2024-12-05T03:11:49Z

So you think this is an internal issue @shubham1206agra ?

@MitchExpensify Yes

shubham1206agra · 2024-12-05T03:15:29Z

This should be fixed via BE Pusher updates.

While I think frontend improvement is also necessary for offline use cases.

If you have a solution without setTimeout, feel free to propose it.

eh2077 · 2024-12-05T03:58:19Z

@shubham1206agra Interesting! Would you mind sharing your concern about using setTimeout? I searched the codebase and found there's a similar use case in MapboxToken.ts

Cc @nkdengineer

shubham1206agra · 2024-12-05T04:16:05Z

@eh2077 This problem can be solved without setTimeout. So I think we should prefer that.

eh2077 · 2024-12-05T04:32:36Z

@eh2077 This problem can be solved without setTimeout. So I think we should prefer that.

@shubham1206agra Do you mean the BE pusher solution? But that won't help for offline use case right?

rafecolton · 2024-12-05T19:25:29Z

I think we need both actually. The proposed solution is good for offline or if you happen to be online when your status expires. If your status expires and you're not online right away, we still need it to update for anyone who has a conversation with you, so that will require a BE change.

There's a potential edge case I think that goes like this:

Set an expiring status on one client (e.g. phone)
After that status expires, log in on another client (e.g. desktop). It is cleared.
Set a non-expiring status on the second client (desktop).
Open the app on the first device (phone) while offline. It will clear your status. Then reconnect - I expect, though I haven't tested, that it would clear the status you set in (3).

So think the actual solution is:

On the client, check if the status is expired. If it is, clear it from being displayed but do not press the clear button (i.e. don't send the request to the server)
Also clear the status server-side using pusher
When the client re-connects, it should get the update that includes that the status was cleared
If the status was set on another device, the client gets that new status when it reconnects
If status was set in two different places, use whichever happened later. e.g.:
1. I set an expiring status on my phone, then take my phone offline
2. Status expires
3. I load the app on desktop and set a new status
4. I open my phone, still online. Local status is cleared automatically, and I manually set another one.
5. Then I take my phone online - I expect the status I set on desktop will be replaced by the one I set on my phone, since it happened later.

eh2077 · 2024-12-06T15:37:59Z

@rafecolton Excellent summary! For the edge case about managing updates from different devices (online and offline), there's an old similar issue #41911 and slack discussion

Open the app on the first device (phone) while offline. It will clear your status. Then reconnect - I expect, though I haven't tested, that it would clear the status you set in (3).

If the App calls the CLEAR_STATUS command, then yes the status set in (3) will be cleared. I agree with you that it'll be better to just hide the expired status and not to call the clear command.

iv. I open my phone, still ~~online~~ offline. Local status is cleared automatically, and I manually set another one.
v. Then I take my phone online - I expect the status I set on desktop will be replaced by the one I set on my phone, since it happened later.

So, this should be expected according to slack comment

For frontend fix, I think we can go with @nkdengineer 's proposal. Just need to note

On the client, check if the status is expired. If it is, clear it from being displayed but do not press the clear button (i.e. don't send the request to the server)

as suggested by @rafecolton

🎀👀🎀 C+ reviewed

melvin-bot · 2024-12-06T15:38:11Z

Triggered auto assignment to @rlinoz, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

shubham1206agra · 2024-12-06T17:10:54Z

Sorry @eh2077

But I will give my 2 cents here

We should just do conditional check on clearAfter date on FE, and this will help other people status which have clearAfter time.

melvin-bot · 2024-12-09T13:40:08Z

❌ There was an error making the offer to @nkdengineer for the Contributor role. The BZ member will need to manually hire the contributor.

melvin-bot · 2025-01-03T09:47:06Z

This issue has not been updated in over 15 days. @rlinoz, @MitchExpensify, @eh2077, @nkdengineer eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

rlinoz · 2025-01-03T16:22:50Z

PR is being reviewed, I am still trying to understand why the job is not always clearing the status though

melvin-bot · 2025-01-15T13:49:36Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2025-01-15T13:49:43Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: Status message not cleared #53810

If no regressions arise, payment will be issued on 2025-01-22. 🎊

For reference, here are some details about the assignees on this issue:

@eh2077 requires payment through NewDot Manual Requests
@nkdengineer requires payment (Needs manual offer from BZ)

melvin-bot · 2025-01-15T13:49:44Z

@eh2077 @MitchExpensify @eh2077 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

MitchExpensify · 2025-01-18T21:06:33Z

MitchExpensify · 2025-01-18T21:07:37Z

Payment summary:

$250 @eh2077 requires payment through NewDot Manual Requests
$250 @nkdengineer requires payment (Needs manual offer from BZ)

melvin-bot · 2025-01-22T09:04:03Z

Payment Summary

Upwork Job

Reviewer: @eh2077 owed $250 via NewDot
ROLE: @nkdengineer paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@MitchExpensify)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1864198631680121664/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

MitchExpensify · 2025-01-24T16:58:03Z

@nkdengineer https://www.upwork.com/nx/wm/offer/105842031 Offer here for payment

MitchExpensify · 2025-01-24T16:58:51Z

@eh2077 can you please complete BZ steps? Thanks

MitchExpensify · 2025-01-27T23:22:45Z

@eh2077 - bump

eh2077 · 2025-01-28T15:01:11Z

JmillsExpensify · 2025-01-29T10:28:54Z

$250 approved for @eh2077 based on confirmed payment summary.

melvin-bot · 2025-01-31T09:04:45Z

@rlinoz, @MitchExpensify, @eh2077, @nkdengineer Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 4, 2024

melvin-bot bot assigned MitchExpensify Dec 4, 2024

rafecolton added the External Added to denote the issue can be worked on by a contributor label Dec 4, 2024

melvin-bot bot changed the title ~~Status message not cleared after the specified "Clear after" date~~ [$250] Status message not cleared after the specified "Clear after" date Dec 4, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 4, 2024

melvin-bot bot assigned eh2077 Dec 4, 2024

melvin-bot bot assigned rlinoz Dec 6, 2024

rlinoz assigned nkdengineer Dec 9, 2024

melvin-bot bot added Overdue and removed Help Wanted Apply this label when an issue is open to proposals by contributors labels Dec 9, 2024

rlinoz added Weekly KSv2 and removed Monthly KSv2 labels Jan 3, 2025

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 15, 2025

melvin-bot bot changed the title ~~[$250] Status message not cleared after the specified "Clear after" date~~ [HOLD for payment 2025-01-22] [$250] Status message not cleared after the specified "Clear after" date Jan 15, 2025

melvin-bot bot removed the Reviewing Has a PR in review label Jan 15, 2025

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 22, 2025

melvin-bot bot added the Overdue label Jan 24, 2025

melvin-bot bot removed the Overdue label Jan 24, 2025

melvin-bot bot added the Overdue label Jan 27, 2025

melvin-bot bot removed the Overdue label Jan 27, 2025

melvin-bot bot added the Overdue label Jan 30, 2025

MitchExpensify closed this as completed Feb 2, 2025

melvin-bot bot removed the Overdue label Feb 2, 2025

[HOLD for payment 2025-01-22] [$250] Status message not cleared after the specified "Clear after" date #53518

[HOLD for payment 2025-01-22] [$250] Status message not cleared after the specified "Clear after" date #53518

Comments

m-natarajan commented Dec 4, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Dec 4, 2024

Shahidullah-Muffakir commented Dec 4, 2024 • edited Loading

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

saifelance commented Dec 4, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot bot commented Dec 4, 2024

melvin-bot bot commented Dec 4, 2024

nkdengineer commented Dec 4, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

shubham1206agra commented Dec 4, 2024

MitchExpensify commented Dec 5, 2024

eh2077 commented Dec 5, 2024

shubham1206agra commented Dec 5, 2024

shubham1206agra commented Dec 5, 2024

eh2077 commented Dec 5, 2024

shubham1206agra commented Dec 5, 2024

eh2077 commented Dec 5, 2024

rafecolton commented Dec 5, 2024

eh2077 commented Dec 6, 2024

melvin-bot bot commented Dec 6, 2024

shubham1206agra commented Dec 6, 2024

melvin-bot bot commented Dec 9, 2024

melvin-bot bot commented Jan 3, 2025

rlinoz commented Jan 3, 2025

melvin-bot bot commented Jan 15, 2025

melvin-bot bot commented Jan 15, 2025

melvin-bot bot commented Jan 15, 2025

MitchExpensify commented Jan 18, 2025

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

MitchExpensify commented Jan 18, 2025

melvin-bot bot commented Jan 22, 2025 • edited by MitchExpensify Loading

Payment Summary

BugZero Checklist (@MitchExpensify)

MitchExpensify commented Jan 24, 2025

MitchExpensify commented Jan 24, 2025

MitchExpensify commented Jan 27, 2025

eh2077 commented Jan 28, 2025 • edited by MitchExpensify Loading

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

JmillsExpensify commented Jan 29, 2025

melvin-bot bot commented Jan 31, 2025

m-natarajan commented Dec 4, 2024 •

edited by melvin-bot bot

Loading

Shahidullah-Muffakir commented Dec 4, 2024 •

edited

Loading

melvin-bot bot commented Jan 22, 2025 •

edited by MitchExpensify

Loading

eh2077 commented Jan 28, 2025 •

edited by MitchExpensify

Loading