Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRITICAL] New sign-ups redirected from OldDot have two workspaces created on completion of the onboarding modal. #53236

Closed
1 of 8 tasks
trjExpensify opened this issue Nov 28, 2024 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@trjExpensify
Copy link
Contributor

trjExpensify commented Nov 28, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.66-8
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation (hyperlinked to channel name): #convert thread.

Action Performed:

  1. Go to expensify.com
  2. Click “Manage my expenses for a small team (1-9)”
  3. Enter an email address > click “Get Started”
  4. Redirected to NewDot
  5. Observe a workspace has been created.
  6. Complete the accounting step to close the onboarding modal
  7. Observe another workspace is created.

Expected Result:

Only one workspace should be created in the onboarding flow.

Actual Result:

A second workspace is created on completion of the last step of the onboarding flow.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

2024-11-28_01-41-05.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @rayane-djouah
@trjExpensify trjExpensify added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 28, 2024
@trjExpensify trjExpensify self-assigned this Nov 28, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 28, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

Copy link

melvin-bot bot commented Nov 28, 2024

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

@trjExpensify
Copy link
Contributor Author

https://expensify.slack.com/archives/C02NK2DQWUX/p1732761149927579 - asking the C+ team for eyes on the problem here as this is pretty bad in the onboarding journey.

@mountiny
Copy link
Contributor

@FitseTLT original solution did not work on desktop and one other platform so thats why there is one more fix

@trjExpensify
Copy link
Contributor Author

Cool, would be helpful to name the PRs a bit differently 😅

That said, this bug above is on web production. I don't need to refresh or close/reopen etc. Is that PR going to fix it?

@mountiny
Copy link
Contributor

I am not sure, @FitseTLT @rayane-djouah Are you able to reproduce based on the instructions from the OP?

@FitseTLT
Copy link
Contributor

yeah this will solved by the recent PR @mountiny Let's just hold this for it. And also @mountiny bump for your review on that PR. Thx

@trjExpensify
Copy link
Contributor Author

I think we need to CP that to staging to test and hopefully go with today's app deploy to production. This is borderline a fire in my mind, creating two workspaces for every sign-up is rough.

@mountiny
Copy link
Contributor

CPed the PR

@trjExpensify trjExpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 28, 2024
@trjExpensify
Copy link
Contributor Author

Linking for posterity: #53093

We can probably close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Development

No branches or pull requests

4 participants