-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CRITICAL] New sign-ups redirected from OldDot have two workspaces created on completion of the onboarding modal. #53236
Comments
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah ( |
Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new. |
https://expensify.slack.com/archives/C02NK2DQWUX/p1732761149927579 - asking the C+ team for eyes on the problem here as this is pretty bad in the onboarding journey. |
Possible leads:
In fact, @FitseTLT for #52894. One PR is merged, then there's another PR with exactly the same title that's not merged. What's going on there, and is that going to fix this? CC: @mountiny |
@FitseTLT original solution did not work on desktop and one other platform so thats why there is one more fix |
Cool, would be helpful to name the PRs a bit differently 😅 That said, this bug above is on web production. I don't need to refresh or close/reopen etc. Is that PR going to fix it? |
I am not sure, @FitseTLT @rayane-djouah Are you able to reproduce based on the instructions from the OP? |
I think we need to CP that to staging to test and hopefully go with today's app deploy to production. This is borderline a fire in my mind, creating two workspaces for every sign-up is rough. |
CPed the PR |
Linking for posterity: #53093 We can probably close this now. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.66-8
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation (hyperlinked to channel name): #convert thread.
Action Performed:
Expected Result:
Only one workspace should be created in the onboarding flow.
Actual Result:
A second workspace is created on completion of the last step of the onboarding flow.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
2024-11-28_01-41-05.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @rayane-djouahThe text was updated successfully, but these errors were encountered: